crschmidt
def14318a6
If a vector feature has a layer and it is destroyed, remove the feature from
...
the layer, and reset the layer to null.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2971 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 11:19:32 +00:00
crschmidt
201e4bb112
Fix broken references to 'Format/JSON' that were simple copy paste errors.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2970 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 11:02:09 +00:00
crschmidt
5319acfaf1
Minor documentation fixed from fredj ( #570 ).
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2969 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 10:54:01 +00:00
crschmidt
833abcf6f1
#605 "OpenLayers.Feature.Vector: destroy() is defined twice" by fredj, patch
...
by euzuro. thx euz, fredj.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2968 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 10:52:10 +00:00
crschmidt
bc7f415d29
Commit tests and code for #610 , reviewed by Schuyler, to resolve
...
PanZoom/PanZoomBar position argument.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2965 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 01:03:25 +00:00
Schuyler Erle
ce9ba4b560
Prevent OverviewMap.destroy() from running twice, which was causing test failures. Change has been reviewed and approved by crschmidt.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2964 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 00:46:07 +00:00
crschmidt
7c6e6dfc6e
Commit fixed version of r2962. (Hooray for tests.)
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2963 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 00:43:06 +00:00
crschmidt
d9a99143af
Resolve #609 with Schuyler looking over my shoulder for review. Instead of
...
always having a calculateOffset (which overwrites offset if it exists),
always have an offset. If people want calculateOffset, they can add it.
Reported by David Bitner.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2962 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 00:39:53 +00:00
crschmidt
16d543a41f
Add more resolutions to the list supported by Google, up to the current
...
maximum zoom of '19' (20 levels). Closes #613 .
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2961 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 00:25:27 +00:00
crschmidt
7e8605bf0d
Fix SVG renderer. Stephen Woodbridge reported problems with this, and it was
...
also reported on the users mailing list. The problem appears to be that Firefox
has poor support for circles of very small radius -- below about .0002. Since
units were in geographic units, this just didn't work so well. So:
* Change coordinate space to be pixel based.
* Make all x/y operations divided by resolution
* add getComponentsString, getShortString helpers
* Redraw nodes totally on every 'reprojectNode' call
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2960 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 00:15:59 +00:00
Schuyler Erle
79c3ed7d05
Update VML.js to work in IE standards mode; also, update editingtoolbar.html to trigger the (now fixed) bug to make sure it doesn't come back. Fixes #564 .
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2959 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-01 23:22:49 +00:00
Schuyler Erle
175f07c403
Add destroy() to Control.OverviewMap and add a check to map.destroy() to bail if it's already been called (by, say, window.onunload). Fixes #595 .
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2958 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-01 22:29:25 +00:00
Schuyler Erle
772f87f95e
Clean up layers and controls a little more carefully in map.destroy(). Fixes #596 .
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2957 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-01 21:56:20 +00:00
Schuyler Erle
74f557c158
Fix euzuro's broken apostrophe in Marker.js from r122.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2956 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-01 21:37:17 +00:00
Schuyler Erle
07abc57037
Check return values from activate()/deactivate() in subclassed Handlers and Controls, as appropriate. Fixes #599 .
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2955 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-01 21:33:59 +00:00
Schuyler Erle
75b81b2374
Add 4th arg to map.setCenter() to force zoom change, and change
...
map.setBaseLayer() to use it on every base layer change, regardless of whether
the numeric zoom level itself actually changes. Includes test. Fixes #450 .
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2952 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-01 20:47:52 +00:00
crschmidt
53977cf840
* Remove default styling from the Feature.Vector class.
...
* Add a 'style' property to the layer.
* When a feature is added to a layer, either uses the style on the
layer, or uses the default feature style.
* Add test to Layer.Vector for this funcionality
* Adds a preFeatureInsert hook to change a feature *before*
drawing it.
* Change openmnnd demo to include the use of preFeatureInsert
and style attribute on layer.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2949 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-01 12:08:13 +00:00
crschmidt
adee1fb217
Patch from andreas to fix silly typo in Control/Panel. (I need to start
...
naming my external maps something other than 'map' so I can catch these.)
Closes #612 .
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2948 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-31 20:09:13 +00:00
crschmidt
474064b4e5
Clean up all events, not just some of them. Cleans up possible memory leaks.
...
Closes #604 , patch by Erik.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2947 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-31 19:47:05 +00:00
crschmidt
53b23bdf37
make stopObserving/stopObservingElement more resilient: can accept either
...
elements or ids. Closes #603 (and makes #604 work).
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2946 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-31 19:46:04 +00:00
Tim Schaub
1dea6430cd
#611 : let all geometry inherit toString from the superclass - geometry.toString returns well-known text based on Format.WKT.write()
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2945 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-31 19:13:11 +00:00
crschmidt
970c9655ac
Destroy handler if we have one.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2944 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-31 18:33:21 +00:00
crschmidt
4aec64aa67
#571 : Don't subclass Geometry.Point from LonLat, and all neccesary associated
...
changes. Reviewed by tschaub (thx)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2943 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-31 18:30:56 +00:00
Tim Schaub
45da80f8ad
read/write for Well-Known Text representation of vector geometries - support for simple features: Point, MultiPoint, LineString, MultiLineString, Polygon, MultiPolygon, and GeometryCollection - examples/wkt.html for a demonstration
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2942 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-31 16:21:14 +00:00
Schuyler Erle
27dd14a80c
Don't call registerWheelEvents twice in MouseToolbar. Fixes #602 . Rar.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2939 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 22:07:36 +00:00
Schuyler Erle
34352e7af7
MouseDefaults gets a destroy() overhaul.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2938 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 22:05:58 +00:00
Schuyler Erle
2961be423e
Handler.MouseWheel gets destroy(). Fixes #600 . Look out now.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2937 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 22:04:06 +00:00
Schuyler Erle
de9ae4a5bb
Keyboard-related classes get destroy(). Fixes #598 . Ba-ding.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2936 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 22:03:05 +00:00
Schuyler Erle
68bf0c0c4c
Permalink gets a destroy method. Fixes #594 .
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2935 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 21:58:26 +00:00
Schuyler Erle
e1590b2a20
Destroy fix for Control.LayerSwitcher. Fixes #593 .
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2934 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 21:57:07 +00:00
Schuyler Erle
6c166a40e6
Destroy and doc fixes to PanZoomBar. Fixes #592 . Passes all tests.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2933 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 21:54:42 +00:00
Schuyler Erle
882c71a424
Fix PanZoom destroy. Test passes. Fixes #591 .
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2932 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 21:52:47 +00:00
Schuyler Erle
313704b844
Tim's big refactoring of the Geometry modules. Fixes #590 . All tests pass in FF (except the PanZoomBar stuff, which wasn't touched by this patch) and IE.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2931 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 21:42:32 +00:00
euzuro
91ec16c81a
destroy() should always come *right*after* initialize()
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2930 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 01:17:10 +00:00
euzuro
aa4cca057d
patch for #585 - delete row from hash instead of nullifying it. thx tim for quick approval
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2929 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 21:17:12 +00:00
crschmidt
04f911085d
Last patch from #581 , use stopObservingElement, not stopObserving.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2927 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 18:02:43 +00:00
crschmidt
8d725697ba
Erik and I discussed this, and the destroy() here actually does the wrong thing.
...
the innerHTML still prevents the memory leak, but unregistering in this way
doesn't do the right thing. remove it.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2926 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 17:21:27 +00:00
crschmidt
6c67b3a0e3
By setting the innerHTML of the icon, we tell browsers they can clean up the
...
memory associated with those images. This completes #581 , and reduces the
memory used by applications where adding and removing of many markers
is used.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2925 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 16:25:52 +00:00
crschmidt
dcd550ff31
Give icons a less generic ID, for helpful debuggin in the future.
...
(Part of #581 )
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2924 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 16:24:09 +00:00
crschmidt
d86b57b7ec
Typo in panzoombar. committed with sde approval.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2923 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 15:53:37 +00:00
euzuro
913e040fd6
guess i missed a few in r2920
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2921 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 07:09:48 +00:00
crschmidt
919af2ff90
Tabs patch from Erik, to change tabs to spaces so we don't have commit
...
conflicts later on.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2920 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 05:53:01 +00:00
crschmidt
4bb320867b
"add a destroy() function that cycles through the kept references to the buttons and kills their circular refs" to the map object. Patch in #578 by euzuro
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2919 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 04:43:18 +00:00
crschmidt
861c105071
Due to circular references, the layer switcher could prevent layers from
...
being cleared in Internet Explorer. This patch fixes #577 . Patch from Erik.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2918 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 02:38:19 +00:00
Schuyler Erle
bc6786e0ce
Remove event listeners on image div in Tile.Image.destroy(). Fixes #576 .
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2917 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-28 22:46:50 +00:00
Schuyler Erle
619ae89ef4
Don't automatically display Icons when moveTo() is called with a non-null pixel location. Fixes #553 . Thanks Ali Lucio for finding this bug.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2916 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-28 22:29:43 +00:00
Schuyler Erle
160722a16e
Reset element.offsets in Map and Control.PanZoomBar every time movement is
...
initiated. Also, reset element.offsets every time map.updateSize() is called.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2915 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-28 22:26:03 +00:00
euzuro
f850939a3a
fix for small bug in previous patch for #568 which was put in at r2913
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2914 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-28 21:53:27 +00:00
crschmidt
a07a4c309d
Cleanup to Events.js. By Erik, in #568 .
...
* code was only ever removing the first event listener from each element
on unload cache (for loop instead of while)
* code was frequently not removing observers because their associated
elements have already been removed
These two are fixed by this patch. Combined with the previous commits to
setting events, this should fix the memory leaks demonstrated by the 'drip'
tool for IE.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2913 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-28 21:41:08 +00:00
crschmidt
ee5d8eb73f
Use Event.observe instead of the 'on' events which aren't properly cleaned
...
up in IE. #574 . Patch by euzuro.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2912 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-28 21:11:47 +00:00