Commit Graph

216 Commits

Author SHA1 Message Date
Tim Schaub
645bff1286 #628 - a feature has a geometry - a geometry doesn't have a feature - features are rendered, selected, moved, modified, etc - down in the renderer, expando properties on nodes are limited to _featureId, _style, and _options - this removes expandos that created circular references back through the map and to other dom elements - when the renderer is involved in selecting features, it returns a featureId (instead of a geometry or feature) and the layer is responsible for fetching the appropriate feature
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3043 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-10 16:07:56 +00:00
crschmidt
8af1822d94 Minor change to change default post-drag styling from 'default' to ''. This allows
CSS-based styling of the cursor on the map, rather than forcing 'default' after every
action. Tested in Safari, Opera, Firefox, IE7. Patch from Andreas Hocevar, #635. Thanks!


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3042 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-10 10:35:16 +00:00
crschmidt
377e805f26 Fix for #554, click event and PanZoom control conflict, which was caused by
#484 in 2.3. This fixes the 2.2 -> current regression. Should be pulled
up to the 2.4 branch.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3033 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-09 13:22:32 +00:00
crschmidt
098ed43cf6 Add tests and improved functionality for keyboard defaults from #580.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3024 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-06 03:13:17 +00:00
crschmidt
d68caa00a5 Committing patch for #614 to add panel_div element to control panel
subcontrols. This will allow users to modify properties of the div -- for
example, adding a title element to the div. Access this property via
panel_div on the added control after addControls is called on the panel.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2973 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 14:10:38 +00:00
crschmidt
bc7f415d29 Commit tests and code for #610, reviewed by Schuyler, to resolve
PanZoom/PanZoomBar position argument.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2965 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 01:03:25 +00:00
Schuyler Erle
ce9ba4b560 Prevent OverviewMap.destroy() from running twice, which was causing test failures. Change has been reviewed and approved by crschmidt.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2964 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 00:46:07 +00:00
Schuyler Erle
175f07c403 Add destroy() to Control.OverviewMap and add a check to map.destroy() to bail if it's already been called (by, say, window.onunload). Fixes #595.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2958 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-01 22:29:25 +00:00
Schuyler Erle
07abc57037 Check return values from activate()/deactivate() in subclassed Handlers and Controls, as appropriate. Fixes #599.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2955 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-01 21:33:59 +00:00
crschmidt
adee1fb217 Patch from andreas to fix silly typo in Control/Panel. (I need to start
naming my external maps something other than 'map' so I can catch these.)
Closes #612 .


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2948 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-31 20:09:13 +00:00
Schuyler Erle
27dd14a80c Don't call registerWheelEvents twice in MouseToolbar. Fixes #602. Rar.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2939 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 22:07:36 +00:00
Schuyler Erle
34352e7af7 MouseDefaults gets a destroy() overhaul.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2938 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 22:05:58 +00:00
Schuyler Erle
de9ae4a5bb Keyboard-related classes get destroy(). Fixes #598. Ba-ding.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2936 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 22:03:05 +00:00
Schuyler Erle
68bf0c0c4c Permalink gets a destroy method. Fixes #594.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2935 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 21:58:26 +00:00
Schuyler Erle
e1590b2a20 Destroy fix for Control.LayerSwitcher. Fixes #593.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2934 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 21:57:07 +00:00
Schuyler Erle
6c166a40e6 Destroy and doc fixes to PanZoomBar. Fixes #592. Passes all tests.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2933 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 21:54:42 +00:00
Schuyler Erle
882c71a424 Fix PanZoom destroy. Test passes. Fixes #591.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2932 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 21:52:47 +00:00
euzuro
91ec16c81a destroy() should always come *right*after* initialize()
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2930 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 01:17:10 +00:00
crschmidt
d86b57b7ec Typo in panzoombar. committed with sde approval.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2923 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 15:53:37 +00:00
crschmidt
919af2ff90 Tabs patch from Erik, to change tabs to spaces so we don't have commit
conflicts later on.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2920 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 05:53:01 +00:00
crschmidt
4bb320867b "add a destroy() function that cycles through the kept references to the buttons and kills their circular refs" to the map object. Patch in #578 by euzuro
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2919 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 04:43:18 +00:00
crschmidt
861c105071 Due to circular references, the layer switcher could prevent layers from
being cleared in Internet Explorer. This patch fixes #577. Patch from Erik.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2918 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 02:38:19 +00:00
Schuyler Erle
160722a16e Reset element.offsets in Map and Control.PanZoomBar every time movement is
initiated. Also, reset element.offsets every time map.updateSize() is called.



git-svn-id: http://svn.openlayers.org/trunk/openlayers@2915 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-28 22:26:03 +00:00
crschmidt
ee5d8eb73f Use Event.observe instead of the 'on' events which aren't properly cleaned
up in IE. #574. Patch by euzuro.  


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2912 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-28 21:11:47 +00:00
crschmidt
debd2aa458 Change the PanZoom control (ticket #573) to register via Event.observe,
which correctly cleans up memory usage.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2910 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-28 20:59:00 +00:00
Tim Schaub
d82108c2d7 refactoring SelectFeature.js a bit - adding onSelect and onUnselect properties that control users can set to respond to feature selections
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2895 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-26 03:33:17 +00:00
crschmidt
b6e783fb66 With Erik's approval on #341, I'm happy with this. This restores the
mousewheel functionality we had in earlier releases in a similar way, rewritten
for handlers. (The benefit of handlers in this case is that handlers are 
write-once, use many, so the next mousewheel thing we get will *also* be able 
to use this code.)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2877 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-24 23:11:18 +00:00
Schuyler Erle
f218ad4508 Oops, didn't mean to check in changes to Navigation.js in r2867. Undo.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2868 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-23 14:23:58 +00:00
Schuyler Erle
f99d1ce7b0 Fix the event listener leak, which has been a serious problem when large numbers of markers etc. are created. Closes #510.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2867 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-23 14:22:38 +00:00
Tim Schaub
0c8dcabce8 replacing the select handler with a feature handler - with support for up, down, over, out, and move callbacks associated with mouse events on a feature - the select-feature.html example shows the use of a control that activates the feature handler - see #544
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2843 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-21 23:30:20 +00:00
Schuyler Erle
ca831c59d4 Fix the location of blank.gif in OverviewMap.js. Closes #542.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2822 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-20 00:04:17 +00:00
Schuyler Erle
e266f430ca Don't place the MouseToolbar twice. Fixes #537.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2819 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-19 19:46:42 +00:00
crschmidt
3ca974acec Merge vector-2.4 branch back to trunk.
svn merge sandbox/vector-2.4/@2307 sandbox/vector-2.4/@HEAD trunk/openlayers/


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2803 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-16 13:23:56 +00:00
crschmidt
c66f1ce360 Create a function -- OpenLayers.Util.getElement -- which replaces "$". This
should be used in all library code. This patch replaces all uses of "$()" in
existing code. The primary reason for this is to avoid conflicts with libraries
(like Prototype) which might redefine this function differently.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2541 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-08 20:14:03 +00:00
Schuyler Erle
be1ef0ef47 Improve Control.KeyboardDefaults. Fixes #42.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2540 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-08 20:04:04 +00:00
Schuyler Erle
7d6b3fa0b9 Control.Scale now correctly reports scales under 1:500. Includes tests. Fixes #503.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2244 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-02-19 22:42:17 +00:00
euzuro
948406b5b5 patch for #486 -- more error prevention. thanks very much to bart for finding these :-)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2228 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-02-16 16:45:26 +00:00
Schuyler Erle
58b6946b2d Applied bartvde's patch for #498.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2225 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-02-16 16:30:59 +00:00
Schuyler Erle
8b7d34cce6 Applied bartvde's patch to fix #484.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2224 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-02-16 16:27:36 +00:00
crschmidt
6320735671 Fix requires statement for the OverviewMap, reported by bartvde, patch by
euzuro, approved for commit by tschaub (and me). #489


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2190 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-01-31 12:03:37 +00:00
crschmidt
f5b24c2ae4 Double clicking overview map expand/contract button zooms. #478. Patch
from tschaub. (Thx tschaub!)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2189 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-01-31 11:47:59 +00:00
Tim Schaub
7518b9716c prevent overview map extent rectangle from getting dropped (FF only) - see #468
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2166 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-01-20 16:49:52 +00:00
Tim Schaub
f30d0e40c2 lets the overview map work with the argparser control - see #474
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2165 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-01-19 22:25:17 +00:00
Tim Schaub
6284941ea0 allow controls to live outside the map viewport - with changes to the overview map to handle this (#465)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2135 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-01-10 21:56:07 +00:00
crschmidt
4cac0a24ea Patch from euzuro for #448 . Make mouseWheel work on MouseToolbar.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2102 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-12-27 16:53:26 +00:00
euzuro
112978ac3d patch for #441 - resolving Rico namespace conflict
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2094 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-12-22 19:31:32 +00:00
crschmidt
063a10d4ac This is the outside_viewport patch from tschaub for #446:
http://trac.openlayers.org/attachment/ticket/446/outside_viewport.patch

The large diff is because I am suffering under constraints of a bad working
environment. I hate newlines! This patch closes #446.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2088 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-12-22 17:35:34 +00:00
crschmidt
9c6817f5d6 Apply "patch to put event registering in correct place", euzuro, #448 .
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2075 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-12-16 15:47:37 +00:00
euzuro
15c2ab578f mousewheel zooms on mouse position. patch from #341. thanks frederic \!
git-svn-id: http://svn.openlayers.org/trunk/openlayers@1945 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-11-21 09:32:13 +00:00
crschmidt
786c2a20fb Change files to point to repository-license. Part of build process will now
be to change the licensing terms in the final build.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@1721 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2006-10-24 18:16:39 +00:00