Commit Graph

1421 Commits

Author SHA1 Message Date
euzuro
91ec16c81a destroy() should always come *right*after* initialize()
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2930 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 01:17:10 +00:00
euzuro
aa4cca057d patch for #585 - delete row from hash instead of nullifying it. thx tim for quick approval
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2929 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 21:17:12 +00:00
euzuro
ede2d39e54 add build script to create a non-minimized (uncompressed) version of OL. this is helpful for debugging
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2928 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 19:48:57 +00:00
crschmidt
04f911085d Last patch from #581 , use stopObservingElement, not stopObserving.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2927 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 18:02:43 +00:00
crschmidt
8d725697ba Erik and I discussed this, and the destroy() here actually does the wrong thing.
the innerHTML still prevents the memory leak, but unregistering in this way
doesn't do the right thing. remove it. 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2926 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 17:21:27 +00:00
crschmidt
6c67b3a0e3 By setting the innerHTML of the icon, we tell browsers they can clean up the
memory associated with those images. This completes #581, and reduces the 
memory used by applications where adding and removing of many markers 
is used.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2925 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 16:25:52 +00:00
crschmidt
dcd550ff31 Give icons a less generic ID, for helpful debuggin in the future.
(Part of #581)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2924 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 16:24:09 +00:00
crschmidt
d86b57b7ec Typo in panzoombar. committed with sde approval.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2923 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 15:53:37 +00:00
crschmidt
6f49f8759a Fix PanZoom tests with #575 from Erik. Should add IE support back to this,
but it's not working for me at the moment, so I'm going to trust that the
rest of our testing process will find this at the moment, since the panzoom 
is obvious enough that people will see it if it breaks :)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2922 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 10:56:30 +00:00
euzuro
913e040fd6 guess i missed a few in r2920
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2921 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 07:09:48 +00:00
crschmidt
919af2ff90 Tabs patch from Erik, to change tabs to spaces so we don't have commit
conflicts later on.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2920 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 05:53:01 +00:00
crschmidt
4bb320867b "add a destroy() function that cycles through the kept references to the buttons and kills their circular refs" to the map object. Patch in #578 by euzuro
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2919 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 04:43:18 +00:00
crschmidt
861c105071 Due to circular references, the layer switcher could prevent layers from
being cleared in Internet Explorer. This patch fixes #577. Patch from Erik.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2918 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 02:38:19 +00:00
Schuyler Erle
bc6786e0ce Remove event listeners on image div in Tile.Image.destroy(). Fixes #576.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2917 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-28 22:46:50 +00:00
Schuyler Erle
619ae89ef4 Don't automatically display Icons when moveTo() is called with a non-null pixel location. Fixes #553. Thanks Ali Lucio for finding this bug.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2916 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-28 22:29:43 +00:00
Schuyler Erle
160722a16e Reset element.offsets in Map and Control.PanZoomBar every time movement is
initiated. Also, reset element.offsets every time map.updateSize() is called.



git-svn-id: http://svn.openlayers.org/trunk/openlayers@2915 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-28 22:26:03 +00:00
euzuro
f850939a3a fix for small bug in previous patch for #568 which was put in at r2913
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2914 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-28 21:53:27 +00:00
crschmidt
a07a4c309d Cleanup to Events.js. By Erik, in #568.
* code was only ever removing the first event listener from each element 
    on unload cache (for loop instead of while) 
  * code was frequently not removing observers because their associated 
    elements have already been removed 
These two are fixed by this patch. Combined with the previous commits to
setting events, this should fix the memory leaks demonstrated by the 'drip'
tool for IE.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2913 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-28 21:41:08 +00:00
crschmidt
ee5d8eb73f Use Event.observe instead of the 'on' events which aren't properly cleaned
up in IE. #574. Patch by euzuro.  


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2912 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-28 21:11:47 +00:00
crschmidt
afa416fd2d Set the ID of the image before registering events on it. The Event.observe
call uses the element ID to cache the listeners for later deletion, 
so this closes a leak.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2911 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-28 21:08:27 +00:00
crschmidt
debd2aa458 Change the PanZoom control (ticket #573) to register via Event.observe,
which correctly cleans up memory usage.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2910 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-28 20:59:00 +00:00
Tim Schaub
f570758676 modify the drag handler so that it only modifies IE's document.onselectstart while dragging - add jsodc text - all browser event handlers now return a boolean - activate and deactivate respect the return of the parent class and return the same
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2908 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-28 15:59:49 +00:00
euzuro
55440ab092 clearGrid() gets called only once, no reason to put it so far away from where it gets called. tired of scrolling
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2907 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-27 22:30:42 +00:00
crschmidt
64dd004b5c Regression test for r2905 : test that the image has a div, and that it's
later destroyed. (There was a problem before where 0,0 was destroyed but 
1,1 wasn't)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2906 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-27 22:21:12 +00:00
euzuro
77da7967ab apply patch for #566 - bug in grid.destroy()
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2905 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-27 22:12:28 +00:00
Tim Schaub
afdaa6249f adding test for Format.js
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2904 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-27 21:41:16 +00:00
Tim Schaub
7218fe6ea8 take toString away from Geometry.LineString and Geometry.LinearRing, give it to Geometry.Collection, and make sure the IE hack doesn't clobber toString during inheritance - see #552 and #565
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2901 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-26 23:06:54 +00:00
Schuyler Erle
09bef10687 Oops, didn't mean to apply changes to BaseTypes in r2899. I gotta remember to svn status next time.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2900 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-26 20:56:48 +00:00
Schuyler Erle
a05363e91e Patch from fredj adds toString() method to Geometry.Linearring. Fixes #565. Thanks, Fred.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2899 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-26 20:55:32 +00:00
euzuro
87977f7bfe final patch for #510 -- new datastructure suggested and implemented by james for the events entry cache. speeds up all event operations
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2896 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-26 17:33:35 +00:00
Tim Schaub
d82108c2d7 refactoring SelectFeature.js a bit - adding onSelect and onUnselect properties that control users can set to respond to feature selections
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2895 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-26 03:33:17 +00:00
crschmidt
8e3856b4ac Commit small change to destroy events objects when destroying objects with
events. This removes a number of minor memory leaks with creating/destroying
popups, layers, features, and markers.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2894 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-26 00:50:31 +00:00
crschmidt
eb13974c5e Add MapServer layer fixes and tests. Paul wrote these tests (yay Paul!), and
found all the bugs. This fixes #545, #546, #547, #548 and #562.    


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2893 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-25 21:35:12 +00:00
crschmidt
75425b9cd4 Add Steve Woodbridge to authors for MapServer Untiled contribution.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2892 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-25 21:24:39 +00:00
crschmidt
f3c75e2d29 Add MapServer Untiled Layer to OpenLayers. Originally developed by Steve
Woodbridge, tests written by Paul Spencer and some reworking done. Thanks
to both Paul and Steve for this code. (Closes #526.) 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2891 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-25 21:20:14 +00:00
euzuro
67963c3e86 good eye tim. patch for #560.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2882 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-25 14:49:31 +00:00
crschmidt
b6e783fb66 With Erik's approval on #341, I'm happy with this. This restores the
mousewheel functionality we had in earlier releases in a similar way, rewritten
for handlers. (The benefit of handlers in this case is that handlers are 
write-once, use many, so the next mousewheel thing we get will *also* be able 
to use this code.)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2877 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-24 23:11:18 +00:00
crschmidt
b22958ff2e Committing patch from #559 to add CLASS_NAME for all classes. (I never cleaned
these up like I should have.)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2876 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-24 23:07:30 +00:00
euzuro
cb9723d202 patch for #556 - give the map object its own unique ID
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2875 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-24 01:39:49 +00:00
euzuro
177215befc applying (yet another) patch for #549. this one eliminates the double-destruction of the map due to the unload of window
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2874 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-24 01:37:28 +00:00
euzuro
d10b4a37df applying (yet another) patch for #510
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2873 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-24 01:34:58 +00:00
Schuyler Erle
f218ad4508 Oops, didn't mean to check in changes to Navigation.js in r2867. Undo.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2868 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-23 14:23:58 +00:00
Schuyler Erle
f99d1ce7b0 Fix the event listener leak, which has been a serious problem when large numbers of markers etc. are created. Closes #510.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2867 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-23 14:22:38 +00:00
euzuro
803e8b9dbd fix for #457 - allow specification of whether or not to let events fallthrough the map
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2863 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-22 21:06:29 +00:00
euzuro
f66441779c fix extra commas in test. all ie tests should pass now
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2862 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-22 20:46:12 +00:00
Schuyler Erle
c5406bbfeb Workaround for a bug in IE where toString() can't be assigned to an object in Util.extend()?? Strange but true. Fixes #552, wherein Geometry.Point tests fail. Tests now pass in IE.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2861 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-22 20:39:16 +00:00
Schuyler Erle
27a423a5f8 Inadvertently checked in a change to BaseTypes in r2859. Undoing it.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2860 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-22 20:36:25 +00:00
Schuyler Erle
185d10f211 Fix the inheritance chain in Geometry.Point. Fixes #551.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2859 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-22 20:35:16 +00:00
euzuro
3ed14463f2 second patch to fix #549. this time, instead of just clearing out everything in the div, it removes only what it added.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2858 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-22 19:47:48 +00:00
Schuyler Erle
aa30fe25f4 Undo r2851 and reinstate r2842. I think I had a cached test in my browser. Double oops.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2856 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-22 19:25:28 +00:00