Commit Graph

394 Commits

Author SHA1 Message Date
Tim Schaub
9cc8aed695 #892 - give layer switcher isMouseDown property to differentiate from mouseDown method
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3899 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-14 13:36:19 +00:00
Tim Schaub
b4da05da35 #774 - drag control only calls move callback with a change in pixel position - DragPan control simplified
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3891 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-11 03:32:41 +00:00
crschmidt
73d2825c4e Commiting fix for #716, "Make LayerSwitcher support displayInLayerSwitcher
for Base Layers", reviewed by Erik, tested by tschaub.   


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3853 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-04 12:14:32 +00:00
euzuro
cf5a53959e ND Update: make array's say what they're made of, and a few other small bits, like mistyped and a couple missing <>s
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3829 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-31 20:02:03 +00:00
euzuro
8c552be94b as universally approved on discussions on dev list, replace new Array() with []. all tests pass ff & ie6
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3815 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-25 22:48:02 +00:00
euzuro
5f0bde51da as universally approved on discussions on dev list, replace new Object() with {}. all tests pass ff & ie6
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3814 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-25 22:39:28 +00:00
crschmidt
ef0a4697a4 EditingToolbar depends on these handlers being around -- if they're not, then
dragfeature will blow up with an error of 'handler is not a constructor'. 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3812 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-25 16:46:36 +00:00
euzuro
fd4d2918f1 fix for #853 - remove JSDOC comments from CLASS_NAME variables
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3787 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-23 15:09:09 +00:00
crschmidt
a34f4570f3 Docs were copy pasted from drawcontrol. Fix that.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3778 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-18 21:19:13 +00:00
Tim Schaub
cc1b0269c9 #823 New class style. Instead of OldStyle = Class.create(); OldStyle.prototype = Class.inherit(Parent, prototype), we now use NewStyle = OpenLayers.Class(Parent, prototype). New style classes allow for backwards compatibility [you can use OldStyle = Class.create(); Class.inherit(NewStyle, prototype)]. The Class.create and Class.inherit functions are deprecated. Backwards compatibility will be removed at 3.0. Thanks Erik for the careful review.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3767 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-16 20:25:11 +00:00
crschmidt
9ebf950e3b #651: PanZoom should not block mouseup. Reviewed by tschaub.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3766 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-16 19:07:01 +00:00
crschmidt
1a27eaaf70 Control.SelectFeature docs had an extra line in them for some reason.
Remove it. 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3749 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-15 06:01:39 +00:00
Tim Schaub
07e2bc319b #826 - reworking arguments for NavToolbar and parent class
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3682 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-10 21:15:28 +00:00
Tim Schaub
658df9df72 #802 - giving all classes a constructor that don't currently have one - this for Natural Docs
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3595 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-05 18:54:38 +00:00
euzuro
de004699c4 add inheritance to navigation control
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3588 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-05 17:34:31 +00:00
euzuro
3d73171521 move all nd comments for CLASS_NAME back to jsdoc style. my personal opinion is that we should get rid of this comment entirely... but that's something that can be debated. so long as they are all the same, it makes it easier to do a global replace when a decision is reached
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3587 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-05 17:33:29 +00:00
euzuro
cbc0e3817a fixing nd comment. Thanks Eric L
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3580 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-05 13:22:13 +00:00
crschmidt
3948913bfc Merge all changes from the naturaldocs sandbox. This brings all the work that
has been done in the NaturalDocs branch back to trunk. Thanks to everyone who
helped out in making this happen. (I could list people, but the list would
be long, and I'm already mentally on vacation.)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3545 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-06-29 15:59:20 +00:00
crschmidt
3cd58c5121 Commit fix for #726 from andreas, with proper tests.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3389 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-06-20 23:53:51 +00:00
crschmidt
debffb8f12 Fix typos in documentation strings.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3347 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-06-17 04:04:54 +00:00
crschmidt
39c3d11043 Patch from #674, approved by SDE, plus an example.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3285 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-06-07 19:19:06 +00:00
euzuro
964b09a15f fix for #740 - Mixed parameters to initialize() function in ArgParser control
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3256 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-06-05 21:35:40 +00:00
crschmidt
b8d2aa5539 Add patch for #726 for TOGGLE controls to control panels (patch from
Andreas Hocevar).


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3207 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-05-30 13:51:28 +00:00
Tim Schaub
37458e1004 #696: let events fall through the extent rectangle
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3133 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-05-04 15:00:47 +00:00
Tim Schaub
67d44a04ba #690 - force overview map extent rectangle to have non-negative dimensions - thanks openlayers
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3107 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-05-01 15:21:18 +00:00
euzuro
8d2dfcf218 fix for #682 - let the mouseup event go through on the panel, just like all other controls
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3106 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-05-01 14:21:21 +00:00
Tim Schaub
0d2b12c7cd #662 - prototypes shouldn't get properties that might be extended
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3070 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-12 15:12:44 +00:00
crschmidt
15465a455b Move LayerSwitcher control down so that it doesn't overlay with the editing
controls. Patch from #641 by penyaskito . Thanks!


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3068 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-12 10:59:17 +00:00
Tim Schaub
645bff1286 #628 - a feature has a geometry - a geometry doesn't have a feature - features are rendered, selected, moved, modified, etc - down in the renderer, expando properties on nodes are limited to _featureId, _style, and _options - this removes expandos that created circular references back through the map and to other dom elements - when the renderer is involved in selecting features, it returns a featureId (instead of a geometry or feature) and the layer is responsible for fetching the appropriate feature
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3043 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-10 16:07:56 +00:00
crschmidt
8af1822d94 Minor change to change default post-drag styling from 'default' to ''. This allows
CSS-based styling of the cursor on the map, rather than forcing 'default' after every
action. Tested in Safari, Opera, Firefox, IE7. Patch from Andreas Hocevar, #635. Thanks!


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3042 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-10 10:35:16 +00:00
crschmidt
377e805f26 Fix for #554, click event and PanZoom control conflict, which was caused by
#484 in 2.3. This fixes the 2.2 -> current regression. Should be pulled
up to the 2.4 branch.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3033 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-09 13:22:32 +00:00
crschmidt
098ed43cf6 Add tests and improved functionality for keyboard defaults from #580.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3024 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-06 03:13:17 +00:00
crschmidt
d68caa00a5 Committing patch for #614 to add panel_div element to control panel
subcontrols. This will allow users to modify properties of the div -- for
example, adding a title element to the div. Access this property via
panel_div on the added control after addControls is called on the panel.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2973 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 14:10:38 +00:00
crschmidt
bc7f415d29 Commit tests and code for #610, reviewed by Schuyler, to resolve
PanZoom/PanZoomBar position argument.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2965 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 01:03:25 +00:00
Schuyler Erle
ce9ba4b560 Prevent OverviewMap.destroy() from running twice, which was causing test failures. Change has been reviewed and approved by crschmidt.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2964 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 00:46:07 +00:00
Schuyler Erle
175f07c403 Add destroy() to Control.OverviewMap and add a check to map.destroy() to bail if it's already been called (by, say, window.onunload). Fixes #595.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2958 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-01 22:29:25 +00:00
Schuyler Erle
07abc57037 Check return values from activate()/deactivate() in subclassed Handlers and Controls, as appropriate. Fixes #599.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2955 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-01 21:33:59 +00:00
crschmidt
adee1fb217 Patch from andreas to fix silly typo in Control/Panel. (I need to start
naming my external maps something other than 'map' so I can catch these.)
Closes #612 .


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2948 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-31 20:09:13 +00:00
Schuyler Erle
27dd14a80c Don't call registerWheelEvents twice in MouseToolbar. Fixes #602. Rar.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2939 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 22:07:36 +00:00
Schuyler Erle
34352e7af7 MouseDefaults gets a destroy() overhaul.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2938 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 22:05:58 +00:00
Schuyler Erle
de9ae4a5bb Keyboard-related classes get destroy(). Fixes #598. Ba-ding.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2936 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 22:03:05 +00:00
Schuyler Erle
68bf0c0c4c Permalink gets a destroy method. Fixes #594.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2935 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 21:58:26 +00:00
Schuyler Erle
e1590b2a20 Destroy fix for Control.LayerSwitcher. Fixes #593.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2934 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 21:57:07 +00:00
Schuyler Erle
6c166a40e6 Destroy and doc fixes to PanZoomBar. Fixes #592. Passes all tests.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2933 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 21:54:42 +00:00
Schuyler Erle
882c71a424 Fix PanZoom destroy. Test passes. Fixes #591.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2932 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 21:52:47 +00:00
euzuro
91ec16c81a destroy() should always come *right*after* initialize()
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2930 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 01:17:10 +00:00
crschmidt
d86b57b7ec Typo in panzoombar. committed with sde approval.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2923 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 15:53:37 +00:00
crschmidt
919af2ff90 Tabs patch from Erik, to change tabs to spaces so we don't have commit
conflicts later on.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2920 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 05:53:01 +00:00
crschmidt
4bb320867b "add a destroy() function that cycles through the kept references to the buttons and kills their circular refs" to the map object. Patch in #578 by euzuro
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2919 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 04:43:18 +00:00
crschmidt
861c105071 Due to circular references, the layer switcher could prevent layers from
being cleared in Internet Explorer. This patch fixes #577. Patch from Erik.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2918 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-29 02:38:19 +00:00