Commit Graph

460 Commits

Author SHA1 Message Date
Éric Lemoine
fecab1c963 fix typo in a ND comment
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4234 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-12 11:19:28 +00:00
crschmidt
48a9da00ec Erik helps me fix tests. I threaten to kill him for criticizing my lack
of semicolons. All is well. Fix for "keep selected features drawn with 
the right style". (Closes #916)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4232 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-12 05:12:00 +00:00
euzuro
c519879391 adding OpenLayers.Control.Attribution to the list of controls in the OL suite. includes example and tests. very nice. Thanks to pensyakito and cr5 for getting this together and complete. (Closes #103)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4231 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-12 04:37:45 +00:00
euzuro
0e8e7ab620 making the layerswitcher a little smarter. Instead of fancy 'noEvent' parameters, we just keep track of the state at each redraw. When asked to redraw, we then check first to see if anything has changed before going ahead with the redraw. Also in this patch, we add a 'visibilitychanged' event to the layer's events object -- upon request by users. (Closes #878)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4229 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-12 04:00:31 +00:00
euzuro
7a37ed4423 make sure permalink updates itself when layers change name/visibility or when a baselayer switch is made. (Closes #359)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4228 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-12 03:26:35 +00:00
euzuro
dab3144c16 coding standards - mostly 4ixing spacing issues with ND comments.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4185 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-04 10:34:45 +00:00
Tim Schaub
cecf760f29 make the drag handler and drag feature control tidy up after themselves - as a bonus, give the drag feature control an onStart method. Thanks for the review crschmidt (closes #950).
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4147 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-30 23:25:49 +00:00
Tim Schaub
06d41662d7 Clear the feature stored by the DragFeature control when the user moves the mouse out or when dragging completes (closes #942).
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4111 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-29 18:56:48 +00:00
Tim Schaub
c2148651ed Filling our log with cruft, adding meaningless conflicts for merges, and changing a comment style that ndocs could care less about, this commit changes Return to Returns (closes #945).
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4110 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-29 18:44:10 +00:00
euzuro
b5ef77096c wiki/NaturalDocs says we should be using 'Return:' and not 'Returns:' so this patch is fixing that. Of course, in the process, I came across not a few instances where other ND related whitespace or typos were at odds with a peaceful, uniform OL codebase. No functional changes here, just makin' things pretty.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4109 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-29 18:08:32 +00:00
Tim Schaub
a1c040e3c0 removing use of getArgs from the library (closes #860).
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4080 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-28 20:18:47 +00:00
crschmidt
c79f1a56c8 (Closes #730) These changes make the permalink smarter in the case where we
already have some URL args in the URL. Thanks to penyaskito for the bug 
report.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4047 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-27 12:46:29 +00:00
Paul Spencer
c6850a2b6a Closes #914: change Map initialization to object rather than id to avoid a bug when launching from a permalink.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3992 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-23 14:09:57 +00:00
crschmidt
6194452b8a Since John already went ahead and committed the main change, I'm just going
to finish this one up. All commits are in comments, so a review doesn't seem
strictly neccesary. This closes #918 and fixes all the copyrights that I could 
find in the code.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3984 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-23 11:29:06 +00:00
Tim Schaub
7081aab12a #638 let features be dragged
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3958 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-22 21:23:07 +00:00
Tim Schaub
9de2749502 #774 - dragPan only calls setCenter if the map moves - thanks for the discussion and careful review Eric!
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3902 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-14 15:27:59 +00:00
Tim Schaub
9cc8aed695 #892 - give layer switcher isMouseDown property to differentiate from mouseDown method
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3899 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-14 13:36:19 +00:00
Tim Schaub
b4da05da35 #774 - drag control only calls move callback with a change in pixel position - DragPan control simplified
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3891 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-11 03:32:41 +00:00
crschmidt
73d2825c4e Commiting fix for #716, "Make LayerSwitcher support displayInLayerSwitcher
for Base Layers", reviewed by Erik, tested by tschaub.   


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3853 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-04 12:14:32 +00:00
euzuro
cf5a53959e ND Update: make array's say what they're made of, and a few other small bits, like mistyped and a couple missing <>s
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3829 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-31 20:02:03 +00:00
euzuro
8c552be94b as universally approved on discussions on dev list, replace new Array() with []. all tests pass ff & ie6
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3815 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-25 22:48:02 +00:00
euzuro
5f0bde51da as universally approved on discussions on dev list, replace new Object() with {}. all tests pass ff & ie6
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3814 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-25 22:39:28 +00:00
crschmidt
ef0a4697a4 EditingToolbar depends on these handlers being around -- if they're not, then
dragfeature will blow up with an error of 'handler is not a constructor'. 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3812 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-25 16:46:36 +00:00
euzuro
fd4d2918f1 fix for #853 - remove JSDOC comments from CLASS_NAME variables
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3787 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-23 15:09:09 +00:00
crschmidt
a34f4570f3 Docs were copy pasted from drawcontrol. Fix that.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3778 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-18 21:19:13 +00:00
Tim Schaub
cc1b0269c9 #823 New class style. Instead of OldStyle = Class.create(); OldStyle.prototype = Class.inherit(Parent, prototype), we now use NewStyle = OpenLayers.Class(Parent, prototype). New style classes allow for backwards compatibility [you can use OldStyle = Class.create(); Class.inherit(NewStyle, prototype)]. The Class.create and Class.inherit functions are deprecated. Backwards compatibility will be removed at 3.0. Thanks Erik for the careful review.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3767 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-16 20:25:11 +00:00
crschmidt
9ebf950e3b #651: PanZoom should not block mouseup. Reviewed by tschaub.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3766 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-16 19:07:01 +00:00
crschmidt
1a27eaaf70 Control.SelectFeature docs had an extra line in them for some reason.
Remove it. 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3749 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-15 06:01:39 +00:00
Tim Schaub
07e2bc319b #826 - reworking arguments for NavToolbar and parent class
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3682 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-10 21:15:28 +00:00
Tim Schaub
658df9df72 #802 - giving all classes a constructor that don't currently have one - this for Natural Docs
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3595 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-05 18:54:38 +00:00
euzuro
de004699c4 add inheritance to navigation control
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3588 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-05 17:34:31 +00:00
euzuro
3d73171521 move all nd comments for CLASS_NAME back to jsdoc style. my personal opinion is that we should get rid of this comment entirely... but that's something that can be debated. so long as they are all the same, it makes it easier to do a global replace when a decision is reached
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3587 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-05 17:33:29 +00:00
euzuro
cbc0e3817a fixing nd comment. Thanks Eric L
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3580 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-05 13:22:13 +00:00
crschmidt
3948913bfc Merge all changes from the naturaldocs sandbox. This brings all the work that
has been done in the NaturalDocs branch back to trunk. Thanks to everyone who
helped out in making this happen. (I could list people, but the list would
be long, and I'm already mentally on vacation.)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3545 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-06-29 15:59:20 +00:00
crschmidt
3cd58c5121 Commit fix for #726 from andreas, with proper tests.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3389 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-06-20 23:53:51 +00:00
crschmidt
debffb8f12 Fix typos in documentation strings.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3347 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-06-17 04:04:54 +00:00
crschmidt
39c3d11043 Patch from #674, approved by SDE, plus an example.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3285 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-06-07 19:19:06 +00:00
euzuro
964b09a15f fix for #740 - Mixed parameters to initialize() function in ArgParser control
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3256 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-06-05 21:35:40 +00:00
crschmidt
b8d2aa5539 Add patch for #726 for TOGGLE controls to control panels (patch from
Andreas Hocevar).


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3207 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-05-30 13:51:28 +00:00
Tim Schaub
37458e1004 #696: let events fall through the extent rectangle
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3133 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-05-04 15:00:47 +00:00
Tim Schaub
67d44a04ba #690 - force overview map extent rectangle to have non-negative dimensions - thanks openlayers
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3107 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-05-01 15:21:18 +00:00
euzuro
8d2dfcf218 fix for #682 - let the mouseup event go through on the panel, just like all other controls
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3106 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-05-01 14:21:21 +00:00
Tim Schaub
0d2b12c7cd #662 - prototypes shouldn't get properties that might be extended
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3070 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-12 15:12:44 +00:00
crschmidt
15465a455b Move LayerSwitcher control down so that it doesn't overlay with the editing
controls. Patch from #641 by penyaskito . Thanks!


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3068 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-12 10:59:17 +00:00
Tim Schaub
645bff1286 #628 - a feature has a geometry - a geometry doesn't have a feature - features are rendered, selected, moved, modified, etc - down in the renderer, expando properties on nodes are limited to _featureId, _style, and _options - this removes expandos that created circular references back through the map and to other dom elements - when the renderer is involved in selecting features, it returns a featureId (instead of a geometry or feature) and the layer is responsible for fetching the appropriate feature
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3043 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-10 16:07:56 +00:00
crschmidt
8af1822d94 Minor change to change default post-drag styling from 'default' to ''. This allows
CSS-based styling of the cursor on the map, rather than forcing 'default' after every
action. Tested in Safari, Opera, Firefox, IE7. Patch from Andreas Hocevar, #635. Thanks!


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3042 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-10 10:35:16 +00:00
crschmidt
377e805f26 Fix for #554, click event and PanZoom control conflict, which was caused by
#484 in 2.3. This fixes the 2.2 -> current regression. Should be pulled
up to the 2.4 branch.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3033 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-09 13:22:32 +00:00
crschmidt
098ed43cf6 Add tests and improved functionality for keyboard defaults from #580.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3024 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-06 03:13:17 +00:00
crschmidt
d68caa00a5 Committing patch for #614 to add panel_div element to control panel
subcontrols. This will allow users to modify properties of the div -- for
example, adding a title element to the div. Access this property via
panel_div on the added control after addControls is called on the panel.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2973 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 14:10:38 +00:00
crschmidt
bc7f415d29 Commit tests and code for #610, reviewed by Schuyler, to resolve
PanZoom/PanZoomBar position argument.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2965 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 01:03:25 +00:00