Webgl renderer / hide shader compile errors
Turns out there are sometimes errors that will not prevent the shader from functioning normally. As such, it is not possible to simply throw when there are errors/warnings. Since we are not logging to the console, these errors will have to stay hidden unless the user requests them explicitly.
This commit is contained in:
@@ -143,10 +143,6 @@ class WebGLPointsLayerRenderer extends WebGLLayerRenderer {
|
||||
options.vertexShader
|
||||
);
|
||||
|
||||
if (this.getShaderCompileErrors()) {
|
||||
throw new Error(this.getShaderCompileErrors());
|
||||
}
|
||||
|
||||
/**
|
||||
* @type {boolean}
|
||||
* @private
|
||||
@@ -158,10 +154,6 @@ class WebGLPointsLayerRenderer extends WebGLLayerRenderer {
|
||||
options.hitVertexShader
|
||||
);
|
||||
|
||||
if (this.getShaderCompileErrors()) {
|
||||
throw new Error(this.getShaderCompileErrors());
|
||||
}
|
||||
|
||||
const customAttributes = options.attributes ?
|
||||
options.attributes.map(function(attribute) {
|
||||
return {
|
||||
|
||||
Reference in New Issue
Block a user