From ae66471e78fa78ed2e671a1b59232c341aa32415 Mon Sep 17 00:00:00 2001 From: Olivier Guyot Date: Wed, 6 Nov 2019 21:40:36 +0100 Subject: [PATCH] Webgl renderer / hide shader compile errors Turns out there are sometimes errors that will not prevent the shader from functioning normally. As such, it is not possible to simply throw when there are errors/warnings. Since we are not logging to the console, these errors will have to stay hidden unless the user requests them explicitly. --- src/ol/renderer/webgl/PointsLayer.js | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/ol/renderer/webgl/PointsLayer.js b/src/ol/renderer/webgl/PointsLayer.js index 868f9b7473..d6da17801d 100644 --- a/src/ol/renderer/webgl/PointsLayer.js +++ b/src/ol/renderer/webgl/PointsLayer.js @@ -143,10 +143,6 @@ class WebGLPointsLayerRenderer extends WebGLLayerRenderer { options.vertexShader ); - if (this.getShaderCompileErrors()) { - throw new Error(this.getShaderCompileErrors()); - } - /** * @type {boolean} * @private @@ -158,10 +154,6 @@ class WebGLPointsLayerRenderer extends WebGLLayerRenderer { options.hitVertexShader ); - if (this.getShaderCompileErrors()) { - throw new Error(this.getShaderCompileErrors()); - } - const customAttributes = options.attributes ? options.attributes.map(function(attribute) { return {