Commit Graph

  • 8647addda2 #629 - remove events from geometry Tim Schaub 2007-04-03 22:57:26 +00:00
  • 45407e9eda add Vector.destroyFeatures() and call it from WFS.moveTo(), which keeps WFS from loading the same set of features multiple times. Includes tests. fixes #622. Schuyler Erle 2007-04-03 21:02:59 +00:00
  • 23131012dd fix for #624 - merge stop() and safeStopPropagation() euzuro 2007-04-03 17:15:57 +00:00
  • 10b5c2df17 patch for #621 - assign items in the elements hash table a unique cacheID instead of relying on the element's actual 'id' property. thx for thorough review sde euzuro 2007-04-03 16:54:14 +00:00
  • 140090ec20 Zoom to features after done loading them. crschmidt 2007-04-03 16:42:19 +00:00
  • d0115ccf26 patch for #625 - remove extraneous _observeAndCache() function which is only used once. it doesnt seem to conceptually abstract anything, so lets inline it euzuro 2007-04-03 15:54:27 +00:00
  • 33cb7fd0d4 patch for #623 - remove unused pointerX() and pointerY() functions euzuro 2007-04-03 15:38:16 +00:00
  • 9aa92d491c events.js cleanup: more ifs without brackets euzuro 2007-04-03 01:42:21 +00:00
  • 7aac1c1cfe coding standards. if statement without brackets and multiple return euzuro 2007-04-03 01:38:22 +00:00
  • 8440cbaf43 coding standards if statement should always be followed by braces. also, add comment euzuro 2007-04-03 01:37:04 +00:00
  • 2734030a82 move unloadCache() down so that stopObserving and stopObservingElement() are next to eachother euzuro 2007-04-03 01:31:45 +00:00
  • 2f8a093f83 move observe() function up to right before its private counterpart euzuro 2007-04-03 01:27:39 +00:00
  • ade794259f move observers definition to top of object definition for readability euzuro 2007-04-03 01:26:39 +00:00
  • 8007b6719a events.js: style (never underestimate style) euzuro 2007-04-02 23:12:55 +00:00
  • ed0fca9157 events cleanup: fix tabs euzuro 2007-04-02 23:00:55 +00:00
  • dfa4441646 step one of cleaning up events.js: jsdoc euzuro 2007-04-02 22:49:13 +00:00
  • b6a5e6619a #529 give tiles gutters - all layers that use Tile.Image must now look after layer.imageSize and layer.imageOffset - this is handled by layer.setTileSize - for untiled layers, setTileSize must be defined by the subclass - gutters are currently supported in Layer.Mapserver and Layer.WMS Tim Schaub 2007-04-02 17:18:38 +00:00
  • c7805cd5e9 propset svn:eol-style native recursively throughout trunk. enjoy\! Schuyler Erle 2007-04-02 16:46:34 +00:00
  • 7f0ccb69f0 propset svn:eol-style native recursively throughout trunk. enjoy\! Schuyler Erle 2007-04-02 16:46:34 +00:00
  • 9e688ebb37 #616: untiled layers set layer.tileSize on setMap and every moveTo Tim Schaub 2007-04-02 15:13:50 +00:00
  • d68caa00a5 Committing patch for #614 to add panel_div element to control panel subcontrols. This will allow users to modify properties of the div -- for example, adding a title element to the div. Access this property via panel_div on the added control after addControls is called on the panel. crschmidt 2007-04-02 14:10:38 +00:00
  • cefccb4a89 Updated version of JSMin downloaded from http://www.crockford.com/javascript/jsmin.html , fixes #617 . crschmidt 2007-04-02 12:59:28 +00:00
  • def14318a6 If a vector feature has a layer and it is destroyed, remove the feature from the layer, and reset the layer to null. crschmidt 2007-04-02 11:19:32 +00:00
  • 201e4bb112 Fix broken references to 'Format/JSON' that were simple copy paste errors. crschmidt 2007-04-02 11:02:09 +00:00
  • 5319acfaf1 Minor documentation fixed from fredj (#570). crschmidt 2007-04-02 10:54:01 +00:00
  • 833abcf6f1 #605 "OpenLayers.Feature.Vector: destroy() is defined twice" by fredj, patch by euzuro. thx euz, fredj. crschmidt 2007-04-02 10:52:10 +00:00
  • bc7f415d29 Commit tests and code for #610, reviewed by Schuyler, to resolve PanZoom/PanZoomBar position argument. crschmidt 2007-04-02 01:03:25 +00:00
  • ce9ba4b560 Prevent OverviewMap.destroy() from running twice, which was causing test failures. Change has been reviewed and approved by crschmidt. Schuyler Erle 2007-04-02 00:46:07 +00:00
  • 7c6e6dfc6e Commit fixed version of r2962. (Hooray for tests.) crschmidt 2007-04-02 00:43:06 +00:00
  • d9a99143af Resolve #609 with Schuyler looking over my shoulder for review. Instead of always having a calculateOffset (which overwrites offset if it exists), always have an offset. If people want calculateOffset, they can add it. Reported by David Bitner. crschmidt 2007-04-02 00:39:53 +00:00
  • 16d543a41f Add more resolutions to the list supported by Google, up to the current maximum zoom of '19' (20 levels). Closes #613. crschmidt 2007-04-02 00:25:27 +00:00
  • 7e8605bf0d Fix SVG renderer. Stephen Woodbridge reported problems with this, and it was also reported on the users mailing list. The problem appears to be that Firefox has poor support for circles of very small radius -- below about .0002. Since units were in geographic units, this just didn't work so well. So: * Change coordinate space to be pixel based. * Make all x/y operations divided by resolution * add getComponentsString, getShortString helpers * Redraw nodes totally on every 'reprojectNode' call crschmidt 2007-04-02 00:15:59 +00:00
  • 79c3ed7d05 Update VML.js to work in IE standards mode; also, update editingtoolbar.html to trigger the (now fixed) bug to make sure it doesn't come back. Fixes #564. Schuyler Erle 2007-04-01 23:22:49 +00:00
  • 175f07c403 Add destroy() to Control.OverviewMap and add a check to map.destroy() to bail if it's already been called (by, say, window.onunload). Fixes #595. Schuyler Erle 2007-04-01 22:29:25 +00:00
  • 772f87f95e Clean up layers and controls a little more carefully in map.destroy(). Fixes #596. Schuyler Erle 2007-04-01 21:56:20 +00:00
  • 74f557c158 Fix euzuro's broken apostrophe in Marker.js from r122. Schuyler Erle 2007-04-01 21:37:17 +00:00
  • 07abc57037 Check return values from activate()/deactivate() in subclassed Handlers and Controls, as appropriate. Fixes #599. Schuyler Erle 2007-04-01 21:33:59 +00:00
  • 75b81b2374 Add 4th arg to map.setCenter() to force zoom change, and change map.setBaseLayer() to use it on every base layer change, regardless of whether the numeric zoom level itself actually changes. Includes test. Fixes #450. Schuyler Erle 2007-04-01 20:47:52 +00:00
  • 53977cf840 * Remove default styling from the Feature.Vector class. * Add a 'style' property to the layer. * When a feature is added to a layer, either uses the style on the layer, or uses the default feature style. * Add test to Layer.Vector for this funcionality * Adds a preFeatureInsert hook to change a feature *before* drawing it. * Change openmnnd demo to include the use of preFeatureInsert and style attribute on layer. crschmidt 2007-04-01 12:08:13 +00:00
  • d85cfbdebf Patch from andreas to fix silly typo in Control/Panel. (I need to start naming my external maps something other than 'map' so I can catch these.) Closes #612 . crschmidt 2007-03-31 20:09:13 +00:00
  • adee1fb217 Patch from andreas to fix silly typo in Control/Panel. (I need to start naming my external maps something other than 'map' so I can catch these.) Closes #612 . crschmidt 2007-03-31 20:09:13 +00:00
  • 474064b4e5 Clean up all events, not just some of them. Cleans up possible memory leaks. Closes #604, patch by Erik. crschmidt 2007-03-31 19:47:05 +00:00
  • 53b23bdf37 make stopObserving/stopObservingElement more resilient: can accept either elements or ids. Closes #603 (and makes #604 work). crschmidt 2007-03-31 19:46:04 +00:00
  • 1dea6430cd #611: let all geometry inherit toString from the superclass - geometry.toString returns well-known text based on Format.WKT.write() Tim Schaub 2007-03-31 19:13:11 +00:00
  • 970c9655ac Destroy handler if we have one. crschmidt 2007-03-31 18:33:21 +00:00
  • 4aec64aa67 #571: Don't subclass Geometry.Point from LonLat, and all neccesary associated changes. Reviewed by tschaub (thx) crschmidt 2007-03-31 18:30:56 +00:00
  • 45da80f8ad read/write for Well-Known Text representation of vector geometries - support for simple features: Point, MultiPoint, LineString, MultiLineString, Polygon, MultiPolygon, and GeometryCollection - examples/wkt.html for a demonstration Tim Schaub 2007-03-31 16:21:14 +00:00
  • 7ab96241b0 adding folder for Format tests Tim Schaub 2007-03-31 15:58:32 +00:00
  • 27dd14a80c Don't call registerWheelEvents twice in MouseToolbar. Fixes #602. Rar. Schuyler Erle 2007-03-30 22:07:36 +00:00
  • 34352e7af7 MouseDefaults gets a destroy() overhaul. Schuyler Erle 2007-03-30 22:05:58 +00:00
  • 2961be423e Handler.MouseWheel gets destroy(). Fixes #600. Look out now. Schuyler Erle 2007-03-30 22:04:06 +00:00
  • de9ae4a5bb Keyboard-related classes get destroy(). Fixes #598. Ba-ding. Schuyler Erle 2007-03-30 22:03:05 +00:00
  • 68bf0c0c4c Permalink gets a destroy method. Fixes #594. Schuyler Erle 2007-03-30 21:58:26 +00:00
  • e1590b2a20 Destroy fix for Control.LayerSwitcher. Fixes #593. Schuyler Erle 2007-03-30 21:57:07 +00:00
  • 6c166a40e6 Destroy and doc fixes to PanZoomBar. Fixes #592. Passes all tests. Schuyler Erle 2007-03-30 21:54:42 +00:00
  • 882c71a424 Fix PanZoom destroy. Test passes. Fixes #591. Schuyler Erle 2007-03-30 21:52:47 +00:00
  • 313704b844 Tim's big refactoring of the Geometry modules. Fixes #590. All tests pass in FF (except the PanZoomBar stuff, which wasn't touched by this patch) and IE. Schuyler Erle 2007-03-30 21:42:32 +00:00
  • 91ec16c81a destroy() should always come *right*after* initialize() euzuro 2007-03-30 01:17:10 +00:00
  • aa4cca057d patch for #585 - delete row from hash instead of nullifying it. thx tim for quick approval euzuro 2007-03-29 21:17:12 +00:00
  • ede2d39e54 add build script to create a non-minimized (uncompressed) version of OL. this is helpful for debugging euzuro 2007-03-29 19:48:57 +00:00
  • 04f911085d Last patch from #581 , use stopObservingElement, not stopObserving. crschmidt 2007-03-29 18:02:43 +00:00
  • 8d725697ba Erik and I discussed this, and the destroy() here actually does the wrong thing. the innerHTML still prevents the memory leak, but unregistering in this way doesn't do the right thing. remove it. crschmidt 2007-03-29 17:21:27 +00:00
  • 6c67b3a0e3 By setting the innerHTML of the icon, we tell browsers they can clean up the memory associated with those images. This completes #581, and reduces the memory used by applications where adding and removing of many markers is used. crschmidt 2007-03-29 16:25:52 +00:00
  • dcd550ff31 Give icons a less generic ID, for helpful debuggin in the future. (Part of #581) crschmidt 2007-03-29 16:24:09 +00:00
  • d86b57b7ec Typo in panzoombar. committed with sde approval. crschmidt 2007-03-29 15:53:37 +00:00
  • 6f49f8759a Fix PanZoom tests with #575 from Erik. Should add IE support back to this, but it's not working for me at the moment, so I'm going to trust that the rest of our testing process will find this at the moment, since the panzoom is obvious enough that people will see it if it breaks :) crschmidt 2007-03-29 10:56:30 +00:00
  • 913e040fd6 guess i missed a few in r2920 euzuro 2007-03-29 07:09:48 +00:00
  • 919af2ff90 Tabs patch from Erik, to change tabs to spaces so we don't have commit conflicts later on. crschmidt 2007-03-29 05:53:01 +00:00
  • 4bb320867b "add a destroy() function that cycles through the kept references to the buttons and kills their circular refs" to the map object. Patch in #578 by euzuro crschmidt 2007-03-29 04:43:18 +00:00
  • 861c105071 Due to circular references, the layer switcher could prevent layers from being cleared in Internet Explorer. This patch fixes #577. Patch from Erik. crschmidt 2007-03-29 02:38:19 +00:00
  • bc6786e0ce Remove event listeners on image div in Tile.Image.destroy(). Fixes #576. Schuyler Erle 2007-03-28 22:46:50 +00:00
  • 619ae89ef4 Don't automatically display Icons when moveTo() is called with a non-null pixel location. Fixes #553. Thanks Ali Lucio for finding this bug. Schuyler Erle 2007-03-28 22:29:43 +00:00
  • 160722a16e Reset element.offsets in Map and Control.PanZoomBar every time movement is initiated. Also, reset element.offsets every time map.updateSize() is called. Schuyler Erle 2007-03-28 22:26:03 +00:00
  • f850939a3a fix for small bug in previous patch for #568 which was put in at r2913 euzuro 2007-03-28 21:53:27 +00:00
  • a07a4c309d Cleanup to Events.js. By Erik, in #568. * code was only ever removing the first event listener from each element on unload cache (for loop instead of while) * code was frequently not removing observers because their associated elements have already been removed These two are fixed by this patch. Combined with the previous commits to setting events, this should fix the memory leaks demonstrated by the 'drip' tool for IE. crschmidt 2007-03-28 21:41:08 +00:00
  • ee5d8eb73f Use Event.observe instead of the 'on' events which aren't properly cleaned up in IE. #574. Patch by euzuro. crschmidt 2007-03-28 21:11:47 +00:00
  • afa416fd2d Set the ID of the image before registering events on it. The Event.observe call uses the element ID to cache the listeners for later deletion, so this closes a leak. crschmidt 2007-03-28 21:08:27 +00:00
  • debd2aa458 Change the PanZoom control (ticket #573) to register via Event.observe, which correctly cleans up memory usage. crschmidt 2007-03-28 20:59:00 +00:00
  • f570758676 modify the drag handler so that it only modifies IE's document.onselectstart while dragging - add jsodc text - all browser event handlers now return a boolean - activate and deactivate respect the return of the parent class and return the same Tim Schaub 2007-03-28 15:59:49 +00:00
  • 55440ab092 clearGrid() gets called only once, no reason to put it so far away from where it gets called. tired of scrolling euzuro 2007-03-27 22:30:42 +00:00
  • 64dd004b5c Regression test for r2905 : test that the image has a div, and that it's later destroyed. (There was a problem before where 0,0 was destroyed but 1,1 wasn't) crschmidt 2007-03-27 22:21:12 +00:00
  • 77da7967ab apply patch for #566 - bug in grid.destroy() euzuro 2007-03-27 22:12:28 +00:00
  • afdaa6249f adding test for Format.js Tim Schaub 2007-03-27 21:41:16 +00:00
  • 7218fe6ea8 take toString away from Geometry.LineString and Geometry.LinearRing, give it to Geometry.Collection, and make sure the IE hack doesn't clobber toString during inheritance - see #552 and #565 Tim Schaub 2007-03-26 23:06:54 +00:00
  • 09bef10687 Oops, didn't mean to apply changes to BaseTypes in r2899. I gotta remember to svn status next time. Schuyler Erle 2007-03-26 20:56:48 +00:00
  • a05363e91e Patch from fredj adds toString() method to Geometry.Linearring. Fixes #565. Thanks, Fred. Schuyler Erle 2007-03-26 20:55:32 +00:00
  • 0516f6dd21 final patch for #510 -- new datastructure suggested and implemented by james for the events entry cache. speeds up all event operations euzuro 2007-03-26 17:33:35 +00:00
  • 87977f7bfe final patch for #510 -- new datastructure suggested and implemented by james for the events entry cache. speeds up all event operations euzuro 2007-03-26 17:33:35 +00:00
  • d82108c2d7 refactoring SelectFeature.js a bit - adding onSelect and onUnselect properties that control users can set to respond to feature selections Tim Schaub 2007-03-26 03:33:17 +00:00
  • 8e3856b4ac Commit small change to destroy events objects when destroying objects with events. This removes a number of minor memory leaks with creating/destroying popups, layers, features, and markers. crschmidt 2007-03-26 00:50:31 +00:00
  • eb13974c5e Add MapServer layer fixes and tests. Paul wrote these tests (yay Paul!), and found all the bugs. This fixes #545, #546, #547, #548 and #562. crschmidt 2007-03-25 21:35:12 +00:00
  • 0ba702478c Add Steve Woodbridge to authors for MapServer Untiled contribution. crschmidt 2007-03-25 21:24:39 +00:00
  • 75425b9cd4 Add Steve Woodbridge to authors for MapServer Untiled contribution. crschmidt 2007-03-25 21:24:39 +00:00
  • f3c75e2d29 Add MapServer Untiled Layer to OpenLayers. Originally developed by Steve Woodbridge, tests written by Paul Spencer and some reworking done. Thanks to both Paul and Steve for this code. (Closes #526.) crschmidt 2007-03-25 21:20:14 +00:00
  • 67963c3e86 good eye tim. patch for #560. euzuro 2007-03-25 14:49:31 +00:00
  • b6e783fb66 With Erik's approval on #341, I'm happy with this. This restores the mousewheel functionality we had in earlier releases in a similar way, rewritten for handlers. (The benefit of handlers in this case is that handlers are write-once, use many, so the next mousewheel thing we get will *also* be able to use this code.) crschmidt 2007-03-24 23:11:18 +00:00
  • b22958ff2e Committing patch from #559 to add CLASS_NAME for all classes. (I never cleaned these up like I should have.) crschmidt 2007-03-24 23:07:30 +00:00
  • cb9723d202 patch for #556 - give the map object its own unique ID euzuro 2007-03-24 01:39:49 +00:00
  • 177215befc applying (yet another) patch for #549. this one eliminates the double-destruction of the map due to the unload of window euzuro 2007-03-24 01:37:28 +00:00
  • d10b4a37df applying (yet another) patch for #510 euzuro 2007-03-24 01:34:58 +00:00