Tagging the Final 2.9.1 Release

git-svn-id: http://svn.openlayers.org/tags/openlayers/release-2.9.1@10291 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf

lib/OpenLayers/Layer/Vector.js

@@ -106,8 +106,8 @@ OpenLayers.Layer.Vector = OpenLayers.Class(OpenLayers.Layer, {
 
     /**
      * APIProperty: isBaseLayer
-     * {Boolean} The layer is a base layer.  Default is true.  Set this property
-     * in the layer options
+     * {Boolean} The layer is a base layer.  Default is false.  Set this property
+     * in the layer options.
      */
     isBaseLayer: false,
 

lib/OpenLayers/Map.js

@@ -1402,6 +1402,10 @@ OpenLayers.Map = OpenLayers.Class({
         var size = new OpenLayers.Size(this.div.clientWidth, 
                                        this.div.clientHeight);
 
+        if (size.w == 0 && size.h == 0 || isNaN(size.w) && isNaN(size.h)) {
+            size.w = this.div.offsetWidth;
+            size.h = this.div.offsetHeight;
+        }
         if (size.w == 0 && size.h == 0 || isNaN(size.w) && isNaN(size.h)) {
             size.w = parseInt(this.div.style.width);
             size.h = parseInt(this.div.style.height);

lib/OpenLayers/Protocol/HTTP.js

@@ -358,10 +358,11 @@ OpenLayers.Protocol.HTTP = OpenLayers.Class(OpenLayers.Protocol, {
      *     the feature received from the server.
      */
     update: function(feature, options) {
-        options = OpenLayers.Util.applyDefaults(options, this.options);
+        options = options || {};
         var url = options.url ||
                   feature.url ||
                   this.options.url + "/" + feature.fid;
+        options = OpenLayers.Util.applyDefaults(options, this.options);
 
         var resp = new OpenLayers.Protocol.Response({
             reqFeatures: feature,
@@ -408,10 +409,11 @@ OpenLayers.Protocol.HTTP = OpenLayers.Class(OpenLayers.Protocol, {
      *     completes.
      */
     "delete": function(feature, options) {
-        options = OpenLayers.Util.applyDefaults(options, this.options);
+        options = options || {};
         var url = options.url ||
                   feature.url ||
                   this.options.url + "/" + feature.fid;
+        options = OpenLayers.Util.applyDefaults(options, this.options);
 
         var resp = new OpenLayers.Protocol.Response({
             reqFeatures: feature,

lib/OpenLayers/Renderer/SVG.js

@@ -340,7 +340,7 @@ OpenLayers.Renderer.SVG = OpenLayers.Class(OpenLayers.Renderer.Elements, {
             }
 
             var rotation = style.rotation;
-            if (node._rotation !== rotation && pos) {
+            if ((rotation !== undefined || node._rotation !== undefined) && pos) {
                 node._rotation = rotation;
                 rotation |= 0;
                 if(node.nodeName !== "svg") {

lib/OpenLayers/Strategy/Fixed.js

@@ -19,7 +19,7 @@ OpenLayers.Strategy.Fixed = OpenLayers.Class(OpenLayers.Strategy, {
      * APIProperty: preload
      * {Boolean} Load data before layer made visible. Enabling this may result
      *   in considerable overhead if your application loads many data layers
-     *   that are not visible by default. Default is true.
+     *   that are not visible by default. Default is false.
      */
     preload: false,
 

tests/Protocol/HTTP.html

@@ -696,6 +696,34 @@
         OpenLayers.Request.PUT = _put;
     }
 
+    function test_update_featureurl(t) {
+
+        // test that OpenLayers.Request.PUT receives the URL
+        // set in the feature
+        // http://trac.openlayers.org/ticket/2393#comment:11
+
+        t.plan(1);
+
+        var protocol = new OpenLayers.Protocol.HTTP({
+            'url': 'foo_url',
+            'format': {'write': function() {}}
+        });
+
+        // feature to pass to update
+        var feature = {'feature':'feature', 'url': 'bar_url'};
+
+        var _put = OpenLayers.Request.PUT;
+
+        OpenLayers.Request.PUT = function(options) {
+            t.eq(options.url, feature.url,
+                'PUT called with correct url in options');
+        };
+
+        protocol.update(feature);
+
+        OpenLayers.Request.PUT = _put;
+    }
+
     function test_handleResponse(t) {
         t.plan(6);
 
@@ -817,6 +845,34 @@
         OpenLayers.Request.DELETE = _delete;
     }
 
+    function test_delete_featureurl(t) {
+
+        // test that OpenLayers.Request.DELETE receives the URL
+        // set in the feature
+        // http://trac.openlayers.org/ticket/2393#comment:11
+
+        t.plan(1);
+
+        var protocol = new OpenLayers.Protocol.HTTP({
+            'url': 'foo_url',
+            'format': {'write': function() {}}
+        });
+
+        // feature to pass to update
+        var feature = {'feature':'feature', 'url': 'bar_url'};
+
+        var _delete = OpenLayers.Request.DELETE;
+
+        OpenLayers.Request.DELETE = function(options) {
+            t.eq(options.url, feature.url,
+                'DELETE called with correct url in options');
+        };
+
+        protocol['delete'](feature);
+
+        OpenLayers.Request.DELETE = _delete;
+    }
+
     function test_handleDelete(t) {
         t.plan(4);