RC3 had a major bug with event handling in the MouseToolbar, introduced due

to firebug/safari-specific debug statements left in the RC. This will fix the
"Every time I drag a rectangle, it just keeps dragging" issue that users
were reporting.


git-svn-id: http://svn.openlayers.org/tags/openlayers/release-2.0-rc4@1349 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf

lib/OpenLayers/Control/MouseToolbar.js

@@ -48,7 +48,6 @@ OpenLayers.Control.MouseToolbar.prototype =
         this._addButton("pan", "panning-hand-off.png", "panning-hand-on.png", centered, sz, "Drag the map to pan.");
         centered = centered.add((this.direction == "vertical" ? 0 : sz.w), (this.direction == "vertical" ? sz.h : 0));
         this.switchModeTo("pan");
-        this.map.events.register("zoomend", this, function() { this.switchModeTo("pan"); });
         return this.div;
         
     },
@@ -105,8 +104,10 @@ OpenLayers.Control.MouseToolbar.prototype =
         if (!Event.isLeftClick(evt)) return;
         this.mouseDragStart = evt.xy.clone();
         this.performedDrag = false;
+        this.startViaKeyboard = false;
         if (evt.shiftKey && this.mode !="zoombox") {
             this.switchModeTo("zoombox");
+            this.startViaKeyboard = true;
         } else if (evt.altKey && this.mode !="measure") {
             this.switchModeTo("measure");
         } else if (!this.mode) {
@@ -239,10 +240,6 @@ OpenLayers.Control.MouseToolbar.prototype =
         if (!Event.isLeftClick(evt)) return;
         switch (this.mode) {
             case "zoombox":
-                console.log(this.mouseDragStart, evt.xy);
-                console.log(Math.abs(this.mouseDragStart.x - evt.xy.x) > 5 ||                        Math.abs((this.mouseDragStart.y - evt.xy.y)) > 5);
-                console.log(Math.abs(this.mouseDragStart.x-evt.xy.x) > 5); 
-                console.log(Math.abs(this.mouseDragStart.y-evt.xy.y)>5); 
                 if (Math.abs(this.mouseDragStart.x - evt.xy.x) > 5 ||    
                     Math.abs(this.mouseDragStart.y - evt.xy.y) > 5) {  
                     var start = this.map.getLonLatFromViewPortPx( this.mouseDragStart ); 
@@ -260,7 +257,8 @@ OpenLayers.Control.MouseToolbar.prototype =
                 }    
                 this.map.viewPortDiv.removeChild(document.getElementById("zoomBox"));
                 this.zoomBox = null;
-                this.leaveMode();
+                console.log(this.startViaKeyboard);
+                if (this.startViaKeyboard) this.leaveMode();
                 break;
             case "pan":
                 if (this.performedDrag) {

lib/OpenLayers/Layer.js

@@ -182,6 +182,9 @@ OpenLayers.Layer.prototype = {
           'minExtent', 'maxExtent',
           'numZoomLevels'
         );
+        if (this.map.maxZoomLevel && !this.numZoomLevels) {
+            this.numZoomLevels = this.map.maxZoomLevel + 1;
+        }
         for(var i=0; i < properties.length; i++) {
             if (this[properties[i]] == null) {
                 this[properties[i]] = this.map[properties[i]];