Commit Graph
9 Commits
Author SHA1 Message Date
Edward Nash 2b863793d0 Perform auto-pan when adding an Overlay to a Map
* Auto-pan settings currently only activate when the position of the
   Overlay is set and the Overlay is already on a Map.

 * The consequence of this is that creating an Overlay with position
   set and then adding to a Map results in no auto-pan being performed -
   it is necessary to first create the Overlay, then add to a Map and
   finally set the position in order for the Map to auto-pan.

 * This commit changes this behaviour so that the auto-pan settings are
   also considered when the map property of the Overlay is set and not
   only when the position property is set, leading to a more intuitive
   behaviour.

 * Fixes Issue #10843
2020-04-01 06:50:01 +02:00
Edward Nash 2537da690a Add check that Position is set in panIntoView()
* If panIntoView is an API method, it may now be called when the
   position of the overlay has not yet been set.

 * Adds a check for a set position to the panIntoView() method,
   and removes the now unneccessary check in handlePositionChanged()
2020-03-30 07:15:03 +02:00
Edward Nash b1b01cf943 Allow pan options supplied as autoPan
* Follow the suggestion from @ahocevar to use the existing
   autoPan constructor option instead of creating a new autoPanOptions
   option

 * Internally also store the autoPanOptions in autoPan
2020-03-30 07:12:52 +02:00
Edward Nash 859bf338a2 Use Object for options to Overlay panIntoView
* animation and margin encapsulated in a single object to allow
   easier extension in future

 * Constructor options extended to allow single object for
   autoPan; separate options still allowed but deprecated

 * Protected fields for animation and margin replaced with single
   field
2020-03-13 10:12:14 +01:00
Edward Nash 022caae848 Document default margin in Overlay.panIntoView 2020-03-12 09:37:40 +01:00
Edward Nash 092a199757 Make Overlay.panIntoView an API method
* Add parameters for custom animation parameters and margin

 * Add protected wrapper method for previous autoPan functionality

See #10741
2020-03-12 08:57:32 +01:00
Edward Nash ed18310136 Improve test in case of async call 2019-10-22 10:21:52 +02:00
Edward Nash 9eb4816b27 Fix property name collision target_ with Control
* As described in #10158, Control uses the property target_ for
   a custom parent HTMLElement, leading to Events on the Control being
   dispatched with that as the target and not the Control itself.

 * Solved by renaming the target_ property on Target to eventTarget_
2019-10-22 09:37:05 +02:00
Edward Nash ee653a8e0d Add regression test for event target on Control
* Check possible name collision of target element with EventTarget
2019-10-22 09:37:05 +02:00