Commit Graph

3484 Commits

Author SHA1 Message Date
Tom Payne
59779bdcc5 Correct return types of ol.layer.Base methods 2013-12-13 18:59:26 +01:00
Tom Payne
d19ce18a31 Fix return type of ol.Map#getView 2013-12-13 18:59:26 +01:00
Tom Payne
9dc3dc6c11 Make ol.renderer.Layer a @struct 2013-12-13 18:59:26 +01:00
Tom Payne
a11c64934c Make ol.renderer.Map a @struct 2013-12-13 18:59:26 +01:00
Tom Payne
fbc23499e4 Add @struct annotation for simple classes 2013-12-13 18:59:26 +01:00
Tom Payne
2bcfa9ee00 Fix type errors in ol.renderer.webgl.Map 2013-12-13 18:59:25 +01:00
Tom Payne
fd733eca82 Use assertInstanceof instead of typecast 2013-12-13 18:59:25 +01:00
Tom Payne
b12bed8949 Use assertInstanceof instead of getImageSource 2013-12-13 18:59:25 +01:00
Tom Payne
c9b0d0bf0e Use assertInstanceof instead of getImageLayer 2013-12-13 18:59:25 +01:00
Tom Payne
e11d8bf717 Use assertInstanceof instead of getTileSource 2013-12-13 18:59:25 +01:00
Tom Payne
8d5e46622c Use assertInstanceof instead of getTileLayer 2013-12-13 18:59:25 +01:00
Tom Payne
3681b3c669 Always use goog.vec.Mat4.Number instead of goog.vec.Mat.AnyType 2013-12-13 18:59:25 +01:00
Tom Payne
5f0ea858ec Fix multiple type errors in getFeatureInfoForPixel 2013-12-13 18:59:24 +01:00
Tom Payne
a93e0b85df Improve type checking in ol.interaction.DragPan 2013-12-13 18:59:24 +01:00
Tom Payne
6dedac6ed8 Improve type checking in ol.interaction.TouchPan 2013-12-13 18:59:24 +01:00
Tom Payne
408a75426b Improve type checking in ol.control.Zoom 2013-12-13 18:59:24 +01:00
Tom Payne
35768f8b48 Improve type checking in ol.interaction.Interaction 2013-12-13 18:59:24 +01:00
Tom Payne
b39ae367e7 Improve type checking in ol.canvas.SUPPORTED 2013-12-13 18:59:24 +01:00
Tom Payne
8f6952c56c Fix use of ol.IView2D in ol.interaction.TouchPan 2013-12-13 18:59:24 +01:00
Tom Payne
49369b8800 Fix use of ol.IView2D in ol.interaction.DragRotate 2013-12-13 18:04:48 +01:00
Tom Payne
d43eb6dcb7 Fix use of ol.IView2D in ol.interaction.DragRotateAndZoom 2013-12-13 18:04:48 +01:00
Tom Payne
d81c8d6f92 Fix use of ol.IView2D in ol.interaction.DragPan 2013-12-13 18:04:48 +01:00
Tom Payne
2bf7dc5568 ol.interaction.Interaction methods should take ol.IView2Ds, not ol.View2Ds 2013-12-13 18:04:48 +01:00
Tom Payne
3bb2306f79 Work around compiler not detecting implementation of abstract methods 2013-12-13 18:04:47 +01:00
Tom Payne
0b1a2325cd Define isDef on ol.IView2D, ol.IView3D and ol.View 2013-12-13 18:04:47 +01:00
Tim Schaub
0ed59f7be3 Merge pull request #1348 from tschaub/beforechange
Add `ol.ObjectEvent` for changes to `ol.Object` properties.  Previously, `ol.Object` dispatched instances of `goog.events.Event` with type `change`.  Now `ol.ObjectEvent` instances will be dispatched on property changes.  The events include a `getKey` method to get the name of the property being changed.  The `beforepropertychange` type event is fired before a property value changes, and the `propertychange` type event fires after the property value changes.
2013-12-13 07:28:36 -08:00
Éric Lemoine
93e605b119 Merge pull request #1350 from elemoine/gutter
Add gutter support to ol.source.TileWMS
2013-12-13 01:11:42 -08:00
Éric Lemoine
ca07b4ef47 Merge pull request #1371 from elemoine/getbrowserevent
Add ol.MapBrowserEvent#getBrowserEvent
2013-12-12 23:41:01 -08:00
Éric Lemoine
b8a0112a91 Merge pull request #930 from elemoine/externs
Use @exportSymbol instead of @exportClass|Function
2013-12-12 23:40:44 -08:00
Tim Schaub
20d74810ab Export a getKey method on ol.ObjectEvent 2013-12-12 16:59:34 -07:00
ahocevar
95c717ad32 Merge pull request #1370 from ahocevar/unnest-loops
Unnest loops
2013-12-12 15:12:19 -08:00
ahocevar
c4ec53bbdb Unnest loops
Reusing the iterator in a nested loop is not a good idea. And in
this case it is better to not have nested loops at all, because
we only have to create one array.
2013-12-12 17:57:14 +01:00
Éric Lemoine
b709820777 Use olx for some parser options types 2013-12-12 15:22:47 +01:00
Éric Lemoine
f15694844d Line is too long 2013-12-12 15:22:18 +01:00
Éric Lemoine
f95e0eb785 Treat WMSGetFeatureInfoOptions as other options types 2013-12-12 15:21:49 +01:00
Éric Lemoine
7732c19874 Some options types are defined in the code
The sed script caught those, so manually adjusting here.
2013-12-12 15:19:37 +01:00
Éric Lemoine
7b81bfab5c Change @exportClass to @exportSymbol
sed command used: find src/ol -name '*.exports' -exec sed -ri 's/@exportClass\s+(\S+)\s+(\S+)$/@exportSymbol \1/' \{\} \;
2013-12-12 15:05:52 +01:00
Éric Lemoine
d9e293109e Change @exportFunction to @exportSymbol
sed command used: find src/ol -name '*.exports' -exec sed -ri 's/@exportFunction\s+(\S+)\s+(\S+)\s+(\S+)$/@exportSymbol \1 \1/' \{\} \;
2013-12-12 15:05:39 +01:00
Éric Lemoine
315c42f0a7 Use olx namespace for options types in source code
sed command used: find src/ol -name '*.js' -exec sed -ri 's/\{ol(\.(\w|\.)+Options\=?\})/{olx\1/' \{\} \;
2013-12-12 15:02:03 +01:00
Éric Lemoine
ef703c7147 Use olx namespace in src/objectliterals.jsdoc
sed comment used: sed -ri 's/ol(\.\S*Options)/olx\1/' src/objectliterals.jsdoc
2013-12-12 15:02:02 +01:00
Tom Payne
7b7ebb8609 Add missing "new"s in ol.structs.RBush 2013-12-12 13:01:25 +01:00
Éric Lemoine
701b2d63ef Add gutter support to ol.renderer.webgl.TileLayer 2013-12-12 10:59:32 +01:00
Éric Lemoine
5c71ec4922 Add gutter support to ol.renderer.dom.TileLayer 2013-12-12 10:59:32 +01:00
Éric Lemoine
2db8ce566b Add gutter support to ol.renderer.canvas.TileLayer 2013-12-12 10:59:32 +01:00
Éric Lemoine
55f56aaf03 Add ol.source.Tile#getGutter 2013-12-12 10:59:31 +01:00
Éric Lemoine
e14d8add85 Add gutter support to TileUrlFunction 2013-12-12 10:59:31 +01:00
Éric Lemoine
fd438f232b Add gutter option to ol.source.TileWMS 2013-12-12 10:59:31 +01:00
Tim Schaub
69385f4ff0 More consistent event types 2013-12-11 16:54:01 -07:00
Tim Schaub
625007f364 Make enum property name like its value
Where an enum value is used as an event type, it should be alllowercase (to follow DOM events).  Property names should be ALLUPPERCASE in this case (just as camelCase and PascalCase are converted to CONSTANT_CASE).
2013-12-11 16:54:01 -07:00
Tim Schaub
c8985b9906 Using unique event type values for distinct events
Any event target can be used to dispatch generic goog.events.Event instances with an arbitrary type.  In cases where we dispatch custom events, we should not use type values that collide with those used for generic events (at least internally).  This allows listeners a better chance of knowing what kind of argument they will receive.

As subsequent change will clean up the enumeration and add a bit more consistency.
2013-12-11 16:53:52 -07:00