Commit Graph

62 Commits

Author SHA1 Message Date
Tim Schaub
dfcf68007e Adding a 'sketchstarted' event on the vector layer. This event is triggered at the start of each new sketch. r=ahocevar (closes #1945)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@9269 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-04-12 15:36:15 +00:00
Éric Lemoine
bcf29b8a65 SelectFeature should allow panning the map when over features, without activating click method at the end of drag, r=tschaub (closes #1824)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@9194 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-04-06 11:46:15 +00:00
Tim Schaub
f4bae0a011 Adding support for a modify callback in the sketch handlers. This lets controls know about each sketch modification as a sketch is being drawn. Also a bit of a refactor of the sketch handlers to share sketch geometry parts. r=ahocevar (closes #1903)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8831 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-02-04 22:45:16 +00:00
Éric Lemoine
68ad14a047 Handler.RegularPolygon doesn't always call the "done" callback, r=tschaub (closes #1857)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8616 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-01-09 09:12:37 +00:00
Tim Schaub
850d69a02f Take care not to handle features without a layer. These are typically destroyed features - but could be some other sort of miscreants. Thanks for the report igrcic. r=crschmidt (closes #1806).
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8581 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-01-05 04:46:34 +00:00
Tim Schaub
b916be5489 The feature handler should not handle destroyed features. Or any features without a layer for that matter. r=elemoine (closes #1806)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8284 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-11-05 21:23:55 +00:00
Tim Schaub
9573f18756 Slightly more realistic mock features. Still no functional change.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8256 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-11-04 05:28:47 +00:00
Tim Schaub
b9874cdff9 Fewer chars to read. No functional change.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8255 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-11-04 05:23:43 +00:00
euzuro
84b65e5f8f fix propogate/propagate typo in click handler. thanks to chris r. for finding this, elemoine for the review. (Closes #1359)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8207 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-10-27 19:00:08 +00:00
ahocevar
2a521ffcb2 Made the Feature handler more robust to things that are related to changing layer order on the map, by registering an event handler that will bring the handler's layer back to the top of the layer stack in the DOM. Contains a manual test. r=elemoine (closes #1628)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7879 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-27 14:02:21 +00:00
euzuro
17160f49e0 Add support in OL for right-click capturing, including dbl-right-clicks (for zooming out in navigation control). Thanks to David Martin for this nice patch and the great 8 foot austrian for his review (Closes #1359)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7872 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-26 23:27:04 +00:00
crschmidt
693e6d07e3 Fix for Feature handler uses getFeatureFromEvent on mousemove even without
hover callbacks; r=ahocevar (Closes #1655) 

This means that On the SelectFeature control hover can no longer be set on the
SelectFeature control after the control has been initialized: must be passed at
initialize time. Example has been updated. 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7682 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-03 02:06:31 +00:00
crschmidt
d3151ccb40 Updated Control.KeyboardDefaults tests, but not the Handler.Keyboard tests.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7648 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-31 20:49:59 +00:00
pgiraud
7c23659f24 handlers test are not reflecting the reality, we now simulate a click, move then click \n
that way geometry bounds are cleared, and the tests don't fail in IE6 anymore (See #1602), r=ahocevar,crschmidt (Closes #1623)

git-svn-id: http://svn.openlayers.org/trunk/openlayers@7552 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-21 13:57:07 +00:00
crschmidt
0244858054 bring back r6710 now that popup changes are in
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6719 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-31 05:03:49 +00:00
crschmidt
69ca5c7fdd Revert r6710: The new popup coe is going to need to change tests, so this
needs to wait.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@6711 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-31 02:12:03 +00:00
crschmidt
02bbd43687 Since we've now completed all the work that is including new tests in 2.6, move
tests around. (See #1387) 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@6710 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-31 01:57:38 +00:00
euzuro
bf97a6c0d2 be very very careful about how we deal with the wheel. only take action when over scrollable items or over the main map. all of this is explained in the ticket and patch it is really late and i dont feel like typing it again. basically, this puppy means that scrolling on controls or in popups will no longer zoom the map unwantedly. that is good. thank you cr5 and IRC for taking such care of me. (r=cr5) (Closes #1382)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6416 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-29 08:37:12 +00:00
Tim Schaub
323de7085b The click and hover handlers need to take care that the event they are handling doesn't get modified before the delayed listeners get called. Appears to only be a problem in IE. Thanks for the catch madair. r=crschmidt (closes #1393)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6414 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-29 07:30:34 +00:00
crschmidt
6f2a3598be Fix lots of EOL SSTyle line ending problems.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6131 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-08 19:51:55 +00:00
Tim Schaub
99f3fa0d26 By default, the click handler now has a zero pixelTolerance. This means we don't call click if the click includes a drag. Set pixelTolerance to null if you want click called with a drag. r=crschmidt (closes #1335)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6066 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-08 03:24:42 +00:00
Frédéric Junod
911a2772a4 Opera version < 9.20 invert the wheelDelta value but version >= 9.20 don't. r=crschmidt (Closes #1193)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6004 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-06 15:34:16 +00:00
Éric Lemoine
cf87ffc26c Add properties stopClick, stopDown, and stopUp to the feature handler. If
stopClick is true, clicks handled by the feature handler don't propagate to
other click listeners; otherwise handled clicks do propagate. The same kind of
rule applies to stopDown and stopUp. These properties default to true. Thanks
to Attila Csipa for expressing the need for this feature and cooking up the
first patch. r=tschaub. (closes #1266)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@5976 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-03 17:35:39 +00:00
crschmidt
5f3e05bb5e Set the fallThrough property to 'true' by default. This seems to have no
adverse affect on the examples, is documented in the 2.6 release notes, 
and will allow for easier display of built-in browser tooltips for 
controls. r=elemoine (Closes #1303)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@5907 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-01-27 14:10:00 +00:00
Éric Lemoine
f053a4e0c8 Add hover handler. With this handler user-defined actions can be triggered as the mouse moves over the map and pauses. An example of use is send WMS/GetFeatureInfo requests. r=crschmidt,tschaub (closes #1255)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5746 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-01-15 12:54:47 +00:00
Tim Schaub
dc77bd5d5f Removing methods copied from the drag handler.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5685 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-01-08 17:34:34 +00:00
Tim Schaub
5babc73615 stop clicks on the point handler - this means no more clicks sneaking through while editing - if you wanted that behavior, speak up - r=crschmidt (closes #1020)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5523 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-12-20 03:02:54 +00:00
Éric Lemoine
6fb48c0cd7 Enables unselecting selected features by clicking outside any feature. This is the default mode of the modify feature control. If you want to use the old mode where a click on a selected feature unselects that feature, set the toggle option to true. If you really want the old mode and not have selected features be unselected when clicking outside any feature, set the clickout option to false. The patch also adds the properties toggleKey and multipleKey to the modify feature control. With these one can temporarily enable the toggle and multiple mode, respectively. See the select-feature.html example to see all this in action. Thanks to pvalsecc and tschaub for the great colloration on this. (closes #1137)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5506 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-12-19 11:09:44 +00:00
crschmidt
8a6f50496f fix more tests in Opera by adding map.destroy() calls.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5461 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-12-17 06:20:10 +00:00
crschmidt
0fd898859f fix more tests in opera
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5460 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-12-17 06:14:00 +00:00
Tim Schaub
6ad22b8e6a adding a click handler for flexible cross-browser single and double click handling - add to a control and set click or dblclick callbacks - thanks for the review and pairing crschmidt (closes #1211)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5438 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-12-16 04:42:14 +00:00
Tim Schaub
ceecacfe3a adding irregular option to regular polygon control - now, go draw rectangles, and more - thanks for the review elem (closes #1098).
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5200 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-11-15 23:37:36 +00:00
Tim Schaub
ba8354b593 Make the drag handler only call done if it actually dragged - thanks for the review Eric (closes #1118).
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5097 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-11-01 20:53:06 +00:00
Éric Lemoine
756f6ca24d handlers have to check if layer exists before destroying it. Thanks pgiraud. (closes #1107)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5085 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-11-01 13:37:16 +00:00
Tim Schaub
ad4044cd3b Make the drag handler tidy up after itself a bit more. This solves the click blocking after shift-drag issue (see #1003).
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4400 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-19 21:01:04 +00:00
Tim Schaub
91fab27e7d Simplify click handling in the drag handler - this makes the sequence down, move, up a complete drag (see #982).
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4354 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-17 19:25:26 +00:00
crschmidt
024779d898 With review from elem and additional tests, add filter by geometry type
to select feature control, with tests. (Closes #951)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4243 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-12 15:05:18 +00:00
Éric Lemoine
6f16455b1c select features on "click" as opposed to on "mousedown" (closes #891)
thanks to all for the review and to crschmidt for updating the patch


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4241 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-12 14:25:34 +00:00
crschmidt
82c64254e5 Fix lacking code from #666-- I had originally wanted to add this, but couldn't
craft a test which exposed the lack ... until i realized with pgiraud's help
that my test was backwards to begin with. (Closes #666)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4217 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-11 14:26:08 +00:00
Tim Schaub
35dae2bdb0 Adding a RegularPolygon handler for drawing squares, triangles, circles, etc. Demo in the regular-polygon.html example. Also adding a createRegularPolygon class method to the Polygon geometry class. Thanks to crschmidt for all the tests and help getting this in (closes #828).
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4205 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-10 20:24:27 +00:00
Tim Schaub
6c7824cfb0 adding basic tests for the feature handler
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4148 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-30 23:56:04 +00:00
Tim Schaub
cecf760f29 make the drag handler and drag feature control tidy up after themselves - as a bonus, give the drag feature control an onStart method. Thanks for the review crschmidt (closes #950).
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4147 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-30 23:25:49 +00:00
Tim Schaub
e5641c76e0 Fix deactivate and destroy methods on the keyboard handler. Add 28 tests for previously untested handler. Thanks to Erik for the quick review and comments - appreciated as always (closes #943).
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4108 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-29 17:37:42 +00:00
crschmidt
46c5cd6812 Properly destroy OpenLayers.Handler.MouseWheel, patch from fredj. Added
tests for it as well. (Closes #935)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4100 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-29 04:21:17 +00:00
Tim Schaub
984cdf6672 Modify drag handler for easier subclassing. Thanks for the team effort on this one (closes #827).
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4096 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-29 03:11:41 +00:00
crschmidt
30982c20b3 check against the map instead, since Opera doesn't seem to have the same kind
of mouse positions.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4090 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-28 23:58:15 +00:00
crschmidt
5b3221b8e3 Fix mousehweel test in opera.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4083 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-28 22:12:44 +00:00
Tim Schaub
a84e511c1f Adding neglected polygon hanlder test. Should have gone in with r4076. (See #934)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4077 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-28 16:53:59 +00:00
Tim Schaub
2d636c1ae4 Properly destroy features in the point, path, and polygon handlers. Patch with tests from fredj - thank you for the catch and the great patch. (Closes #931)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4063 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-27 21:03:28 +00:00
Tim Schaub
661d643b4f Give handlers a non-API evt property - this to be used by other controls in the library only. Eventually, we may decide to restructure this. (Closes #902)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4062 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-27 19:55:04 +00:00