Commit Graph

28 Commits

Author SHA1 Message Date
crschmidt
c2c821e4c2 DragFeature test Broken in IE6. The tests all passed because this only caused
problems on destroy()/page unload, after all the tests had been run. Thanks 
for the review, tschaub. (Closes #923.)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4035 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-24 22:07:18 +00:00
crschmidt
6194452b8a Since John already went ahead and committed the main change, I'm just going
to finish this one up. All commits are in comments, so a review doesn't seem
strictly neccesary. This closes #918 and fixes all the copyrights that I could 
find in the code.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3984 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-23 11:29:06 +00:00
Tim Schaub
56490d73ce #905 - give the drag handler back its start property - controls use but do not modify these handler properties
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3906 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-15 20:48:17 +00:00
Tim Schaub
b4da05da35 #774 - drag control only calls move callback with a change in pixel position - DragPan control simplified
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3891 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-11 03:32:41 +00:00
euzuro
cf5a53959e ND Update: make array's say what they're made of, and a few other small bits, like mistyped and a couple missing <>s
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3829 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-31 20:02:03 +00:00
euzuro
fd4d2918f1 fix for #853 - remove JSDOC comments from CLASS_NAME variables
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3787 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-23 15:09:09 +00:00
Tim Schaub
cc1b0269c9 #823 New class style. Instead of OldStyle = Class.create(); OldStyle.prototype = Class.inherit(Parent, prototype), we now use NewStyle = OpenLayers.Class(Parent, prototype). New style classes allow for backwards compatibility [you can use OldStyle = Class.create(); Class.inherit(NewStyle, prototype)]. The Class.create and Class.inherit functions are deprecated. Backwards compatibility will be removed at 3.0. Thanks Erik for the careful review.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3767 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-16 20:25:11 +00:00
Tim Schaub
0a3de3fddc coding standards - getting rid of these tabs all at once
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3686 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-10 21:56:11 +00:00
Tim Schaub
728ba09060 more doc comments for the drag handler
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3659 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-09 20:02:52 +00:00
Tim Schaub
e276f84deb more whitespace changes in Handler/Drag.js
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3642 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-07 00:12:57 +00:00
Tim Schaub
0f47f1d73f #812 - give drag handler a done callback
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3641 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-07 00:09:22 +00:00
euzuro
af8cce4f7b cosmetic nd changes, coding standards
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3639 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-06 23:05:28 +00:00
euzuro
a74a9bd49f remove *private* statements from nd comments
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3620 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-06 17:38:20 +00:00
euzuro
3d73171521 move all nd comments for CLASS_NAME back to jsdoc style. my personal opinion is that we should get rid of this comment entirely... but that's something that can be debated. so long as they are all the same, it makes it easier to do a global replace when a decision is reached
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3587 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-05 17:33:29 +00:00
crschmidt
3948913bfc Merge all changes from the naturaldocs sandbox. This brings all the work that
has been done in the NaturalDocs branch back to trunk. Thanks to everyone who
helped out in making this happen. (I could list people, but the list would
be long, and I'm already mentally on vacation.)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3545 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-06-29 15:59:20 +00:00
Schuyler Erle
7a3eabceeb Prevent click event when dragging in Handler.Drag. Fixes #656.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3082 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-17 18:25:04 +00:00
Tim Schaub
645bff1286 #628 - a feature has a geometry - a geometry doesn't have a feature - features are rendered, selected, moved, modified, etc - down in the renderer, expando properties on nodes are limited to _featureId, _style, and _options - this removes expandos that created circular references back through the map and to other dom elements - when the renderer is involved in selecting features, it returns a featureId (instead of a geometry or feature) and the layer is responsible for fetching the appropriate feature
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3043 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-10 16:07:56 +00:00
crschmidt
8af1822d94 Minor change to change default post-drag styling from 'default' to ''. This allows
CSS-based styling of the cursor on the map, rather than forcing 'default' after every
action. Tested in Safari, Opera, Firefox, IE7. Patch from Andreas Hocevar, #635. Thanks!


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3042 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-10 10:35:16 +00:00
Tim Schaub
6ffc672436 #652 - IE was pretending it didn't know about document.onselectstart - though it relies on it
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3039 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-09 20:15:19 +00:00
Schuyler Erle
07abc57037 Check return values from activate()/deactivate() in subclassed Handlers and Controls, as appropriate. Fixes #599.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2955 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-01 21:33:59 +00:00
crschmidt
4aec64aa67 #571: Don't subclass Geometry.Point from LonLat, and all neccesary associated
changes. Reviewed by tschaub (thx)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2943 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-31 18:30:56 +00:00
Schuyler Erle
2961be423e Handler.MouseWheel gets destroy(). Fixes #600. Look out now.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2937 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 22:04:06 +00:00
Schuyler Erle
de9ae4a5bb Keyboard-related classes get destroy(). Fixes #598. Ba-ding.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2936 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 22:03:05 +00:00
Schuyler Erle
313704b844 Tim's big refactoring of the Geometry modules. Fixes #590. All tests pass in FF (except the PanZoomBar stuff, which wasn't touched by this patch) and IE.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2931 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-30 21:42:32 +00:00
Tim Schaub
f570758676 modify the drag handler so that it only modifies IE's document.onselectstart while dragging - add jsodc text - all browser event handlers now return a boolean - activate and deactivate respect the return of the parent class and return the same
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2908 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-28 15:59:49 +00:00
crschmidt
b6e783fb66 With Erik's approval on #341, I'm happy with this. This restores the
mousewheel functionality we had in earlier releases in a similar way, rewritten
for handlers. (The benefit of handlers in this case is that handlers are 
write-once, use many, so the next mousewheel thing we get will *also* be able 
to use this code.)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2877 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-24 23:11:18 +00:00
Tim Schaub
0c8dcabce8 replacing the select handler with a feature handler - with support for up, down, over, out, and move callbacks associated with mouse events on a feature - the select-feature.html example shows the use of a control that activates the feature handler - see #544
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2843 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-21 23:30:20 +00:00
crschmidt
3ca974acec Merge vector-2.4 branch back to trunk.
svn merge sandbox/vector-2.4/@2307 sandbox/vector-2.4/@HEAD trunk/openlayers/


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2803 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-16 13:23:56 +00:00