Commit Graph

133 Commits

Author SHA1 Message Date
Tim Schaub
b750f690d9 Mocking less and (more importantly) making sure all assertions are not made in conditionally run code.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@11567 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2011-02-27 17:03:57 +00:00
Tim Schaub
7fde5fd248 Refactoring the click handler tests so they are more legible and rely less on long sequences.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@11566 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2011-02-27 15:29:32 +00:00
ahocevar
33eef42075 making drawing handler work on touch devices. p=sbrunner, r=me (closes #3072)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@11563 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2011-02-27 15:00:38 +00:00
Tim Schaub
02d4257544 Using real pixels in tests so we get distanceTo method.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@11558 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2011-02-27 13:08:51 +00:00
Frédéric Junod
a076ce9228 Handler.Feature: fix mobile support. p=fredj,erilem r=erilem (closes #3106)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@11510 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2011-02-25 15:18:02 +00:00
Tim Schaub
960ef3de18 Don't store touch events. The same event is used between touchstart, touchmove, and touchend. Instead, we store event details on the handler and use those when needed. p=bbinet, r=me (closes #3120)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@11507 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2011-02-25 14:52:56 +00:00
Tim Schaub
680923319c Adding a pinch handler for multi-touch devices. Great patch from Bruno. p=bbinet, r=me (closes #3077)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@11389 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2011-02-24 10:05:49 +00:00
crschmidt
8da53d8fbd Better mocking of the function calls on handlers so that handlers which
expect an evt object don't get errors when activating. 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@11387 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2011-02-24 09:37:47 +00:00
Éric Lemoine
30aeab365a make it possible to pan the map while drawing geometries, r=tschaub (closes #3052)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@11381 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2011-02-24 09:00:49 +00:00
Tim Schaub
fa32a4a645 Arrange elements so we can get mouse events on controls while preventing the default (scroll) behavior on touch devices. r=elemoine (closes #3091)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@11365 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2011-02-23 17:59:37 +00:00
bartvde
98a6c1754d fix up issue with Sencha Touch example not handling double tap to zoom in, r=elemoine (closes #3079)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@11226 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2011-02-22 11:21:20 +00:00
Éric Lemoine
f67bcaa033 add a touch events related test for the drag handler, no functional change
git-svn-id: http://svn.openlayers.org/trunk/openlayers@11225 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2011-02-22 11:10:35 +00:00
Éric Lemoine
7a8f3917c9 make click handler work with touch events (closes #2996)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@11201 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2011-02-21 16:04:34 +00:00
Éric Lemoine
07160f5385 make drag handler work with touch events, p=lotsofpeople, r=tschaub (closes #2995)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@11189 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2011-02-21 15:07:55 +00:00
pgiraud
f84f696e31 Adds the possibility to use a built version of OpenLayers for the tests, users simply have to add '?mode=build' in the run-tests.html url
git-svn-id: http://svn.openlayers.org/trunk/openlayers@11162 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2011-02-21 10:10:25 +00:00
ahocevar
d6695cff67 fixing error when closing page in IE. Thanks bartvde for the testcase. r=bartvde (closes #3003)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@11145 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2011-02-18 15:22:12 +00:00
Éric Lemoine
43d9e2e1a4 the drag handler's mouseout func should check if the mouse left the map viewport div as opposed to the map div, r=ahocevar (closes #2941)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@10956 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2010-12-08 16:06:42 +00:00
Tim Schaub
1397f816b5 Adding interior ring digitizing for polygons. Thanks jachym for the initial work. r=ahocevar (closes #1894)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@10828 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2010-10-13 22:12:52 +00:00
ahocevar
7993fc177b Fixed onselect handling for the first down-move-up-out cycle. r=bartvde (closes #2735)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@10637 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2010-08-19 14:52:45 +00:00
Frédéric Junod
6223d7fd82 Add a cumulative mode in MouseWheel handler. r=ahocevar (closes #2450)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@10002 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2010-02-01 08:42:17 +00:00
ahocevar
ebc5d7c021 added option to the MouseWheel handler to trigger up/down events only
when wheel is released. r=elemoine (closes #2345)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@9799 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-11-16 10:38:26 +00:00
Tim Schaub
dfcf68007e Adding a 'sketchstarted' event on the vector layer. This event is triggered at the start of each new sketch. r=ahocevar (closes #1945)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@9269 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-04-12 15:36:15 +00:00
Éric Lemoine
bcf29b8a65 SelectFeature should allow panning the map when over features, without activating click method at the end of drag, r=tschaub (closes #1824)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@9194 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-04-06 11:46:15 +00:00
Tim Schaub
f4bae0a011 Adding support for a modify callback in the sketch handlers. This lets controls know about each sketch modification as a sketch is being drawn. Also a bit of a refactor of the sketch handlers to share sketch geometry parts. r=ahocevar (closes #1903)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8831 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-02-04 22:45:16 +00:00
Éric Lemoine
68ad14a047 Handler.RegularPolygon doesn't always call the "done" callback, r=tschaub (closes #1857)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8616 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-01-09 09:12:37 +00:00
Tim Schaub
850d69a02f Take care not to handle features without a layer. These are typically destroyed features - but could be some other sort of miscreants. Thanks for the report igrcic. r=crschmidt (closes #1806).
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8581 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2009-01-05 04:46:34 +00:00
Tim Schaub
b916be5489 The feature handler should not handle destroyed features. Or any features without a layer for that matter. r=elemoine (closes #1806)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8284 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-11-05 21:23:55 +00:00
Tim Schaub
9573f18756 Slightly more realistic mock features. Still no functional change.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8256 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-11-04 05:28:47 +00:00
Tim Schaub
b9874cdff9 Fewer chars to read. No functional change.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8255 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-11-04 05:23:43 +00:00
euzuro
84b65e5f8f fix propogate/propagate typo in click handler. thanks to chris r. for finding this, elemoine for the review. (Closes #1359)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8207 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-10-27 19:00:08 +00:00
ahocevar
2a521ffcb2 Made the Feature handler more robust to things that are related to changing layer order on the map, by registering an event handler that will bring the handler's layer back to the top of the layer stack in the DOM. Contains a manual test. r=elemoine (closes #1628)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7879 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-27 14:02:21 +00:00
euzuro
17160f49e0 Add support in OL for right-click capturing, including dbl-right-clicks (for zooming out in navigation control). Thanks to David Martin for this nice patch and the great 8 foot austrian for his review (Closes #1359)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7872 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-26 23:27:04 +00:00
crschmidt
693e6d07e3 Fix for Feature handler uses getFeatureFromEvent on mousemove even without
hover callbacks; r=ahocevar (Closes #1655) 

This means that On the SelectFeature control hover can no longer be set on the
SelectFeature control after the control has been initialized: must be passed at
initialize time. Example has been updated. 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@7682 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-08-03 02:06:31 +00:00
crschmidt
d3151ccb40 Updated Control.KeyboardDefaults tests, but not the Handler.Keyboard tests.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7648 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-31 20:49:59 +00:00
pgiraud
7c23659f24 handlers test are not reflecting the reality, we now simulate a click, move then click \n
that way geometry bounds are cleared, and the tests don't fail in IE6 anymore (See #1602), r=ahocevar,crschmidt (Closes #1623)

git-svn-id: http://svn.openlayers.org/trunk/openlayers@7552 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-07-21 13:57:07 +00:00
crschmidt
0244858054 bring back r6710 now that popup changes are in
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6719 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-31 05:03:49 +00:00
crschmidt
69ca5c7fdd Revert r6710: The new popup coe is going to need to change tests, so this
needs to wait.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@6711 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-31 02:12:03 +00:00
crschmidt
02bbd43687 Since we've now completed all the work that is including new tests in 2.6, move
tests around. (See #1387) 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@6710 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-03-31 01:57:38 +00:00
euzuro
bf97a6c0d2 be very very careful about how we deal with the wheel. only take action when over scrollable items or over the main map. all of this is explained in the ticket and patch it is really late and i dont feel like typing it again. basically, this puppy means that scrolling on controls or in popups will no longer zoom the map unwantedly. that is good. thank you cr5 and IRC for taking such care of me. (r=cr5) (Closes #1382)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6416 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-29 08:37:12 +00:00
Tim Schaub
323de7085b The click and hover handlers need to take care that the event they are handling doesn't get modified before the delayed listeners get called. Appears to only be a problem in IE. Thanks for the catch madair. r=crschmidt (closes #1393)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6414 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-29 07:30:34 +00:00
crschmidt
6f2a3598be Fix lots of EOL SSTyle line ending problems.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6131 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-08 19:51:55 +00:00
Tim Schaub
99f3fa0d26 By default, the click handler now has a zero pixelTolerance. This means we don't call click if the click includes a drag. Set pixelTolerance to null if you want click called with a drag. r=crschmidt (closes #1335)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6066 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-08 03:24:42 +00:00
Frédéric Junod
911a2772a4 Opera version < 9.20 invert the wheelDelta value but version >= 9.20 don't. r=crschmidt (Closes #1193)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@6004 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-06 15:34:16 +00:00
Éric Lemoine
cf87ffc26c Add properties stopClick, stopDown, and stopUp to the feature handler. If
stopClick is true, clicks handled by the feature handler don't propagate to
other click listeners; otherwise handled clicks do propagate. The same kind of
rule applies to stopDown and stopUp. These properties default to true. Thanks
to Attila Csipa for expressing the need for this feature and cooking up the
first patch. r=tschaub. (closes #1266)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@5976 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-03 17:35:39 +00:00
crschmidt
5f3e05bb5e Set the fallThrough property to 'true' by default. This seems to have no
adverse affect on the examples, is documented in the 2.6 release notes, 
and will allow for easier display of built-in browser tooltips for 
controls. r=elemoine (Closes #1303)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@5907 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-01-27 14:10:00 +00:00
Éric Lemoine
f053a4e0c8 Add hover handler. With this handler user-defined actions can be triggered as the mouse moves over the map and pauses. An example of use is send WMS/GetFeatureInfo requests. r=crschmidt,tschaub (closes #1255)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5746 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-01-15 12:54:47 +00:00
Tim Schaub
dc77bd5d5f Removing methods copied from the drag handler.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5685 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-01-08 17:34:34 +00:00
Tim Schaub
5babc73615 stop clicks on the point handler - this means no more clicks sneaking through while editing - if you wanted that behavior, speak up - r=crschmidt (closes #1020)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5523 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-12-20 03:02:54 +00:00
Éric Lemoine
6fb48c0cd7 Enables unselecting selected features by clicking outside any feature. This is the default mode of the modify feature control. If you want to use the old mode where a click on a selected feature unselects that feature, set the toggle option to true. If you really want the old mode and not have selected features be unselected when clicking outside any feature, set the clickout option to false. The patch also adds the properties toggleKey and multipleKey to the modify feature control. With these one can temporarily enable the toggle and multiple mode, respectively. See the select-feature.html example to see all this in action. Thanks to pvalsecc and tschaub for the great colloration on this. (closes #1137)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5506 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-12-19 11:09:44 +00:00
crschmidt
8a6f50496f fix more tests in Opera by adding map.destroy() calls.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5461 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-12-17 06:20:10 +00:00