Commit Graph

10641 Commits

Author SHA1 Message Date
Tim Schaub
7d2d68c011 Give interactions a reference to the map
This is in line with what we do for controls and overlays.  A follow-up change will add calls to `setMap` when interactions are added to a map.
2013-10-31 09:25:52 -06:00
Éric Lemoine
d211f65203 Merge pull request #1195 from elemoine/click
Emulated click events on mouse devices
2013-10-31 01:50:34 -07:00
Éric Lemoine
8402eee0c3 Map "click" event renamed to "singleclick"
As discussed with @tschaub in #1195.
2013-10-31 09:37:16 +01:00
Tim Schaub
8e892a633d Merge pull request #1188 from tschaub/gfi-extent
Correctly generate BBOX in URL for GetFeatureInfo in ol.source.ImageWMS.
2013-10-30 09:10:48 -07:00
Éric Lemoine
2c930d74b5 clickOnly condition checks map clicks 2013-10-30 13:17:12 +01:00
Éric Lemoine
6ab88aad72 Add tests for emulated clicks 2013-10-30 13:16:09 +01:00
Éric Lemoine
0fa66cc7e7 Remove mousedown listener on first touchstart 2013-10-30 13:16:09 +01:00
Éric Lemoine
9f7ead5ef4 Remove unused ol.MapBrowserEventHandler#relayEvent_ func 2013-10-30 13:16:09 +01:00
Éric Lemoine
a85b82090d Emulate click events only on mouse "action"
`click` events are fired only if the mouse action button is pressed. This prevents `click` events from being fired when the middle mouse button is used.

Also, without this commit, in Chrome with emulated touch events enabled, double-clicking the map doesn't zoom the map. This is because `ol.BrowserFeature.HAS_TOUCH` is `false` in that environment. The commit fixes it by testing `isMouseActionButton` on mouse devices only.
2013-10-30 13:16:09 +01:00
Éric Lemoine
0c212fdcb5 Emulated click events on mouse devices
The map already emits emulated `click` and `dblclick` events on touch and pointer devices. With this commit the map emits emulated `click` and `dblclick` events on mouse devices as well.
2013-10-30 13:16:09 +01:00
Frédéric Junod
68752729ab Merge pull request #1140 from fredj/rename_interaction_condition
Rename ol.interaction.condition
2013-10-30 04:22:31 -07:00
Frederic Junod
a9159ecac3 Rename ol.interaction.condition to ol.events.condition 2013-10-30 12:13:44 +01:00
ahocevar
5b9bcbac1c Merge pull request #1197 from ahocevar/handledragend
Handle dragend after resetting view hint and dragging flag
2013-10-30 03:59:43 -07:00
ahocevar
4b7b95fc2f Handle dragend after resetting view hint and dragging flag
When we start dragging, we first handle dragstart and then set
the INTERACTING view hint and the dragging flag. To end dragging
in a symmetric manner, we have to first reset the INTERACTING
hint and dragging flag, and then handle dragend.

This flaw becomes obvious when using an interaction where no
animation is performed after the interaction. This can be seen
in the style-rules example when using the dragzoom interaction
(i.e. zoom using a drag box): the vector renderer will not
render the new resolution, because the INTERACTING view hint is
still set when the zoom box dragend is handled.
2013-10-30 11:45:34 +01:00
Bruno Binet
871820f2b5 Merge pull request #1122 from bbinet/fix-zindex-issues
Fix overlay zindex issues
2013-10-30 02:39:06 -07:00
Éric Lemoine
16b817b830 Overlay stopEvent and insertFirst default to true 2013-10-30 09:49:38 +01:00
Bruno Binet
d7c696fc76 Improve doc for stopEvent and insertFirst options 2013-10-30 09:28:56 +01:00
Bruno Binet
4e602fdb8d Set z-index: auto so that popup is not above controls 2013-10-30 09:28:26 +01:00
Bruno Binet
59eaa89a54 Fix overlay z-index issue in overlay example 2013-10-30 09:28:26 +01:00
Bruno Binet
86cfdf4da7 Fix overlay z-index issue in popup example 2013-10-30 09:28:26 +01:00
Bruno Binet
71097d9cfc Insert or append overlay based on insertFirst option
This is to fix z-index issues with overlays that pass above ol3 default
controls.
2013-10-30 09:28:25 +01:00
Bruno Binet
69cee6a410 Add insertFirst option in ol.OverlayOptions typedef 2013-10-30 09:28:25 +01:00
Tim Schaub
370bb964ab Tests for the image wms source 2013-10-29 14:18:14 -06:00
Tim Schaub
1af11e27ac Proper map extent for GetFeatureInfo request
Note that with and without this change, the pixel provided to the ol.source.wms.getFeatureInfo function will be wrong if the view has non-zero rotation.
2013-10-29 14:11:35 -06:00
Frédéric Junod
9ada23a08a Merge pull request #1182 from fredj/moveend_example
Wrong extent coordinate order in moveend example
2013-10-29 05:23:50 -07:00
Frédéric Junod
e3abfae02c Merge pull request #1189 from fredj/apidoc
Minor apidoc updates
2013-10-29 05:23:40 -07:00
Frederic Junod
9de78f1168 Fix bottom left and top right computation in moveend example 2013-10-29 11:03:10 +01:00
Frederic Junod
3efc810ca9 Quote values in apidoc 2013-10-29 11:01:49 +01:00
Frédéric Junod
7a0cefd872 Merge pull request #1185 from fredj/coord_format
Add ol.coordinate.format function
2013-10-28 23:46:16 -07:00
Tim Schaub
df78a41ff1 Merge pull request #1187 from pagameba/fix-todo-observables
Fix todo observables.
2013-10-28 13:28:53 -07:00
Paul Spencer
d18119d98b Remove unnecessary Get column from observables 2013-10-28 16:12:08 -04:00
Paul Spencer
e858727bd0 Fix @todo observable name reference. 2013-10-28 16:11:40 -04:00
Tim Schaub
18d2eb161e Merge pull request #1180 from pagameba/doc-jsdoc-plugins
Add jsdoc plugins for stability and observables.
2013-10-28 12:36:18 -07:00
Paul Spencer
d3b8d0b676 Add jsdoc plugin that maps @todo tags to @stability and @observable tags.
This is a temporary measure until Plovr handles custom tags or is replaced in the build system.

Add support for indicating API stability with inline documentation

In preparation for documenting the stability of API features, this commit adds support for indicating API stability via a new jsdoc tag @stability.  There is a small plugin for jsdoc that adds a new tag, @stabiility, with some ability to enforce specific level names.  The templates and css have been updated to include the stability level in the generated documentation. (+1 squashed commit)
Squashed commits:
[d6bc03d] Add jsdoc plugin for documenting observable properties of a class.
2013-10-28 15:17:59 -04:00
Frederic Junod
1217243f84 Better ol.coordinate.* documentation 2013-10-28 17:34:54 +01:00
Frederic Junod
9ca74200ed Remove opt_precision check in ol.coordinate.format
Default is already 0, see http://www.ecma-international.org/ecma-262/5.1/#sec-15.7.4.5
2013-10-28 16:26:21 +01:00
Frederic Junod
cdf34b558a Add ol.coordinate.format function
Return a formatted coordinate. Example usage:
  > ol.coordinate.format([0.01 ,12.14], "{x}, {y}", 2)
  "0.01, 12.14"
  > ol.coordinate.format([0.01 ,12.14], "lat: {y} / lon: {x}", 1)
  "lat: 12.1 / lon: 0.0"
2013-10-28 15:32:43 +01:00
Éric Lemoine
5928c1cea1 Merge pull request #1184 from oterral/get_image_element
Fix getImageElement calls in canvas and webgl renderer
2013-10-28 06:32:06 -07:00
Olivier Terral
cc3660f32a Fix getImageElement calls in canvas and webgl renderer 2013-10-28 14:04:40 +01:00
Tim Schaub
1529aad7f6 Merge pull request #1177 from probins/viewdocs
Small addition to view2d docs.
2013-10-27 11:39:44 -07:00
Peter Robins
e73fb871b6 Small addition to view2d docs 2013-10-27 05:53:46 -04:00
Éric Lemoine
d7636f266f Merge pull request #1147 from elemoine/issue-1147
IE 10 Click on popup
2013-10-27 02:09:25 -07:00
Tim Schaub
9d52e85fc3 Merge pull request #1163 from pagameba/doc-stability
Add default stability level to docs of exported things.
2013-10-25 11:40:16 -07:00
Tim Schaub
ca6681afa8 Merge pull request #1171 from probins/mapdocs
Fix error in map docs.
2013-10-25 10:51:23 -07:00
Peter Robins
d5df4bf80b Fix error in map docs
[ci skip]
2013-10-25 13:08:26 -04:00
Paul Spencer
bada596b45 Add default stability level to docs of exported things. 2013-10-24 18:20:24 -04:00
Tom Payne
a13c5d30a2 Merge pull request #1159 from twpayne/export-create-empty
Export ol.extent.createEmpty function
2013-10-24 04:21:55 -07:00
Frederic Junod
409d7d209d Export ol.extent.createEmpty function 2013-10-24 13:13:08 +02:00
Éric Lemoine
c17c21467e Merge pull request #1151 from probins/viewdocs
Some additions to View2d docs
2013-10-22 04:32:25 -07:00
Peter Robins
f5c6565617 Some additions to View2d docs
[ci skip]
2013-10-22 07:15:30 -04:00