crschmidt
75d2dac1cb
Minor typo in previous commit due to overzealous find/replace.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3072 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-13 13:16:44 +00:00
crschmidt
ba5b664a2f
Firefox SVG does not support drawing points with values more than something
...
between 10,000 and 40,000. (It's hard to tell, since it crashes the browser
when you try.) The resulting behavior is that the browser crashes. This
wraps these values into Pixel regions, and doesn't draw features which fall
outside of them. (This sucks, but the result is the browser not crashing.)
This closes #669 , and should be improved as described in #670 for 2.5.
If for some reason you know that the browser you're on can support larger
maxPixel values, you can adjust the maxPixel private variable on the
renderer. I believe that Opera and WebKit nightlies will work fine with
a larger maxPixel value. Changing this is encouraged *only* if you
are developer working on the code, because it can totally crash browsers
in a production environment.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3071 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-13 12:40:22 +00:00
Tim Schaub
0d2b12c7cd
#662 - prototypes shouldn't get properties that might be extended
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3070 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-12 15:12:44 +00:00
crschmidt
15465a455b
Move LayerSwitcher control down so that it doesn't overlay with the editing
...
controls. Patch from #641 by penyaskito . Thanks!
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3068 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-12 10:59:17 +00:00
crschmidt
1548a6c470
Patch to empty selectedFeatures when destroying all features from #665 ,
...
tschaub. This includes tests (hooray) and fixes issues with zooming a wfs
layer while you have a feature selected.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3067 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-12 10:51:39 +00:00
euzuro
4ec005c06c
fix for #660 -- feature.vector.attributes now correctly instantiated.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3066 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-11 21:08:45 +00:00
Tim Schaub
b02522ea4c
#655 : add layer.eraseFeatures.patch() on the "public" side of the API - layer methods should be called instead of layer.renderer methods wherever possible
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3065 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-11 15:48:41 +00:00
crschmidt
dbac2b1c83
Apply a patch from #657 to fix single file builds, broken by my style changes
...
a while back. Patch from Erik, reports from a couple people. Thanks!
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3045 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-10 22:12:18 +00:00
Tim Schaub
645bff1286
#628 - a feature has a geometry - a geometry doesn't have a feature - features are rendered, selected, moved, modified, etc - down in the renderer, expando properties on nodes are limited to _featureId, _style, and _options - this removes expandos that created circular references back through the map and to other dom elements - when the renderer is involved in selecting features, it returns a featureId (instead of a geometry or feature) and the layer is responsible for fetching the appropriate feature
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3043 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-10 16:07:56 +00:00
crschmidt
8af1822d94
Minor change to change default post-drag styling from 'default' to ''. This allows
...
CSS-based styling of the cursor on the map, rather than forcing 'default' after every
action. Tested in Safari, Opera, Firefox, IE7. Patch from Andreas Hocevar, #635 . Thanks!
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3042 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-10 10:35:16 +00:00
crschmidt
4968e0e59c
Commit Fix for #654 : Layer should not redraw on setVisibility(false). For
...
some layers, this is a significant performance enhancement. Includes regression
tests.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3041 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-10 10:30:49 +00:00
crschmidt
df65488d3a
Commit #637 , "add cursor property in Feature.Vector" from pgiraud, with
...
minor modification: because features by default do nothing at all, change
the default cursor property (keep it at null) so that users aren't confused
when clicking has no affect. Thanks for the patch.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3040 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-10 10:19:13 +00:00
Tim Schaub
6ffc672436
#652 - IE was pretending it didn't know about document.onselectstart - though it relies on it
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3039 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-09 20:15:19 +00:00
euzuro
ea3683db68
update jsdoc
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3037 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-09 19:40:31 +00:00
Tim Schaub
26925a89f1
#645 - layer.removeFeatures backs through the features array to ensure that all features are removed
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3036 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-09 15:29:31 +00:00
euzuro
1603d5a8ba
fix for #643 . layer class can be safely doubled up now
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3035 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-09 15:00:10 +00:00
crschmidt
057d574ec1
From Erik, "add strategic TBD 3.0 comments to remind us to remove the 'url'
...
var from OpenLayers.Tile's constructor." This has no affects other than to
let people know now that this behavior will change in future versions of
OpenLayers. #647 .
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3034 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-09 14:08:09 +00:00
crschmidt
377e805f26
Fix for #554 , click event and PanZoom control conflict, which was caused by
...
#484 in 2.3. This fixes the 2.2 -> current regression. Should be pulled
up to the 2.4 branch.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3033 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-09 13:22:32 +00:00
Tim Schaub
989f35e5cf
#649 - remove collection.getComponents - use collection.components instead
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3032 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-06 23:31:36 +00:00
euzuro
c0240b9ea5
small update to simplify code. when this class's initialize() function was changed, this was left as-is but now it can be reverted to just calling the constructor simply. #646
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3029 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-06 16:43:08 +00:00
euzuro
50237086a4
small documentation update #644
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3028 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-06 16:41:22 +00:00
crschmidt
87bad5b9f8
#633 : Fix memory leak in box marker used for boxes layer. Add comprehensive
...
tests for Box marker.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3026 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-06 03:30:31 +00:00
crschmidt
cf94dbeb01
Minor style change on Layer.Boxes, #634 .
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3025 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-06 03:28:06 +00:00
crschmidt
098ed43cf6
Add tests and improved functionality for keyboard defaults from #580 .
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3024 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-06 03:13:17 +00:00
euzuro
895ba639ae
patch for #636 - double-protect layer.destroy()
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3023 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-05 23:02:48 +00:00
Tim Schaub
cd6f2dd006
#632 : fixing the image layer that broke with r2979 - layer now sets its tileSize and imageSize appropriately - this also addesses (dup) ticket 511
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3020 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-05 22:35:54 +00:00
crschmidt
6af64fcb46
Curves aren't rendered. Everything else can be taken care of later.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2998 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-04 03:02:50 +00:00
Tim Schaub
8647addda2
#629 - remove events from geometry
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2997 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 22:57:26 +00:00
Schuyler Erle
45407e9eda
add Vector.destroyFeatures() and call it from WFS.moveTo(), which keeps WFS
...
from loading the same set of features multiple times. Includes tests. fixes
#622 .
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2996 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 21:02:59 +00:00
euzuro
23131012dd
fix for #624 - merge stop() and safeStopPropagation()
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2994 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 17:15:57 +00:00
euzuro
10b5c2df17
patch for #621 - assign items in the elements hash table a unique cacheID instead of relying on the element's actual 'id' property. thx for thorough review sde
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2993 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 16:54:14 +00:00
euzuro
d0115ccf26
patch for #625 - remove extraneous _observeAndCache() function which is only used once. it doesnt seem to conceptually abstract anything, so lets inline it
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2991 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 15:54:27 +00:00
euzuro
33cb7fd0d4
patch for #623 - remove unused pointerX() and pointerY() functions
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2990 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 15:38:16 +00:00
euzuro
9aa92d491c
events.js cleanup: more ifs without brackets
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2989 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 01:42:21 +00:00
euzuro
7aac1c1cfe
coding standards. if statement without brackets and multiple return
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2988 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 01:38:22 +00:00
euzuro
8440cbaf43
coding standards if statement should always be followed by braces. also, add comment
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2987 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 01:37:04 +00:00
euzuro
2734030a82
move unloadCache() down so that stopObserving and stopObservingElement() are next to eachother
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2986 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 01:31:45 +00:00
euzuro
2f8a093f83
move observe() function up to right before its private counterpart
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2985 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 01:27:39 +00:00
euzuro
ade794259f
move observers definition to top of object definition for readability
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2984 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 01:26:39 +00:00
euzuro
8007b6719a
events.js: style (never underestimate style)
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2983 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 23:12:55 +00:00
euzuro
ed0fca9157
events cleanup: fix tabs
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2982 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 23:00:55 +00:00
euzuro
dfa4441646
step one of cleaning up events.js: jsdoc
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2981 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 22:49:13 +00:00
Tim Schaub
b6a5e6619a
#529 give tiles gutters - all layers that use Tile.Image must now look after layer.imageSize and layer.imageOffset - this is handled by layer.setTileSize - for untiled layers, setTileSize must be defined by the subclass - gutters are currently supported in Layer.Mapserver and Layer.WMS
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2979 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 17:18:38 +00:00
Schuyler Erle
7f0ccb69f0
propset svn:eol-style native recursively throughout trunk. enjoy\!
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2978 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 16:46:34 +00:00
Tim Schaub
9e688ebb37
#616 : untiled layers set layer.tileSize on setMap and every moveTo
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2974 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 15:13:50 +00:00
crschmidt
d68caa00a5
Committing patch for #614 to add panel_div element to control panel
...
subcontrols. This will allow users to modify properties of the div -- for
example, adding a title element to the div. Access this property via
panel_div on the added control after addControls is called on the panel.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2973 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 14:10:38 +00:00
crschmidt
def14318a6
If a vector feature has a layer and it is destroyed, remove the feature from
...
the layer, and reset the layer to null.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2971 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 11:19:32 +00:00
crschmidt
201e4bb112
Fix broken references to 'Format/JSON' that were simple copy paste errors.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2970 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 11:02:09 +00:00
crschmidt
5319acfaf1
Minor documentation fixed from fredj ( #570 ).
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2969 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 10:54:01 +00:00
crschmidt
833abcf6f1
#605 "OpenLayers.Feature.Vector: destroy() is defined twice" by fredj, patch
...
by euzuro. thx euz, fredj.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@2968 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-02 10:52:10 +00:00