ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
2,172 Commits 5 Branches 232 Tags
6fb48c0cd7287bb56cb8c68518c8994201948720
Commit Graph

60 Commits

Author SHA1 Message Date
Éric Lemoine
6fb48c0cd7 Enables unselecting selected features by clicking outside any feature. This is the default mode of the modify feature control. If you want to use the old mode where a click on a selected feature unselects that feature, set the toggle option to true. If you really want the old mode and not have selected features be unselected when clicking outside any feature, set the clickout option to false. The patch also adds the properties toggleKey and multipleKey to the modify feature control. With these one can temporarily enable the toggle and multiple mode, respectively. See the select-feature.html example to see all this in action. Thanks to pvalsecc and tschaub for the great colloration on this. (closes #1137) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5506 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-12-19 11:09:44 +00:00
Éric Lemoine
dc2cc625f3 Do not call preFeatureInsert() and onFeatureInsert() callbacks when the modify feature control and the regular polygon handler internally adds point geometries to the layer. This is accomplished by adding an 'options' argument to the addFeatures() method in Layer.Vector. If that options argument has the silent property set to true, then the preFeatureInsert() and onFeatureInsert() callbacks aren't called. Thanks tschaub and fredj for your input. Thanks crschmidt for the final review. (closes #1148) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5470 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-12-17 14:36:39 +00:00
Tim Schaub
6ad22b8e6a adding a click handler for flexible cross-browser single and double click handling - add to a control and set click or dblclick callbacks - thanks for the review and pairing crschmidt (closes #1211) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5438 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-12-16 04:42:14 +00:00
crschmidt
7881c2099a When trying to deactivate a control from within that control's featureAdded 
event, a null exception is encountered. A null check fixes this bug. (Closes
#1143)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@5433 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-12-15 21:29:06 +00:00
crschmidt
5824170f10 Box Handler should use CSS to style its box. (Closes #1070) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5399 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-12-13 19:51:49 +00:00
Éric Lemoine
2f7fad80df Handler.Point doesn't render points if no default resolution props in map object. Thanks fredj for the review. (closes #1205) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5396 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-12-13 14:53:36 +00:00
Tim Schaub
ceecacfe3a adding irregular option to regular polygon control - now, go draw rectangles, and more - thanks for the review elem (closes #1098). 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5200 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-11-15 23:37:36 +00:00
Tim Schaub
ba8354b593 Make the drag handler only call done if it actually dragged - thanks for the review Eric (closes #1118). 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5097 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-11-01 20:53:06 +00:00
Éric Lemoine
756f6ca24d handlers have to check if layer exists before destroying it. Thanks pgiraud. (closes #1107) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5085 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-11-01 13:37:16 +00:00
Paul Spencer
3e9beffc99 large scale syntactic clean up adding missing semi-colons and curly braces around blocks. 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5002 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-10-18 12:27:35 +00:00
crschmidt
ed3221441c Refactor SVN layout in compliance with RFC/LicenseChange. This hopefully 
completes an important blocker for moving forward with OSGeo incubation. 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4985 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-10-17 02:21:22 +00:00
Tim Schaub
ad4044cd3b Make the drag handler tidy up after itself a bit more. This solves the click blocking after shift-drag issue (see #1003). 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4400 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-09-19 21:01:04 +00:00
Tim Schaub
91fab27e7d Simplify click handling in the drag handler - this makes the sequence down, move, up a complete drag (see #982). 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4354 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-09-17 19:25:26 +00:00
Tim Schaub
2337f9f2d8 Adding angle brackets to link class names in the docs (see #983). 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4353 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-09-17 16:59:16 +00:00
Tim Schaub
2478677985 Deprecating all prototype extensions. This puts all OpenLayers functionality in the OpenLayers namespace. If you are using any of the Function, String, or Number prototype extensions, start using the functional equivalents in the OpenLayers namespace - the prototype extensions will be gone in 3.0 (closes #712). 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4302 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-09-14 20:08:47 +00:00
crschmidt
d8ab004642 Remove class_name jsdoc for consistency, thanks fredj. (Closes #853) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4256 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-09-13 10:27:39 +00:00
crschmidt
024779d898 With review from elem and additional tests, add filter by geometry type 
to select feature control, with tests. (Closes #951)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4243 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-09-12 15:05:18 +00:00
Éric Lemoine
6f16455b1c select features on "click" as opposed to on "mousedown" (closes #891) 
thanks to all for the review and to crschmidt for updating the patch


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4241 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-09-12 14:25:34 +00:00
crschmidt
983618f2fa fix for 'map elements are selected in IE when using shift key' in drag 
handler from pierre.
Confirmed that this can be tested simply by using anything with a drag handler
in IE, so it will get caught in acceptance test. 
(Closes #792)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4230 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-09-12 04:18:59 +00:00
crschmidt
82c64254e5 Fix lacking code from #666-- I had originally wanted to add this, but couldn't 
craft a test which exposed the lack ... until i realized with pgiraud's help
that my test was backwards to begin with. (Closes #666)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4217 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-09-11 14:26:08 +00:00
Tim Schaub
35dae2bdb0 Adding a RegularPolygon handler for drawing squares, triangles, circles, etc. Demo in the regular-polygon.html example. Also adding a createRegularPolygon class method to the Polygon geometry class. Thanks to crschmidt for all the tests and help getting this in (closes #828). 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4205 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-09-10 20:24:27 +00:00
Tim Schaub
cecf760f29 make the drag handler and drag feature control tidy up after themselves - as a bonus, give the drag feature control an onStart method. Thanks for the review crschmidt (closes #950). 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4147 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-30 23:25:49 +00:00
Tim Schaub
c2148651ed Filling our log with cruft, adding meaningless conflicts for merges, and changing a comment style that ndocs could care less about, this commit changes Return to Returns (closes #945). 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4110 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-29 18:44:10 +00:00
euzuro
b5ef77096c wiki/NaturalDocs says we should be using 'Return:' and not 'Returns:' so this patch is fixing that. Of course, in the process, I came across not a few instances where other ND related whitespace or typos were at odds with a peaceful, uniform OL codebase. No functional changes here, just makin' things pretty. 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4109 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-29 18:08:32 +00:00
Tim Schaub
e5641c76e0 Fix deactivate and destroy methods on the keyboard handler. Add 28 tests for previously untested handler. Thanks to Erik for the quick review and comments - appreciated as always (closes #943). 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4108 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-29 17:37:42 +00:00
Tim Schaub
eb65e9c2b3 natural docs comments for the keyboard handler 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4107 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-29 16:15:45 +00:00
crschmidt
46c5cd6812 Properly destroy OpenLayers.Handler.MouseWheel, patch from fredj. Added 
tests for it as well. (Closes #935)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4100 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-29 04:21:17 +00:00
Tim Schaub
984cdf6672 Modify drag handler for easier subclassing. Thanks for the team effort on this one (closes #827). 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4096 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-29 03:11:41 +00:00
Tim Schaub
153b7a2a78 Properly destroy features in the polygon handler. Many thanks to fredj who has caubht these issues, provided clear patches, and written solid tests. More please. (Closes #934) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4076 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-28 16:34:53 +00:00
Tim Schaub
2d636c1ae4 Properly destroy features in the point, path, and polygon handlers. Patch with tests from fredj - thank you for the catch and the great patch. (Closes #931) 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4063 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-27 21:03:28 +00:00
crschmidt
ab40f522c9 "JS error after using mousewheel without having moved the mouse before." 
Update MouseWheel handler to use center of map if no mousemovement has 
been seen yet. (Closes #882)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4042 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-25 07:46:52 +00:00
crschmidt
0d2f10ad5c EditingToolbar does not display first segment in VML until 3 points added. 
This fixes the bounds, which fixes the vml behavior in IE. (Closes #666.) 
Hooray, no more devil ticket.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4036 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-24 22:33:28 +00:00
crschmidt
c2c821e4c2 DragFeature test Broken in IE6. The tests all passed because this only caused 
problems on destroy()/page unload, after all the tests had been run. Thanks 
for the review, tschaub. (Closes #923.)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4035 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-24 22:07:18 +00:00
crschmidt
6194452b8a Since John already went ahead and committed the main change, I'm just going 
to finish this one up. All commits are in comments, so a review doesn't seem
strictly neccesary. This closes #918 and fixes all the copyrights that I could 
find in the code.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3984 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-23 11:29:06 +00:00
Tim Schaub
56490d73ce #905 - give the drag handler back its start property - controls use but do not modify these handler properties 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3906 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-15 20:48:17 +00:00
Tim Schaub
b4da05da35 #774 - drag control only calls move callback with a change in pixel position - DragPan control simplified 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3891 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-08-11 03:32:41 +00:00
euzuro
cf5a53959e ND Update: make array's say what they're made of, and a few other small bits, like mistyped and a couple missing <>s 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3829 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-07-31 20:02:03 +00:00
euzuro
fd4d2918f1 fix for #853 - remove JSDOC comments from CLASS_NAME variables 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3787 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-07-23 15:09:09 +00:00
Tim Schaub
cc1b0269c9 #823 New class style. Instead of OldStyle = Class.create(); OldStyle.prototype = Class.inherit(Parent, prototype), we now use NewStyle = OpenLayers.Class(Parent, prototype). New style classes allow for backwards compatibility [you can use OldStyle = Class.create(); Class.inherit(NewStyle, prototype)]. The Class.create and Class.inherit functions are deprecated. Backwards compatibility will be removed at 3.0. Thanks Erik for the careful review. 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3767 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-07-16 20:25:11 +00:00
Tim Schaub
0a3de3fddc coding standards - getting rid of these tabs all at once 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3686 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-07-10 21:56:11 +00:00
Tim Schaub
728ba09060 more doc comments for the drag handler 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3659 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-07-09 20:02:52 +00:00
Tim Schaub
e276f84deb more whitespace changes in Handler/Drag.js 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3642 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-07-07 00:12:57 +00:00
Tim Schaub
0f47f1d73f #812 - give drag handler a done callback 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3641 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-07-07 00:09:22 +00:00
euzuro
af8cce4f7b cosmetic nd changes, coding standards 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3639 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-07-06 23:05:28 +00:00
euzuro
a74a9bd49f remove *private* statements from nd comments 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3620 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-07-06 17:38:20 +00:00
euzuro
3d73171521 move all nd comments for CLASS_NAME back to jsdoc style. my personal opinion is that we should get rid of this comment entirely... but that's something that can be debated. so long as they are all the same, it makes it easier to do a global replace when a decision is reached 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3587 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-07-05 17:33:29 +00:00
crschmidt
3948913bfc Merge all changes from the naturaldocs sandbox. This brings all the work that 
has been done in the NaturalDocs branch back to trunk. Thanks to everyone who
helped out in making this happen. (I could list people, but the list would
be long, and I'm already mentally on vacation.)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3545 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-06-29 15:59:20 +00:00
Schuyler Erle
7a3eabceeb Prevent click event when dragging in Handler.Drag. Fixes #656. 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3082 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-04-17 18:25:04 +00:00
Tim Schaub
645bff1286 #628 - a feature has a geometry - a geometry doesn't have a feature - features are rendered, selected, moved, modified, etc - down in the renderer, expando properties on nodes are limited to _featureId, _style, and _options - this removes expandos that created circular references back through the map and to other dom elements - when the renderer is involved in selecting features, it returns a featureId (instead of a geometry or feature) and the layer is responsible for fetching the appropriate feature 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3043 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-04-10 16:07:56 +00:00
crschmidt
8af1822d94 Minor change to change default post-drag styling from 'default' to ''. This allows 
CSS-based styling of the cursor on the map, rather than forcing 'default' after every
action. Tested in Safari, Opera, Firefox, IE7. Patch from Andreas Hocevar, #635. Thanks!


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3042 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
 2007-04-10 10:35:16 +00:00