Commit Graph

10991 Commits

Author SHA1 Message Date
Tim Schaub
69385f4ff0 More consistent event types 2013-12-11 16:54:01 -07:00
Tim Schaub
625007f364 Make enum property name like its value
Where an enum value is used as an event type, it should be alllowercase (to follow DOM events).  Property names should be ALLUPPERCASE in this case (just as camelCase and PascalCase are converted to CONSTANT_CASE).
2013-12-11 16:54:01 -07:00
Tim Schaub
c8985b9906 Using unique event type values for distinct events
Any event target can be used to dispatch generic goog.events.Event instances with an arbitrary type.  In cases where we dispatch custom events, we should not use type values that collide with those used for generic events (at least internally).  This allows listeners a better chance of knowing what kind of argument they will receive.

As subsequent change will clean up the enumeration and add a bit more consistency.
2013-12-11 16:53:52 -07:00
Tim Schaub
17e91feb52 Listen for property changes in layer group
This avoids a future bug when the ol.ObjectEventType.CHANGE value becomes something different than the goog.events.EventType.CHANGE value.
2013-12-11 12:23:05 -07:00
Tim Schaub
1783776976 Getting explicit about which type 2013-12-11 11:36:04 -07:00
Tim Schaub
153cb307e0 Handle beforechange events for bound properties 2013-12-11 11:25:51 -07:00
Tim Schaub
9d3a4e3c6c Add beforechange event type and provide key with change events
If you know ahead of time that you only want to listen for changes for a specific property, the foo:change type events can be useful.  If you want to listen for changes on all properties, the change event becomes more useful if it provides information on what changed.  And the beforechange event allows listeners to access values before they change.
2013-12-11 11:25:50 -07:00
Tim Schaub
d4f20192d4 Merge pull request #1349 from tschaub/fewer-change-events
Clean up layer change event handling.
2013-12-11 10:14:16 -08:00
Tim Schaub
8b8563f0fd Test change events on layer groups 2013-12-11 01:46:23 -07:00
Tim Schaub
5a5d1dec40 Remove unused handleLayerVisibleChange 2013-12-11 01:38:44 -07:00
Tim Schaub
a792a224f6 Avoid duplicate change event on visibility change 2013-12-11 01:28:55 -07:00
Tim Schaub
858fe14163 No need for handleLayerChange in base layer 2013-12-11 01:23:51 -07:00
Tim Schaub
8fbfac52d4 Avoid firing duplicate change events in ol.layer.Layer 2013-12-11 01:20:07 -07:00
Tim Schaub
3e905d804c Merge pull request #1335 from tschaub/geometry-type
Change geometry type enum and mark as stable.
2013-12-10 08:50:54 -08:00
ahocevar
d147d11b51 Merge pull request #1347 from ahocevar/no-original
Remove original handling on ol.Feature
2013-12-10 00:59:28 -08:00
ahocevar
211e288f33 Remove original handling on ol.Feature
This is another attempt to bring master closer to the
vector-api branch. In anticipation of the ability to keep track
of modifications on ol.Object through a beforechange event
(d7e4be0), we will be able to manage originals on the
application level or in a separate component outside of
ol.Feature.
2013-12-09 18:33:34 +01:00
ahocevar
d53ad07279 Merge pull request #1346 from ahocevar/set-srsname
Set the srs name when writing GetFeature
2013-12-09 08:28:14 -08:00
ahocevar
2fc89b967a Define type for applyWriteOptions call 2013-12-09 17:19:03 +01:00
ahocevar
8328db26d4 Set the srs name when writing GetFeature
Also make clear that srsName is only optional for WFS 1.0.0.
2013-12-09 16:57:11 +01:00
ahocevar
7071e6637b Merge pull request #1344 from ahocevar/modify-remove
unable to removeInteration in modify-features example
2013-12-09 07:17:30 -08:00
ahocevar
8d55e14986 Safeguard against the case where no features are modifiable 2013-12-09 13:25:14 +01:00
Tom Payne
87f147db60 Merge pull request #1341 from twpayne/mapguide-clean-ups
Tidy up ol.source.MapGuide and add ratio option
2013-12-06 12:50:43 -08:00
ahocevar
951e874914 Merge pull request #1339 from ahocevar/wfs-transaction
Transaction handling and exports for the WFS parser
2013-12-06 12:26:12 -08:00
ahocevar
19cb3c5835 Addressing review comments
* Do not write xmlns
* Make @this annotations consistent
* Handle numbers and strings for attribute values
* Fix defaultNamespaceURI scope
2013-12-06 19:15:44 +01:00
Tom Payne
43e4292ec9 Tidy up ol.source.MapGuide and add ratio option 2013-12-06 18:11:01 +01:00
Tom Payne
0a5cc8812c Merge pull request #1236 from jumpinjackie/master
MapGuide untiled map support
2013-12-06 08:59:57 -08:00
ahocevar
e49464a573 No native element on GetFeature queries 2013-12-06 16:49:44 +01:00
ahocevar
198b05047e Export the WFS parser and its write methods
For using the WFS parser, users need to be able to write
GetFeature queries and transactions.
2013-12-06 11:06:39 +01:00
ahocevar
35b8fdc00c Export getParser()
This reduces the API footprint of versioned parsers, because
only the base parser needs to be exported as symbol, and
versioned parsers can be accessed using the getParser() method.
2013-12-06 11:06:12 +01:00
ahocevar
b3b9add06e Add Insert, Update and Delete writers
This change also adds some type annotations for better type
checking, introduces different write options for writing
transactions and queries, and provides new writeGetFeature and
writeTransaction methods.
2013-12-06 10:57:58 +01:00
ahocevar
f539eb140f Use standard x, y axis order if we do not know better 2013-12-06 10:49:24 +01:00
ahocevar
77a8e91a2e Merge pull request #1337 from ahocevar/no-foo
Proper namespace and sub-parser management in OGC parsers
2013-12-06 00:47:59 -08:00
ahocevar
fa0cc538f5 Proper namespace and sub-parser management
Instead of setting a dummy namespace, we can have setter methods
for the featureNS property to propagate them to sub-parsers. The
srsName is also a property which needs to be propagated to
sub-parsers.
2013-12-06 01:08:45 +01:00
ahocevar
af4308f481 Merge pull request #1336 from ahocevar/fix-writers-typo
Fix a typo - it's writers, not witers
2013-12-05 16:00:13 -08:00
ahocevar
1bf4b9bf49 Fix a typo - it's writers, not witers 2013-12-06 00:53:16 +01:00
Tim Schaub
e6841b6088 Merge pull request #1297 from tschaub/observable
Create ol.Observable.
2013-12-05 15:13:00 -08:00
Tim Schaub
8297f6a9da Marking the geometry type enum as stable 2013-12-05 14:58:22 -07:00
Tim Schaub
9d00b1b993 This commit serves no purpose other than helping minimize a diff 2013-12-05 14:44:36 -07:00
Tim Schaub
2f7fa8f442 Using PascalCase for geometry enum values
This adds a bit more inconsistency to the library, but we didn't have complete consistency before.  Almost all existing string enum values are lowercase (a couple are camelCase and one is dash-separated).  The closure library isn't consistent either (with case for enum properties or values).  I imagine this could be justified in saying someone could blindly use GeoJSON type values in places, but in the end, you'll need to read the docs before guessing right.
2013-12-05 14:40:26 -07:00
Tim Schaub
4ee9605d61 Using CONSTANT_CASE for geometry type 2013-12-05 14:00:04 -07:00
Tim Schaub
162b245d7c ol.Object extends ol.Observable 2013-12-05 12:28:33 -07:00
Tim Schaub
3dc40f8cb6 Add ol.Observable for on, once, un, and unByKey methods 2013-12-05 12:27:30 -07:00
Tom Payne
fac8936688 Merge pull request #1333 from twpayne/object-get-properties
Add ol.Object#getProperties
2013-12-05 07:40:32 -08:00
Tom Payne
7ae7c8e41e Merge pull request #1334 from twpayne/build-check
Don't build ol.css in check target
2013-12-05 07:40:13 -08:00
Tom Payne
dfdec96ba7 Export ol.Object#getProperties 2013-12-05 16:32:41 +01:00
Tom Payne
d9c94c7012 Don't build ol.css in check target 2013-12-05 13:12:39 +01:00
Tom Payne
f795adcd56 Add ol.Object#getProperties 2013-12-04 19:19:51 +01:00
Tom Payne
bcda3aa3c2 Merge pull request #1331 from twpayne/rbush-is-empty
Add ol.structs.RBush#isEmpty
2013-12-04 06:26:41 -08:00
Tom Payne
2be40a1ae6 Add ol.structs.RBush#isEmpty 2013-12-04 15:05:43 +01:00
Tom Payne
b64e899b92 Merge pull request #1330 from twpayne/fail-if-major-performance-caveat
Don't use WebGL if there as a major performance caveat
2013-12-04 04:58:46 -08:00