euzuro
672d3c4eed
give the navigation control a proper destroy and also give it a test file while we're at it. ( Closes #1289 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5990 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-05 06:34:20 +00:00
Éric Lemoine
3acc19ae3d
The modify feature control destroys the vertex that was dragged in the drag
...
complete callback. Thus, the drag feature control won't detect a mouse-out on
that vertex and won't deactivate its drag handler. This causes errors because
the drag feature control has a feature to drag but that feature is destroyed
(feature.geometry is null). To prevent this, we make resetVertices explicitely
call outFeature on the drag feature control if the control has a feature to
drag. tschaub did most of the investigation on the problem. r=tschaub,me
(closes #1235 )
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5974 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-03 17:10:03 +00:00
Tim Schaub
9bb51fb088
Taming the select feature control a bit. Previously, onUnselect was called twice for every unselection. r=elemoine ( closes #1234 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5959 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-02-01 16:42:33 +00:00
crschmidt
ea5e96df85
Add support to set the 'title' property of a control such that it will
...
be displayed when hovering over the control in a control.panel via its
panel_div. r=me (Closes #822 )
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5910 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-01-27 14:44:16 +00:00
ahocevar
45d5fdfd06
SelectFeature and OpenLayers.Feature.Vector.style["select"]: changed Control.SelectFeature to inherit properties that are not set in selectStyle from feature.style. r=tschaub ( closes #1260 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5896 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-01-25 23:13:57 +00:00
crschmidt
81505f54b0
Add generic 'button' control. r=tschaub. ( Closes #872 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5870 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-01-24 03:16:42 +00:00
Tim Schaub
9193ef67d5
Gutting the OverviewMap control to give it an update. Now uses a click handler and a drag handler instead of its own event handling code. In addition, the control now has a minRecSize property. When the extent rectangle is smaller than the specified size, its style is switched. By default, we provide a rectangle replacement graphic. This can be customized with CSS. Finally, I'm tucking in one non-API property. The dragging arg sent to map.setCenter is now stored at map.dragging. This gives easy reference to dragging state where a reference to the navigation control and its drag handler is not convenient. r=pspencer ( closes #1244 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5674 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-01-07 20:54:28 +00:00
Tim Schaub
d7cd93abf3
If your browser doesn't support the script tag, you have no business running these tests.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5658 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-01-06 22:10:28 +00:00
Tim Schaub
d643492888
Proper handling of virtual vertices so we don't leave them on the layer. r=crschmidt ( closes #1230 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5623 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2008-01-02 18:54:33 +00:00
Tim Schaub
36e04a689f
Adding OpenLayers.Array.filter to mimic Array.prototype.filter. Adding panel.getControlsBy and related methods that use filter. Reworking map.getBy to use filter as well. r=elemoine ( closes #1203 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5532 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-12-20 08:12:19 +00:00
crschmidt
acc8cfc0f2
add displayProjection API Property on the Map, and on relevant controls.
...
Spherical mercator example now makes use of this, displaying coordinates
in lon/lat instead of meters, and permalink/argparser now work in lon/lat
as well. this functionality will make using SphericalMercator easier for
a number of applications.
r=tschaub (Closes #1036 )
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5519 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-12-19 23:36:34 +00:00
Éric Lemoine
6fb48c0cd7
Enables unselecting selected features by clicking outside any feature. This is the default mode of the modify feature control. If you want to use the old mode where a click on a selected feature unselects that feature, set the toggle option to true. If you really want the old mode and not have selected features be unselected when clicking outside any feature, set the clickout option to false. The patch also adds the properties toggleKey and multipleKey to the modify feature control. With these one can temporarily enable the toggle and multiple mode, respectively. See the select-feature.html example to see all this in action. Thanks to pvalsecc and tschaub for the great colloration on this. ( closes #1137 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5506 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-12-19 11:09:44 +00:00
crschmidt
9e6d2a649a
FF and Opera have different ideas about how this test should work.
...
FF2 won't work unless the map is loaded 'onload' -- but in Opera, adding
something to onload causes opera to believe that the page never finishes
loading within the test framework. FF3 works fine with this test if we
don't run it in a new window, but FF2 does not. For the time being, make
it work in our most well-supported platform -- FF2 -- and add a
FIXME to make it work in Opera.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5474 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-12-17 17:09:42 +00:00
crschmidt
ccf16fa024
Work around the Opera test failures for now, and log to debug that they fail
...
so that someone who is motivated knows to fix them.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5469 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-12-17 13:39:04 +00:00
Éric Lemoine
175c401e0f
ModifyFeature: enable dragging without enabling vertex modifications. Special thanks to tschaub for the collaboration on all the changes to the modify feature control. And thanks to crschmidt for the review. ( closes #1188 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5467 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-12-17 10:12:56 +00:00
crschmidt
dc05a91d4a
don't open a new window: we don't need to in order to run this test.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5463 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-12-17 06:29:46 +00:00
crschmidt
8a6f50496f
fix more tests in Opera by adding map.destroy() calls.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5461 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-12-17 06:20:10 +00:00
Tim Schaub
8f38213e86
scope matters
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5384 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-12-12 17:45:39 +00:00
crschmidt
354817649d
MousePosition control throws error when no layers are on map. Fix it so that
...
they don't. Thanks for the review, fredj. Includes tests. (Closes #1029 )
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5371 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-12-11 07:27:45 +00:00
Tim Schaub
10cf5bfefc
drag, rotate, resize, and reshape with the ModifyFeature control - thanks pvalsecc and elemoine for the inspiration, tests, and code - good partenering with you guys ( closes #1150 ).
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5301 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-11-30 17:09:23 +00:00
Tim Schaub
8007298d7b
Dissalow vertex deletion while dragging - thanks for the review crschmidt ( closes #1122 ).
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5099 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-11-01 23:06:10 +00:00
euzuro
137a69b17a
Change to getZoomForResolution() (and those who call it) so that it does not choose the closest fit by default. Doing so was causing us problems, because user would drag a zoom box and then the map's new zoom would not contain said zoombox. Not good. Default is back to how it was before, but now there's an option 'closest' for those times when what we really want is the closest. Right now, the only time that's true is when we're switching baselayers. This is based on the work from sandbox/euzuro/zoomToResolution, which is started by reverting r4318. ( Closes #1043 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4792 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-10-03 19:21:05 +00:00
crschmidt
0307d4868a
Fix to mouseposition destroy from fredj
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4431 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-21 11:44:36 +00:00
Tim Schaub
1f745b4be9
New behavior for layer.getZoomForResolution. This method now returns the index of the resolution closest to the passed in resolution - making for fewer unwanted resolution changes, and a generally happier populace (see #990 ).
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4381 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-19 00:23:26 +00:00
crschmidt
e961366869
"New permalink code maintains existing parameters ... including the
...
lat/lon/zoom/layers." Reported by bobkare (thx, bobkare!) with a patch by same,
rewritten by Schuyler, reviewed by me -- and I'm committing because Schuyler's
whitespace was bad. (RC1, here we come!)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4345 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-17 03:47:57 +00:00
crschmidt
b2a4acb717
When you have a polygon feature over a point feature in the same layer, and you
...
attempt to drag the point feature, you get errors about this.feature.geometry
being undefined. Fix this by not unsetting this.feature inside the
doneDragging. (Closes #971 )
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4341 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-16 19:27:23 +00:00
crschmidt
65466b0c27
Controls need updating. This update should fix the tests from the attribution
...
control addition. This should be fixed better -- specifying the index is the
wrong way to test this.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4337 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-16 16:43:25 +00:00
crschmidt
8a3fb3dce3
"Layer Switcher does not do sufficient layer state information storage",
...
review by e-dog. (Closes #970 )
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4336 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-16 16:22:45 +00:00
crschmidt
f505542fbe
"The Permalink control passes an element as the first parameter, however, the
...
initialize.apply is called with the arguments object, which causes an error if
an element is passed into the control." Also applied to Scale. Now fixed
with review from e-dog. (Closes #978 ) Fixes the only problem I found with
migrating the Boston freemap to 2.5.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4333 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-16 15:59:11 +00:00
Tim Schaub
dd8d895460
Modify away! This was a long time coming. Thanks all for contributions. The ModifyFeature control lets you select a feature for modification, drag around vertices (or the whole feature in the case of a point), delete vertices, and add new vertices ( closes #941 ).
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4272 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-13 23:22:06 +00:00
crschmidt
446759fd65
FredJ reviewed my work here and said it solved the problem that he reopened
...
103 for (specifically, that baselayer changes always resulted in a null
attribution string), and fixes spelling. This commit makes the attribution
control work and stuff. (Closes #103 )
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4237 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-12 13:40:28 +00:00
crschmidt
48a9da00ec
Erik helps me fix tests. I threaten to kill him for criticizing my lack
...
of semicolons. All is well. Fix for "keep selected features drawn with
the right style". (Closes #916 )
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4232 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-12 05:12:00 +00:00
euzuro
c519879391
adding OpenLayers.Control.Attribution to the list of controls in the OL suite. includes example and tests. very nice. Thanks to pensyakito and cr5 for getting this together and complete. ( Closes #103 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4231 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-12 04:37:45 +00:00
euzuro
0e8e7ab620
making the layerswitcher a little smarter. Instead of fancy 'noEvent' parameters, we just keep track of the state at each redraw. When asked to redraw, we then check first to see if anything has changed before going ahead with the redraw. Also in this patch, we add a 'visibilitychanged' event to the layer's events object -- upon request by users. ( Closes #878 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4229 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-12 04:00:31 +00:00
euzuro
7a37ed4423
make sure permalink updates itself when layers change name/visibility or when a baselayer switch is made. ( Closes #359 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4228 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-12 03:26:35 +00:00
Tim Schaub
b3e524960b
adding basic tests for the select feature control
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4149 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-31 00:27:28 +00:00
Tim Schaub
cecf760f29
make the drag handler and drag feature control tidy up after themselves - as a bonus, give the drag feature control an onStart method. Thanks for the review crschmidt ( closes #950 ).
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4147 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-30 23:25:49 +00:00
Tim Schaub
06d41662d7
Clear the feature stored by the DragFeature control when the user moves the mouse out or when dragging completes ( closes #942 ).
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4111 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-29 18:56:48 +00:00
Tim Schaub
e4d857b167
removing HTML comment wrapping scripts - these haven't been necessary since Netscape 2.0 - if your browser doesn't run javsacript, please don't run these tests
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4059 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-27 17:47:50 +00:00
euzuro
2f915df985
remove IE clause from permalink test -- no longer needed. ( Closes #730 )
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4054 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-27 16:06:15 +00:00
crschmidt
c79f1a56c8
( Closes #730 ) These changes make the permalink smarter in the case where we
...
already have some URL args in the URL. Thanks to penyaskito for the bug
report.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4047 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-27 12:46:29 +00:00
Tim Schaub
7081aab12a
#638 let features be dragged
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3958 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-22 21:23:07 +00:00
Tim Schaub
9de2749502
#774 - dragPan only calls setCenter if the map moves - thanks for the discussion and careful review Eric!
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3902 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-14 15:27:59 +00:00
crschmidt
4de7f79d45
seperate out map initialization
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3888 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-11 02:01:17 +00:00
crschmidt
1febc2cd96
Add movement tests to test_DragPan
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3886 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-11 01:37:12 +00:00
crschmidt
d5da925ffc
tabs -> spaces.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3874 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-08 10:03:13 +00:00
crschmidt
73d2825c4e
Commiting fix for #716 , "Make LayerSwitcher support displayInLayerSwitcher
...
for Base Layers", reviewed by Erik, tested by tschaub.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3853 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-04 12:14:32 +00:00
Tim Schaub
cc1b0269c9
#823 New class style. Instead of OldStyle = Class.create(); OldStyle.prototype = Class.inherit(Parent, prototype), we now use NewStyle = OpenLayers.Class(Parent, prototype). New style classes allow for backwards compatibility [you can use OldStyle = Class.create(); Class.inherit(NewStyle, prototype)]. The Class.create and Class.inherit functions are deprecated. Backwards compatibility will be removed at 3.0. Thanks Erik for the careful review.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3767 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-16 20:25:11 +00:00
crschmidt
9ebf950e3b
#651 : PanZoom should not block mouseup. Reviewed by tschaub.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3766 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-16 19:07:01 +00:00
crschmidt
6aea8da115
Add basic DragPan test.
...
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3542 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-06-29 12:49:39 +00:00