Commit Graph

29 Commits

Author SHA1 Message Date
Tim Schaub
33e313b059 Separating jsdoc style docs into their own block. The new NaturalDocs doesn't parse these mixed blocks, giving us no class descriptions with the two together. (closes #1229)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5553 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-12-21 08:28:09 +00:00
Éric Lemoine
dc2cc625f3 Do not call preFeatureInsert() and onFeatureInsert() callbacks when the modify feature control and the regular polygon handler internally adds point geometries to the layer. This is accomplished by adding an 'options' argument to the addFeatures() method in Layer.Vector. If that options argument has the silent property set to true, then the preFeatureInsert() and onFeatureInsert() callbacks aren't called. Thanks tschaub and fredj for your input. Thanks crschmidt for the final review. (closes #1148)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5470 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-12-17 14:36:39 +00:00
crschmidt
fb3c02354f Add support for the extremely awesomely super-comprehensive rule based styling
that Andreas has been working so hard on. I think this is the single most
awesome commit I've ever had the pleasure of committing. The results of this
commit are described on http://trac.openlayers.org/wiki/Styles: essentially,
this makes it possible to style features in all kinds of fun ways based on
rules, and will also form the underlying basis for #533. Things this patch
adds:

 * OL.Rule classes. These classes allow you to do tests against the propertie
   of a feature, and set a style based on these properties -- so you can
   compare the 'speedlimit' property of a line, and test if it is > 60, and if
   it is greater than 60, render it in a different color. You can also test
   combinations of rules using the OL.Rule.Logical class, and test featureids
   with the FeatureID class. 
 * OL.Style class: The OL.Style class lets you wrap up Rules into styles that 
   can be used with drawFeature to draw the feature in the selected style.
 * OL.Layer.Vector.drawFeature will check if the given style is an OL.Style
   object, and if so, it will draw the feature accordingly.

examples/georss-flickr.html shows usage of these classes.

Many, many thanks go to Andreas for all his hard work on this: this code really
is very pretty, and includes unit tests for all the classes (and we know that I
am a big fan of tests.)

Three cheers for Andreas: Hip hip, hooray! hip hip, hooray! hip hip, hooray!


git-svn-id: http://svn.openlayers.org/trunk/openlayers@5429 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-12-15 16:17:50 +00:00
Éric Lemoine
db47606f6c ND comment fix (non-functional change)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5330 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-12-03 08:44:30 +00:00
Tim Schaub
10cf5bfefc drag, rotate, resize, and reshape with the ModifyFeature control - thanks pvalsecc and elemoine for the inspiration, tests, and code - good partenering with you guys (closes #1150).
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5301 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-11-30 17:09:23 +00:00
crschmidt
263fade72a Mark drawFeature as stable (Closes #1059)
git-svn-id: http://svn.openlayers.org/trunk/openlayers@5244 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-11-21 20:31:13 +00:00
crschmidt
ed3221441c Refactor SVN layout in compliance with RFC/LicenseChange. This hopefully
completes an important blocker for moving forward with OSGeo incubation. 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4985 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-10-17 02:21:22 +00:00
crschmidt
d0aebc1a81 Fix for getFeatureFromEvent method on destroyed layer. (Closes #761) Review
by elem (yay)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@4220 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-09-11 20:19:35 +00:00
Tim Schaub
c2148651ed Filling our log with cruft, adding meaningless conflicts for merges, and changing a comment style that ndocs could care less about, this commit changes Return to Returns (closes #945).
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4110 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-29 18:44:10 +00:00
euzuro
b5ef77096c wiki/NaturalDocs says we should be using 'Return:' and not 'Returns:' so this patch is fixing that. Of course, in the process, I came across not a few instances where other ND related whitespace or typos were at odds with a peaceful, uniform OL codebase. No functional changes here, just makin' things pretty.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@4109 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-29 18:08:32 +00:00
crschmidt
6194452b8a Since John already went ahead and committed the main change, I'm just going
to finish this one up. All commits are in comments, so a review doesn't seem
strictly neccesary. This closes #918 and fixes all the copyrights that I could 
find in the code.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3984 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-08-23 11:29:06 +00:00
euzuro
cf5a53959e ND Update: make array's say what they're made of, and a few other small bits, like mistyped and a couple missing <>s
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3829 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-31 20:02:03 +00:00
euzuro
8c552be94b as universally approved on discussions on dev list, replace new Array() with []. all tests pass ff & ie6
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3815 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-25 22:48:02 +00:00
euzuro
fd4d2918f1 fix for #853 - remove JSDOC comments from CLASS_NAME variables
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3787 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-23 15:09:09 +00:00
Tim Schaub
cc1b0269c9 #823 New class style. Instead of OldStyle = Class.create(); OldStyle.prototype = Class.inherit(Parent, prototype), we now use NewStyle = OpenLayers.Class(Parent, prototype). New style classes allow for backwards compatibility [you can use OldStyle = Class.create(); Class.inherit(NewStyle, prototype)]. The Class.create and Class.inherit functions are deprecated. Backwards compatibility will be removed at 3.0. Thanks Erik for the careful review.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3767 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-16 20:25:11 +00:00
euzuro
3d73171521 move all nd comments for CLASS_NAME back to jsdoc style. my personal opinion is that we should get rid of this comment entirely... but that's something that can be debated. so long as they are all the same, it makes it easier to do a global replace when a decision is reached
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3587 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-07-05 17:33:29 +00:00
crschmidt
3948913bfc Merge all changes from the naturaldocs sandbox. This brings all the work that
has been done in the NaturalDocs branch back to trunk. Thanks to everyone who
helped out in making this happen. (I could list people, but the list would
be long, and I'm already mentally on vacation.)


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3545 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-06-29 15:59:20 +00:00
crschmidt
debffb8f12 Fix typos in documentation strings.
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3347 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-06-17 04:04:54 +00:00
euzuro
9679dbb56c fix part two to #703 - dont try to erase a null geometry
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3155 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-05-17 17:03:07 +00:00
crschmidt
7871d26df4 Since we have a destroyFeatures command, use it. Patch from fredj, closes
#703.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3151 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-05-15 21:14:26 +00:00
crschmidt
e2468e9f09 Apply Erik's patch from #680 to fix "removeFeatures() in Layer.Vector does
not remove features from the selectedFeatures array when deleting features" 


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3104 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-05-01 14:09:02 +00:00
crschmidt
1548a6c470 Patch to empty selectedFeatures when destroying all features from #665,
tschaub. This includes tests (hooray) and fixes issues with zooming a wfs
layer while you have a feature selected.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3067 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-12 10:51:39 +00:00
Tim Schaub
b02522ea4c #655: add layer.eraseFeatures.patch() on the "public" side of the API - layer methods should be called instead of layer.renderer methods wherever possible
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3065 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-11 15:48:41 +00:00
crschmidt
dbac2b1c83 Apply a patch from #657 to fix single file builds, broken by my style changes
a while back. Patch from Erik, reports from a couple people. Thanks!


git-svn-id: http://svn.openlayers.org/trunk/openlayers@3045 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-10 22:12:18 +00:00
Tim Schaub
645bff1286 #628 - a feature has a geometry - a geometry doesn't have a feature - features are rendered, selected, moved, modified, etc - down in the renderer, expando properties on nodes are limited to _featureId, _style, and _options - this removes expandos that created circular references back through the map and to other dom elements - when the renderer is involved in selecting features, it returns a featureId (instead of a geometry or feature) and the layer is responsible for fetching the appropriate feature
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3043 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-10 16:07:56 +00:00
Tim Schaub
26925a89f1 #645 - layer.removeFeatures backs through the features array to ensure that all features are removed
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3036 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-09 15:29:31 +00:00
Schuyler Erle
45407e9eda add Vector.destroyFeatures() and call it from WFS.moveTo(), which keeps WFS
from loading the same set of features multiple times. Includes tests. fixes
#622.



git-svn-id: http://svn.openlayers.org/trunk/openlayers@2996 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-03 21:02:59 +00:00
crschmidt
53977cf840 * Remove default styling from the Feature.Vector class.
* Add a 'style' property to the layer.
 * When a feature is added to a layer, either uses the style on the 
   layer, or uses the default feature style.
 * Add test to Layer.Vector for this funcionality 
 * Adds a preFeatureInsert hook to change a feature *before* 
   drawing it.
 * Change openmnnd demo to include the use of preFeatureInsert
   and style attribute on layer.


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2949 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-04-01 12:08:13 +00:00
crschmidt
3ca974acec Merge vector-2.4 branch back to trunk.
svn merge sandbox/vector-2.4/@2307 sandbox/vector-2.4/@HEAD trunk/openlayers/


git-svn-id: http://svn.openlayers.org/trunk/openlayers@2803 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
2007-03-16 13:23:56 +00:00