ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #4280 from ahocevar/box-overlaycontainer

Browse Source 
Use overlay container instead of viewport for ol.render.Box
This commit is contained in:
Andreas Hocevar
2015-10-15 21:00:20 +02:00
parent fcdff1c841 2d50511527
commit df6b90246a
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/ol/render/box.js
View File

@@ -82,13 +82,13 @@ ol.render.Box.prototype.render_ = function() {
*/
ol.render.Box.prototype.setMap = function(map) {
if (this.map_) {
this.map_.getViewport().removeChild(this.element_);
this.map_.getOverlayContainer().removeChild(this.element_);
var style = this.element_.style;
style.left = style.top = style.width = style.height = 'inherit';
}
this.map_ = map;
if (this.map_) {
this.map_.getViewport().appendChild(this.element_);
this.map_.getOverlayContainer().appendChild(this.element_);
}
};

5
test/spec/ol/render/box.test.js
View File

@@ -26,13 +26,16 @@ describe('ol.render.Box', function() {
document.body.removeChild(target);
});
describe('Constructor', function() {
describe('constructor', function() {
it('creates an absolutely positioned DIV with a className', function() {
expect(box.element_).to.be.a(HTMLDivElement);
expect(box.element_.style.position).to.be('absolute');
expect(box.element_.className).to.be('ol-box test-box');
expect(box.element_.style.position).to.be('absolute');
});
it('appends the DIV to the map\'s overlay container', function() {
expect(box.element_.parentNode).to.equal(map.getOverlayContainer());
});
});
describe('#setPixels()', function() {