Improve type checking in ol.animation

src/ol/animation.js

@@ -17,7 +17,12 @@ ol.animation.bounce = function(options) {
   var duration = goog.isDef(options.duration) ? options.duration : 1000;
   var easing = goog.isDef(options.easing) ?
       options.easing : ol.easing.upAndDown;
-  return function(map, frameState) {
+  return (
+      /**
+       * @param {ol.Map} map Map.
+       * @param {?ol.FrameState} frameState Frame state.
+       */
+      function(map, frameState) {
         if (frameState.time < start) {
           frameState.animate = true;
           frameState.viewHints[ol.ViewHint.ANIMATING] += 1;
@@ -32,7 +37,7 @@ ol.animation.bounce = function(options) {
         } else {
           return false;
         }
-  };
+      });
 };
 
 
@@ -48,7 +53,12 @@ ol.animation.pan = function(options) {
   var duration = goog.isDef(options.duration) ? options.duration : 1000;
   var easing = goog.isDef(options.easing) ?
       options.easing : ol.easing.inAndOut;
-  return function(map, frameState) {
+  return (
+      /**
+       * @param {ol.Map} map Map.
+       * @param {?ol.FrameState} frameState Frame state.
+       */
+      function(map, frameState) {
         if (frameState.time < start) {
           frameState.animate = true;
           frameState.viewHints[ol.ViewHint.ANIMATING] += 1;
@@ -65,7 +75,7 @@ ol.animation.pan = function(options) {
         } else {
           return false;
         }
-  };
+      });
 };
 
 
@@ -80,7 +90,12 @@ ol.animation.rotate = function(options) {
   var easing = goog.isDef(options.easing) ?
       options.easing : ol.easing.inAndOut;
 
-  return function(map, frameState) {
+  return (
+      /**
+       * @param {ol.Map} map Map.
+       * @param {?ol.FrameState} frameState Frame state.
+       */
+      function(map, frameState) {
         if (frameState.time < start) {
           frameState.animate = true;
           frameState.viewHints[ol.ViewHint.ANIMATING] += 1;
@@ -96,7 +111,7 @@ ol.animation.rotate = function(options) {
         } else {
           return false;
         }
-  };
+      });
 };
 
 
@@ -110,7 +125,12 @@ ol.animation.zoom = function(options) {
   var duration = goog.isDef(options.duration) ? options.duration : 1000;
   var easing = goog.isDef(options.easing) ?
       options.easing : ol.easing.inAndOut;
-  return function(map, frameState) {
+  return (
+      /**
+       * @param {ol.Map} map Map.
+       * @param {?ol.FrameState} frameState Frame state.
+       */
+      function(map, frameState) {
         if (frameState.time < start) {
           frameState.animate = true;
           frameState.viewHints[ol.ViewHint.ANIMATING] += 1;
@@ -126,5 +146,5 @@ ol.animation.zoom = function(options) {
         } else {
           return false;
         }
-  };
+      });
 };