Merge pull request #125 from twpayne/build-clean-ups

Build clean ups
This commit is contained in:
Tom Payne
2013-01-17 03:52:15 -08:00
2 changed files with 7 additions and 5 deletions

View File

@@ -192,13 +192,13 @@ def build_lint_src_timestamp(t):
limited_doc_files = [path
for path in ifind('externs', 'build/src/external/externs')
if path.endswith('.js')]
t.run('%(GJSLINT)s', '--strict', '--limited_doc_files=%s' % (','.join(limited_doc_files),), SRC, INTERNAL_SRC, EXTERNAL_SRC, EXAMPLES_SRC)
t.run('%(GJSLINT)s', '--strict', '--limited_doc_files=%s' % (','.join(limited_doc_files),), t.newer(SRC, INTERNAL_SRC, EXTERNAL_SRC, EXAMPLES_SRC))
t.touch()
@target('build/lint-spec-timestamp', SPEC)
def build_lint_spec_timestamp(t):
t.run('%(GJSLINT)s', SPEC)
t.run('%(GJSLINT)s', t.newer(SPEC))
t.touch()

View File

@@ -152,9 +152,7 @@ class Target(object):
content = urllib2.urlopen(url).read()
if md5 and hashlib.md5(content).hexdigest() != md5:
raise BuildError(self, 'corrupt download')
# FIXME Python on Windoze corrupts the content when writing it
# FIXME probably something to do with encodings
with open(self.name, 'w') as f:
with open(self.name, 'wb') as f:
f.write(content)
def error(self, message):
@@ -178,6 +176,10 @@ class Target(object):
self.info('mkdir -p %s', path)
os.makedirs(path)
def newer(self, *args):
args = flatten_expand_list(args)
return [arg for arg in args if targets.get(arg).timestamp > self.timestamp]
def output(self, *args, **kwargs):
args = flatten_expand_list(args)
self.info(' '.join(args))