ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

setState never occures

Browse Source 
Two changes for better parsing of non-existing input sources:

1 - use goog.isDefAndNotNull(source) in the condition (null is also considered as valid source now)
2 - call setState before goog.asserts.fail
This commit is contained in:
Jachym Cepicky
2014-03-04 13:01:27 +01:00
parent d7297795ee
commit be13ca635e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ol/source/vectorfilesource.js
+2 -2
View File
@@ -128,11 +128,11 @@ ol.source.VectorFile.prototype.handleXhrIo_ = function(event) {
goog.asserts.fail(); goog.asserts.fail();
} }
goog.dispose(xhrIo); goog.dispose(xhrIo);
if (goog.isDef(source)) { if (goog.isDefAndNotNull(source)) {
this.readFeatures_(source); this.readFeatures_(source);
} else { } else {
goog.asserts.fail();
this.setState(ol.source.State.ERROR); this.setState(ol.source.State.ERROR);
goog.asserts.fail();
} }
} else { } else {
this.setState(ol.source.State.ERROR); this.setState(ol.source.State.ERROR);