From be13ca635ee2ac50b753175f1a3fcd88c3a77201 Mon Sep 17 00:00:00 2001 From: Jachym Cepicky Date: Tue, 4 Mar 2014 13:01:27 +0100 Subject: [PATCH] setState never occures Two changes for better parsing of non-existing input sources: 1 - use goog.isDefAndNotNull(source) in the condition (null is also considered as valid source now) 2 - call setState before goog.asserts.fail --- src/ol/source/vectorfilesource.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ol/source/vectorfilesource.js b/src/ol/source/vectorfilesource.js index d0f972800b..d003037170 100644 --- a/src/ol/source/vectorfilesource.js +++ b/src/ol/source/vectorfilesource.js @@ -128,11 +128,11 @@ ol.source.VectorFile.prototype.handleXhrIo_ = function(event) { goog.asserts.fail(); } goog.dispose(xhrIo); - if (goog.isDef(source)) { + if (goog.isDefAndNotNull(source)) { this.readFeatures_(source); } else { - goog.asserts.fail(); this.setState(ol.source.State.ERROR); + goog.asserts.fail(); } } else { this.setState(ol.source.State.ERROR);