ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Making it so you can remove more points from a linear ring. p=gregers, r=me (closes #2172)

Browse Source 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@11819 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
This commit is contained in:
Tim Schaub
2011-03-30 23:54:54 +00:00
parent 587b2320ab
commit b8ba064ede
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/OpenLayers/Geometry/LinearRing.js
+1 -1
View File
@@ -93,7 +93,7 @@ OpenLayers.Geometry.LinearRing = OpenLayers.Class(
* point - {<OpenLayers.Geometry.Point>} * point - {<OpenLayers.Geometry.Point>}
*/ */
removeComponent: function(point) { removeComponent: function(point) {
if (this.components.length > 4) { if (this.components.length > 3) {
//remove last point //remove last point
this.components.pop(); this.components.pop();
tests/Geometry/LinearRing.html
+4 -4
View File
@@ -58,7 +58,7 @@
} }
function test_LinearRing_removeComponent(t) { function test_LinearRing_removeComponent(t) {
t.plan(11); t.plan(10);
var components = [new OpenLayers.Geometry.Point(0,0), var components = [new OpenLayers.Geometry.Point(0,0),
new OpenLayers.Geometry.Point(0,10), new OpenLayers.Geometry.Point(0,10),
@@ -71,7 +71,7 @@
t.eq(ring.components.length, 4, "removing from linear ring with 5 points: length ok"); t.eq(ring.components.length, 4, "removing from linear ring with 5 points: length ok");
t.ok(ring.components[0].equals(components[0]), "point one correct"); t.ok(ring.components[0].equals(components[0]), "point one correct");
t.ok(ring.components[1].equals(components[1]), "point two correct"); t.ok(ring.components[1].equals(components[1]), "point two correct");
t.ok(ring.components[2].equals(components[3]), "point one correct"); t.ok(ring.components[2].equals(components[3]), "point three correct");
t.ok(ring.components[0] === ring.components[ring.components.length - 1], t.ok(ring.components[0] === ring.components[ring.components.length - 1],
"first and last point are the same"); "first and last point are the same");
@@ -80,10 +80,10 @@
t.ok(ringBounds.equals(testBounds), "bounds correctly recalculated"); t.ok(ringBounds.equals(testBounds), "bounds correctly recalculated");
ring.removeComponent( ring.components[2] ); ring.removeComponent( ring.components[2] );
t.eq(ring.components.length, 4, "cant remove from linear ring with only 4 points. new length ok (unchanged)"); ring.removeComponent( ring.components[1] );
t.eq(ring.components.length, 3, "cant remove from linear ring with only 3 points. new length ok");
t.ok(ring.components[0].equals(components[0]), "point one correct"); t.ok(ring.components[0].equals(components[0]), "point one correct");
t.ok(ring.components[1].equals(components[1]), "point two correct"); t.ok(ring.components[1].equals(components[1]), "point two correct");
t.ok(ring.components[2].equals(components[3]), "point one correct");
t.ok(ring.components[0] === ring.components[ring.components.length - 1], t.ok(ring.components[0] === ring.components[ring.components.length - 1],
"first and last point are the same"); "first and last point are the same");