ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

#874 - stop global namespace pollution and actually set state on features instead of i - thanks crschmidt for the test

Browse Source 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@3838 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
This commit is contained in:
Tim Schaub
2007-08-02 18:04:47 +00:00
parent e9a488c264
commit b09585b603
3 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/OpenLayers/Format/GML.js
View File

@@ -333,7 +333,7 @@ OpenLayers.Format.GML = OpenLayers.Class(OpenLayers.Format, {
while (nums[nums.length-1] == "")
nums.pop();
for(i = 0; i < nums.length; i = i + this.dim) {
for(var i = 0; i < nums.length; i = i + this.dim) {
x = parseFloat(nums[i]);
y = parseFloat(nums[i+1]);
p.points.push(new OpenLayers.Geometry.Point(x, y));

2
lib/OpenLayers/Layer/WFS.js
View File

@@ -342,7 +342,7 @@ OpenLayers.Layer.WFS = OpenLayers.Class(
this.commitReport('WFS Transaction: SUCCESS', response);
for(var i = 0; i < this.features.length; i++) {
i.state = null;
this.features[i].state = null;
}
// TBD redraw the layer or reset the state of features
// foreach features: set state to null

7
tests/Format/test_GML.html
View File

@@ -49,6 +49,13 @@
t.eq(data[0].fid, '221', 'fid on polygons set correctly (with whitespace)');
t.eq(data[1].fid, '8', 'fid on linestrings set correctly with whitespace');
}
function test_Format_GML_no_clobber(t) {
t.plan(1);
var parser = new OpenLayers.Format.GML();
data = parser.read(test_content);
t.eq(window.i, undefined,
"i is undefined in window scope after reading.");
}
// -->
</script>
</head>