ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #12488 from JakobMiksch/fix-mouse-control-white-space

Browse Source 
MousePosition: allow rendering of empty string
This commit is contained in:
Tim Schaub
2021-07-09 15:54:22 -06:00
committed by GitHub
parent aacf12b392 9e7f5a9b40
commit a2f441715b
2 changed files with 29 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/ol/control/MousePosition.js
View File

@@ -35,8 +35,8 @@ const COORDINATE_FORMAT = 'coordinateFormat';
* @property {string} [undefinedHTML=' '] Markup to show when coordinates are not
* available (e.g. when the pointer leaves the map viewport). By default, the last position
* will be replaced with `' '` (` `) when the pointer leaves the viewport. To
* retain the last rendered position, set this option to something falsey (like an empty
* string `''`).
* retain the last rendered position, set this option to something falsey. An exception is an
* empty string `''`. It does not count as falsey in this case.
*/
/**
@@ -89,7 +89,8 @@ class MousePosition extends Control {
* @private
* @type {boolean}
*/
this.renderOnMouseOut_ = !!this.undefinedHTML_;
this.renderOnMouseOut_ =
this.undefinedHTML_ === '' || !!this.undefinedHTML_;
/**
* @private

27
test/browser/spec/ol/control/mouseposition.test.js
View File

@@ -105,9 +105,9 @@ describe('ol/control/MousePosition', function () {
expect(element.innerHTML).to.be(' ');
});
it('retains the mouse position when undefinedHTML is falsey and mouse moves outside the viewport', function () {
it('retains the mouse position when undefinedHTML is false and mouse moves outside the viewport', function () {
const ctrl = new MousePosition({
undefinedHTML: '',
undefinedHTML: false,
});
ctrl.setMap(map);
map.renderSync();
@@ -127,6 +127,29 @@ describe('ol/control/MousePosition', function () {
simulateEvent(EventType.POINTEROUT, width + 1, height + 1);
expect(element.innerHTML).to.be('20,-30');
});
it('renders an empty string if undefinedHTML is an empty string and mouse moves outside the viewport', function () {
const ctrl = new MousePosition({
undefinedHTML: '',
});
ctrl.setMap(map);
map.renderSync();
const element = document.querySelector(
'.ol-mouse-position',
map.getTarget()
);
simulateEvent(EventType.POINTEROUT, width + 1, height + 1);
expect(element.innerHTML).to.be('');
target.dispatchEvent(new PointerEvent('pointermove'));
simulateEvent(EventType.POINTERMOVE, 20, 30);
expect(element.innerHTML).to.be('20,-30');
simulateEvent(EventType.POINTEROUT, width + 1, height + 1);
expect(element.innerHTML).to.be('');
});
});
});
});