ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Improved renderer clone tests

Browse Source 
Removed test that asserted the cloned renderer would not reference the same object as the original.

Replaced tests that stringified the renderer function with tests that compare the original with the clone by reference.
This commit is contained in:
Michael Jurkoic
2021-01-10 10:10:09 -08:00
parent 760b5970f1
commit 94fcc049ce
1 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
test/spec/ol/style/style.test.js
View File

@@ -68,9 +68,7 @@ describe('ol.style.Style', function () {
expect(original.getImage().getRadius()).to.eql(
clone.getImage().getRadius()
);
expect(original.getRenderer().toString()).to.eql(
clone.getRenderer().toString()
);
expect(original.getRenderer()).to.eql(clone.getRenderer());
expect(original.getStroke().getColor()).to.eql(
clone.getStroke().getColor()
);
@@ -102,7 +100,6 @@ describe('ol.style.Style', function () {
expect(original.getGeometry()).not.to.be(clone.getGeometry());
expect(original.getFill()).not.to.be(clone.getFill());
expect(original.getImage()).not.to.be(clone.getImage());
expect(original.getRenderer()).not.to.be(clone.getRenderer());
expect(original.getStroke()).not.to.be(clone.getStroke());
expect(original.getText()).not.to.be(clone.getText());
@@ -123,9 +120,7 @@ describe('ol.style.Style', function () {
expect(original.getImage().getScale()).not.to.eql(
clone.getImage().getScale()
);
expect(original.getRenderer().toString()).not.to.eql(
clone.getRenderer().toString()
);
expect(original.getRenderer()).not.to.eql(clone.getRenderer());
expect(original.getStroke().getColor()).not.to.eql(
clone.getStroke().getColor()
);