ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #8246 from ahocevar/movetolerance-dragging

Browse Source 
Don't go back to not moving when dragging
This commit is contained in:
Andreas Hocevar
2018-06-14 13:28:48 +02:00
committed by GitHub
parent 9de086b561 5080a6d401
commit 8980ab7b11
2 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/ol/MapBrowserEventHandler.js
View File

@@ -301,7 +301,8 @@ MapBrowserEventHandler.prototype.relayEvent_ = function(pointerEvent) {
* @private
*/
MapBrowserEventHandler.prototype.isMoving_ = function(pointerEvent) {
return Math.abs(pointerEvent.clientX - this.down_.clientX) > this.moveTolerance_ ||
return this.dragging_ ||
Math.abs(pointerEvent.clientX - this.down_.clientX) > this.moveTolerance_ ||
Math.abs(pointerEvent.clientY - this.down_.clientY) > this.moveTolerance_;
};

15
test/spec/ol/mapbrowserevent.test.js
View File

@@ -168,5 +168,20 @@ describe('ol.MapBrowserEventHandler', function() {
});
expect(moveToleranceHandler.isMoving_(pointerdownAt9)).to.be(true);
});
it('is moving when moving back close to the down pixel', function() {
const pointermoveAt9 = new PointerEvent('pointermove', {}, {
clientX: (DEVICE_PIXEL_RATIO * 8) + 1,
clientY: (DEVICE_PIXEL_RATIO * 8) + 1
});
moveToleranceHandler.handlePointerMove_(pointermoveAt9);
expect(moveToleranceHandler.isMoving_(pointermoveAt9)).to.be(true);
const pointermoveAt2 = new PointerEvent('pointermove', {}, {
clientX: DEVICE_PIXEL_RATIO + 1,
clientY: DEVICE_PIXEL_RATIO + 1
});
moveToleranceHandler.handlePointerMove_(pointermoveAt2);
expect(moveToleranceHandler.isMoving_(pointermoveAt2)).to.be(true);
});
});
});