Merge pull request #3640 from elemoine/makefile

Make make fail on requires and whitespace errors

bin/check-requires.py

@@ -181,10 +181,13 @@ def check_requires(closure_lib, *filenames):
                             (filename, uses_linenos[missing_require],
                              missing_require))
                 missing_count += 1
-    if unused_count or missing_count:
-        logger.error('%d unused goog.requires, %d missing goog.requires' %
-                     (unused_count, missing_count))
+
+    return (unused_count, missing_count)
 
 
 if __name__ == "__main__":
-    check_requires(*sys.argv[1:])
+    unused_count, missing_count = check_requires(*sys.argv[1:])
+    if unused_count > 0 or missing_count > 0:
+        logger.error('%d unused goog.requires, %d missing goog.requires' %
+                     (unused_count, missing_count))
+        sys.exit(1)

bin/check-whitespace.py

@@ -37,8 +37,10 @@ def check_whitespace(*filenames):
         if whitespace:
             logger.info('%s: trailing whitespace at end of file', filename)
             errors += 1
-    if errors:
-        logger.error('%d whitespace errors' % (errors,))
+    return errors
 
 if __name__ == "__main__":
-    check_whitespace(*sys.argv[1:])
+    errors = check_whitespace(*sys.argv[1:])
+    if errors > 0:
+        logger.error('%d whitespace errors' % (errors,))
+        sys.exit(1)

test/spec/ol/interaction/modifyinteraction.test.js

@@ -145,6 +145,7 @@ goog.require('ol.Feature');
 goog.require('ol.Map');
 goog.require('ol.MapBrowserPointerEvent');
 goog.require('ol.View');
+goog.require('ol.geom.Point');
 goog.require('ol.geom.Polygon');
 goog.require('ol.interaction.Modify');
 goog.require('ol.layer.Vector');