ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Parsing emtpy attributes in GML as empty strings. Thanks for the patch bartvde. r=bartvde,me (closes #1927)

Browse Source 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8824 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
This commit is contained in:
Tim Schaub
2009-02-04 18:33:13 +00:00
parent a84a9c1144
commit 6f38974fc3
2 changed files with 35 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/OpenLayers/Format/GML/Base.js
View File

@@ -325,7 +325,8 @@ OpenLayers.Format.GML.Base = OpenLayers.Class(OpenLayers.Format.XML, {
} else {
// Assume attribute elements have one child node and that the child
// is a text node. Otherwise assume it is a geometry node.
if(node.childNodes.length == 1 && node.firstChild.nodeType == 3) {
if(node.childNodes.length == 0 ||
(node.childNodes.length == 1 && node.firstChild.nodeType == 3)) {
if(this.extractAttributes) {
name = "_attribute";
}

33
tests/Format/GML/v3.html
View File

@@ -211,6 +211,39 @@
t.eq(attributes["STATE_ABBR"], "IL", "read STATE_ABBR");
t.eq(attributes["LAND_KM"], "143986.61", "read LAND_KM");
}
function test_emptyAttribute(t) {
t.plan(4);
var str =
'<gml:featureMembers xmlns:gml="http://www.opengis.net/gml">' +
'<topp:gnis_pop gml:id="gnis_pop.148604" xmlns:topp="http://www.openplans.org/topp">' +
'<gml:name>Aflu</gml:name>' +
'<topp:the_geom>' +
'<gml:Point srsName="urn:x-ogc:def:crs:EPSG:4326">' +
'<gml:pos>34.12 2.09</gml:pos>' +
'</gml:Point>' +
'</topp:the_geom>' +
'<topp:population>84683</topp:population>' +
'<topp:country>Algeria</topp:country>' +
'<topp:type>place</topp:type>' +
'<topp:name>Aflu</topp:name>' +
'<topp:empty></topp:empty>' +
'</topp:gnis_pop>' +
'</gml:featureMembers>';
var format = new OpenLayers.Format.GML.v3({
featureType: "gnis_pop",
featureNS: "http://www.openplans.org/topp",
geometryName: "the_geom"
});
var features = format.read(str);
t.eq(features.length, 1, "read one feature");
var attr = features[0].attributes;
t.eq(attr.name, "Aflu", "correctly read attribute value");
t.eq(attr.foo, undefined, "bogus attribute is undefined");
t.eq(attr.empty, "", "empty attribute value is empty string");
}
function test_write(t) {
t.plan(1);