ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Using hasOwnProperty is better for user keys on objects we control

Browse Source
This commit is contained in:
Tim Schaub
2013-02-19 14:17:58 -07:00
parent b9507de3ea
commit 6cfc36d8cc
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ol/object.js
+6 -3
View File
@@ -91,7 +91,8 @@ ol.Object.getAccessors = function(obj) {
* @return {string} Changed name. * @return {string} Changed name.
*/ */
ol.Object.getChangedEventType = function(key) { ol.Object.getChangedEventType = function(key) {
return ol.Object.changedEventTypeCache_[key] || return ol.Object.changedEventTypeCache_.hasOwnProperty(key) ?
ol.Object.changedEventTypeCache_[key] :
(ol.Object.changedEventTypeCache_[key] = key.toLowerCase() + '_changed'); (ol.Object.changedEventTypeCache_[key] = key.toLowerCase() + '_changed');
}; };
@@ -101,7 +102,8 @@ ol.Object.getChangedEventType = function(key) {
* @return {string} Getter name. * @return {string} Getter name.
*/ */
ol.Object.getGetterName = function(key) { ol.Object.getGetterName = function(key) {
return ol.Object.getterNameCache_[key] || return ol.Object.getterNameCache_.hasOwnProperty(key) ?
ol.Object.getterNameCache_[key] :
(ol.Object.getterNameCache_[key] = 'get' + ol.Object.capitalize(key)); (ol.Object.getterNameCache_[key] = 'get' + ol.Object.capitalize(key));
}; };
@@ -121,7 +123,8 @@ ol.Object.getListeners = function(obj) {
* @return {string} Setter name. * @return {string} Setter name.
*/ */
ol.Object.getSetterName = function(key) { ol.Object.getSetterName = function(key) {
return ol.Object.setterNameCache_[key] || return ol.Object.setterNameCache_.hasOwnProperty(key) ?
ol.Object.setterNameCache_[key] :
(ol.Object.setterNameCache_[key] = 'set' + ol.Object.capitalize(key)); (ol.Object.setterNameCache_[key] = 'set' + ol.Object.capitalize(key));
}; };