From 6cfc36d8cc77e739a8d2299247db3147b6d93e6f Mon Sep 17 00:00:00 2001 From: Tim Schaub Date: Tue, 19 Feb 2013 14:17:58 -0700 Subject: [PATCH] Using hasOwnProperty is better for user keys on objects we control --- src/ol/object.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/ol/object.js b/src/ol/object.js index aff2209925..60e36e2162 100644 --- a/src/ol/object.js +++ b/src/ol/object.js @@ -91,7 +91,8 @@ ol.Object.getAccessors = function(obj) { * @return {string} Changed name. */ ol.Object.getChangedEventType = function(key) { - return ol.Object.changedEventTypeCache_[key] || + return ol.Object.changedEventTypeCache_.hasOwnProperty(key) ? + ol.Object.changedEventTypeCache_[key] : (ol.Object.changedEventTypeCache_[key] = key.toLowerCase() + '_changed'); }; @@ -101,7 +102,8 @@ ol.Object.getChangedEventType = function(key) { * @return {string} Getter name. */ ol.Object.getGetterName = function(key) { - return ol.Object.getterNameCache_[key] || + return ol.Object.getterNameCache_.hasOwnProperty(key) ? + ol.Object.getterNameCache_[key] : (ol.Object.getterNameCache_[key] = 'get' + ol.Object.capitalize(key)); }; @@ -121,7 +123,8 @@ ol.Object.getListeners = function(obj) { * @return {string} Setter name. */ ol.Object.getSetterName = function(key) { - return ol.Object.setterNameCache_[key] || + return ol.Object.setterNameCache_.hasOwnProperty(key) ? + ol.Object.setterNameCache_[key] : (ol.Object.setterNameCache_[key] = 'set' + ol.Object.capitalize(key)); };