ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Caching array length instead of accessing it with each iteration. r=crschmidt (closes #1636)

Browse Source 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7627 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
This commit is contained in:
Tim Schaub
2008-07-31 04:44:25 +00:00
parent 89b10da8db
commit 66a4c6fb0e
50 changed files with 196 additions and 196 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
lib/OpenLayers/Map.js
View File

@@ -456,7 +456,7 @@ OpenLayers.Map = OpenLayers.Class({
// check existing links for equivalent url
var addNode = true;
var nodes = document.getElementsByTagName('link');
for(var i=0; i<nodes.length; ++i) {
for(var i=0, len=nodes.length; i<len; ++i) {
if(OpenLayers.Util.isEquivalentUrl(nodes.item(i).href,
this.theme)) {
addNode = false;
@@ -488,7 +488,7 @@ OpenLayers.Map = OpenLayers.Class({
}
}
for(var i=0; i < this.controls.length; i++) {
for(var i=0, len=this.controls.length; i<len; i++) {
this.addControlToMap(this.controls[i]);
}
@@ -741,7 +741,7 @@ OpenLayers.Map = OpenLayers.Class({
*/
getLayer: function(id) {
var foundLayer = null;
for (var i = 0; i < this.layers.length; i++) {
for (var i=0, len=this.layers.length; i<len; i++) {
var layer = this.layers[i];
if (layer.id == id) {
foundLayer = layer;
@@ -769,7 +769,7 @@ OpenLayers.Map = OpenLayers.Class({
* Reset each layer's z-index based on layer's array index
*/
resetLayersZIndex: function() {
for (var i = 0; i < this.layers.length; i++) {
for (var i=0, len=this.layers.length; i<len; i++) {
var layer = this.layers[i];
this.setLayerZIndex(layer, i);
}
@@ -782,7 +782,7 @@ OpenLayers.Map = OpenLayers.Class({
* layer - {<OpenLayers.Layer>}
*/
addLayer: function (layer) {
for(var i=0; i < this.layers.length; i++) {
for(var i=0, len=this.layers.length; i <len; i++) {
if (this.layers[i] == layer) {
var msg = OpenLayers.i18n('layerAlreadyAdded',
{'layerName':layer.name});
@@ -826,7 +826,7 @@ OpenLayers.Map = OpenLayers.Class({
* layers - {Array(<OpenLayers.Layer>)}
*/
addLayers: function (layers) {
for (var i = 0; i < layers.length; i++) {
for (var i=0, len=layers.length; i<len; i++) {
this.addLayer(layers[i]);
}
},
@@ -877,7 +877,7 @@ OpenLayers.Map = OpenLayers.Class({
if(this.baseLayer == layer) {
this.baseLayer = null;
if(setNewBaseLayer) {
for(var i=0; i < this.layers.length; i++) {
for(var i=0, len=this.layers.length; i<len; i++) {
var iLayer = this.layers[i];
if (iLayer.isBaseLayer) {
this.setBaseLayer(iLayer);
@@ -938,7 +938,7 @@ OpenLayers.Map = OpenLayers.Class({
if (base != idx) {
this.layers.splice(base, 1);
this.layers.splice(idx, 0, layer);
for (var i = 0; i < this.layers.length; i++) {
for (var i=0, len=this.layers.length; i<len; i++) {
this.setLayerZIndex(this.layers[i], i);
}
this.events.triggerEvent("changelayer", {
@@ -1088,7 +1088,7 @@ OpenLayers.Map = OpenLayers.Class({
*/
getControl: function (id) {
var returnControl = null;
for(var i=0; i < this.controls.length; i++) {
for(var i=0, len=this.controls.length; i<len; i++) {
var control = this.controls[i];
if (control.id == id) {
returnControl = control;
@@ -1215,7 +1215,7 @@ OpenLayers.Map = OpenLayers.Class({
this.size = newSize;
//notify layers of mapresize
for(var i=0; i < this.layers.length; i++) {
for(var i=0, len=this.layers.length; i<len; i++) {
this.layers[i].onMapResize();
}
@@ -1541,7 +1541,7 @@ OpenLayers.Map = OpenLayers.Class({
bounds = this.baseLayer.getExtent();
for (var i = 0; i < this.layers.length; i++) {
for (var i=0, len=this.layers.length; i<len; i++) {
var layer = this.layers[i];
if (!layer.isBaseLayer) {
var inRange = layer.calculateInRange();
@@ -1566,7 +1566,7 @@ OpenLayers.Map = OpenLayers.Class({
if (zoomChanged) {
//redraw popups
for (var i = 0; i < this.popups.length; i++) {
for (var i=0, len=this.popups.length; i<len; i++) {
this.popups[i].updatePosition();
}
}