From 66a4c6fb0eb16b78b16f5358f7044a3bacda47f8 Mon Sep 17 00:00:00 2001 From: Tim Schaub Date: Thu, 31 Jul 2008 04:44:25 +0000 Subject: [PATCH] Caching array length instead of accessing it with each iteration. r=crschmidt (closes #1636) git-svn-id: http://svn.openlayers.org/trunk/openlayers@7627 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf --- lib/OpenLayers.js | 4 ++-- lib/OpenLayers/BaseTypes.js | 4 ++-- lib/OpenLayers/BaseTypes/Class.js | 4 ++-- lib/OpenLayers/BaseTypes/Element.js | 6 ++--- lib/OpenLayers/Console.js | 2 +- lib/OpenLayers/Control/ArgParser.js | 4 ++-- lib/OpenLayers/Control/Attribution.js | 2 +- lib/OpenLayers/Control/EditingToolbar.js | 2 +- lib/OpenLayers/Control/LayerSwitcher.js | 15 +++++++------ lib/OpenLayers/Control/ModifyFeature.js | 4 ++-- lib/OpenLayers/Control/MouseToolbar.js | 2 +- lib/OpenLayers/Control/OverviewMap.js | 2 +- lib/OpenLayers/Control/Panel.js | 14 ++++++------ lib/OpenLayers/Control/Permalink.js | 4 ++-- lib/OpenLayers/Events.js | 8 +++---- lib/OpenLayers/Filter/FeatureId.js | 2 +- lib/OpenLayers/Filter/Logical.js | 4 ++-- lib/OpenLayers/Format/GPX.js | 4 ++-- lib/OpenLayers/Format/GeoJSON.js | 22 +++++++++---------- lib/OpenLayers/Format/GeoRSS.js | 6 ++--- lib/OpenLayers/Format/JSON.js | 2 +- lib/OpenLayers/Format/KML.js | 28 ++++++++++++------------ lib/OpenLayers/Format/SLD/v1.js | 22 +++++++++---------- lib/OpenLayers/Format/WKT.js | 26 +++++++++++----------- lib/OpenLayers/Format/WMC/v1.js | 6 ++--- lib/OpenLayers/Format/XML.js | 4 ++-- lib/OpenLayers/Geometry/Collection.js | 22 +++++++++---------- lib/OpenLayers/Geometry/Curve.js | 2 +- lib/OpenLayers/Geometry/LineString.js | 4 ++-- lib/OpenLayers/Geometry/LinearRing.js | 12 +++++----- lib/OpenLayers/Geometry/Polygon.js | 12 +++++----- lib/OpenLayers/Handler.js | 4 ++-- lib/OpenLayers/Handler/Keyboard.js | 4 ++-- lib/OpenLayers/Handler/MouseWheel.js | 2 +- lib/OpenLayers/Layer.js | 12 +++++----- lib/OpenLayers/Layer/FixedZoomLevels.js | 2 +- lib/OpenLayers/Layer/GeoRSS.js | 6 ++--- lib/OpenLayers/Layer/Grid.js | 10 ++++----- lib/OpenLayers/Layer/HTTPRequest.js | 2 +- lib/OpenLayers/Layer/Markers.js | 6 ++--- lib/OpenLayers/Layer/PointTrack.js | 2 +- lib/OpenLayers/Layer/Text.js | 4 ++-- lib/OpenLayers/Layer/Vector.js | 13 +++++------ lib/OpenLayers/Map.js | 24 ++++++++++---------- lib/OpenLayers/Renderer.js | 2 +- lib/OpenLayers/Renderer/Elements.js | 4 ++-- lib/OpenLayers/Renderer/SVG.js | 8 +++---- lib/OpenLayers/Renderer/VML.js | 8 +++---- lib/OpenLayers/Style.js | 10 ++++----- lib/OpenLayers/Util.js | 14 ++++++------ 50 files changed, 196 insertions(+), 196 deletions(-) diff --git a/lib/OpenLayers.js b/lib/OpenLayers.js index 000c0c34ff..b0ad334e22 100644 --- a/lib/OpenLayers.js +++ b/lib/OpenLayers.js @@ -40,7 +40,7 @@ var scriptName = OpenLayers._scriptName; var scripts = document.getElementsByTagName('script'); - for (var i = 0; i < scripts.length; i++) { + for (var i=0, len=scripts.length; i"; diff --git a/lib/OpenLayers/BaseTypes.js b/lib/OpenLayers/BaseTypes.js index ae48f1517c..a016e158fb 100644 --- a/lib/OpenLayers/BaseTypes.js +++ b/lib/OpenLayers/BaseTypes.js @@ -84,7 +84,7 @@ OpenLayers.String = { camelize: function(str) { var oStringList = str.split('-'); var camelizedString = oStringList[0]; - for (var i = 1; i < oStringList.length; i++) { + for (var i=1, len=oStringList.length; i 0) { diff --git a/lib/OpenLayers/BaseTypes/Class.js b/lib/OpenLayers/BaseTypes/Class.js index 1167244230..681c683ba9 100644 --- a/lib/OpenLayers/BaseTypes/Class.js +++ b/lib/OpenLayers/BaseTypes/Class.js @@ -34,7 +34,7 @@ OpenLayers.Class = function() { }; var extended = {}; var parent; - for(var i=0; i 0)) { var continueChain; - for (var i = 0; i < listeners.length; i++) { + for (var i=0, len=listeners.length; i 0) { // this assumes exterior ring first, inner rings after var ring; - for(var i=0; i 0) { @@ -902,7 +902,7 @@ OpenLayers.Format.SLD.v1 = OpenLayers.Class(OpenLayers.Format.XML, { var node = this.createElementNSPlus("ogc:Filter"); var sub = filter.CLASS_NAME.split(".").pop(); if(sub == "FeatureId") { - for(var i=0; i0) { pieces.push(','); } @@ -150,7 +150,7 @@ OpenLayers.Format.WKT = OpenLayers.Class(OpenLayers.Format, { */ 'multipoint': function(multipoint) { var array = []; - for(var i=0; i 0) { this.setBounds(this.components[0].getBounds()); - for (var i = 1; i < this.components.length; i++) { + for (var i=1, len=this.components.length; i} Center point for the rotation */ rotate: function(angle, origin) { - for(var i=0; i 1)) { - for(var i=1; i < this.components.length; i++) { + for(var i=1, len=this.components.length; i seg1x2) { // seg1 still left of seg2 diff --git a/lib/OpenLayers/Geometry/LinearRing.js b/lib/OpenLayers/Geometry/LinearRing.js index 409ecee690..844f40656b 100644 --- a/lib/OpenLayers/Geometry/LinearRing.js +++ b/lib/OpenLayers/Geometry/LinearRing.js @@ -116,7 +116,7 @@ OpenLayers.Geometry.LinearRing = OpenLayers.Class( * y - {Float} The y-displacement (in map units) */ move: function(x, y) { - for(var i = 0; i < this.components.length - 1; i++) { + for(var i = 0, len=this.components.length; i} Center point for the rotation */ rotate: function(angle, origin) { - for(var i=0; i 2)) { var sum = 0.0; - for (var i = 0; i < this.components.length - 1; i++) { + for (var i=0, len=this.components.length; i 0)) { area += Math.abs(this.components[0].getArea()); - for (var i = 1; i < this.components.length; i++) { + for (var i=1, len=this.components.length; i= resolution) { highRes = res; @@ -945,7 +945,7 @@ OpenLayers.Layer = OpenLayers.Class({ } else { var diff; var minDiff = Number.POSITIVE_INFINITY; - for(var i=0; i < this.resolutions.length; i++) { + for(var i=0, len=this.resolutions.length; i minDiff) { @@ -1030,7 +1030,7 @@ OpenLayers.Layer = OpenLayers.Class({ setOpacity: function(opacity) { if (opacity != this.opacity) { this.opacity = opacity; - for(var i=0; i 0)) { var maxExtent = new OpenLayers.Bounds(); - for(var i=0; i < this.markers.length; i++) { + for(var i=0, len=this.markers.length; i 0)){ var maxExtent = this.features[0].geometry.getBounds(); - for(var i=0; i < this.features.length; i++){ + for(var i=0, len=this.features.length; i} */ addLayer: function (layer) { - for(var i=0; i < this.layers.length; i++) { + for(var i=0, len=this.layers.length; i )} */ addLayers: function (layers) { - for (var i = 0; i < layers.length; i++) { + for (var i=0, len=layers.length; i 0) { appliedRules = true; - for(var i=0; i