ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Caching array length instead of accessing it with each iteration. r=crschmidt (closes #1636)

Browse Source 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7627 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
This commit is contained in:
Tim Schaub
2008-07-31 04:44:25 +00:00
parent 89b10da8db
commit 66a4c6fb0e
50 changed files with 196 additions and 196 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
lib/OpenLayers/Layer/Vector.js
View File

@@ -219,7 +219,7 @@ OpenLayers.Layer.Vector = OpenLayers.Class(OpenLayers.Layer, {
* and assigns the first one whose "supported()" function returns true.
*/
assignRenderer: function() {
for (var i = 0; i < this.renderers.length; i++) {
for (var i=0, len=this.renderers.length; i<this.renderers.length; i++) {
var rendererClass = OpenLayers.Renderer[this.renderers[i]];
if (rendererClass && rendererClass.prototype.supported()) {
this.renderer = new rendererClass(this.div);
@@ -308,9 +308,8 @@ OpenLayers.Layer.Vector = OpenLayers.Class(OpenLayers.Layer, {
if (!this.drawn || zoomChanged) {
this.drawn = true;
for(var i = 0; i < this.features.length; i++) {
var feature = this.features[i];
this.drawFeature(feature);
for(var i=0, len=this.features.length; i<len; i++) {
this.drawFeature(this.features[i]);
}
}
},
@@ -330,7 +329,7 @@ OpenLayers.Layer.Vector = OpenLayers.Class(OpenLayers.Layer, {
var notify = !options || !options.silent;
for (var i = 0; i < features.length; i++) {
for (var i=0, len=features.length; i<len; i++) {
var feature = features[i];
if (this.geometryType &&
@@ -517,7 +516,7 @@ OpenLayers.Layer.Vector = OpenLayers.Class(OpenLayers.Layer, {
getFeatureById: function(featureId) {
//TBD - would it be more efficient to use a hash for this.features?
var feature = null;
for(var i=0; i<this.features.length; ++i) {
for(var i=0, len=this.features.length; i<len; ++i) {
if(this.features[i].id == featureId) {
feature = this.features[i];
break;
@@ -578,7 +577,7 @@ OpenLayers.Layer.Vector = OpenLayers.Class(OpenLayers.Layer, {
var maxExtent = null;
if( this.features && (this.features.length > 0)){
var maxExtent = this.features[0].geometry.getBounds();
for(var i=0; i < this.features.length; i++){
for(var i=0, len=this.features.length; i<len; i++){
maxExtent.extend(this.features[i].geometry.getBounds());
}
}