ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Caching array length instead of accessing it with each iteration. r=crschmidt (closes #1636)

Browse Source 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7627 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
This commit is contained in:
Tim Schaub
2008-07-31 04:44:25 +00:00
parent 89b10da8db
commit 66a4c6fb0e
50 changed files with 196 additions and 196 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/OpenLayers/Layer/FixedZoomLevels.js
+1 -1
View File
@@ -78,7 +78,7 @@ OpenLayers.Layer.FixedZoomLevels = OpenLayers.Class({
var props = new Array('minZoomLevel', 'maxZoomLevel', 'numZoomLevels');
for(var i=0; i < props.length; i++) {
for(var i=0, len=props.length; i<len; i++) {
var property = props[i];
this[property] = (this.options[property] != null)
? this.options[property]
lib/OpenLayers/Layer/GeoRSS.js
+3 -3
View File
@@ -163,7 +163,7 @@ OpenLayers.Layer.GeoRSS = OpenLayers.Class(OpenLayers.Layer.Markers, {
var format = new OpenLayers.Format.GeoRSS(options);
var features = format.read(doc);
for (var i = 0; i < features.length; i++) {
for (var i=0, len=features.length; i<len; i++) {
var data = {};
var feature = features[i];
@@ -230,14 +230,14 @@ OpenLayers.Layer.GeoRSS = OpenLayers.Class(OpenLayers.Layer.Markers, {
markerClick: function(evt) {
var sameMarkerClicked = (this == this.layer.selectedFeature);
this.layer.selectedFeature = (!sameMarkerClicked) ? this : null;
for(var i=0; i < this.layer.map.popups.length; i++) {
for(var i=0, len=this.layer.map.popups.length; i<len; i++) {
this.layer.map.removePopup(this.layer.map.popups[i]);
}
if (!sameMarkerClicked) {
var popup = this.createPopup();
OpenLayers.Event.observe(popup.div, "click",
OpenLayers.Function.bind(function() {
for(var i=0; i < this.layer.map.popups.length; i++) {
for(var i=0, len=this.layer.map.popups.length; i<len; i++) {
this.layer.map.removePopup(this.layer.map.popups[i]);
}
}, this)
lib/OpenLayers/Layer/Grid.js
+5 -5
View File
@@ -101,9 +101,9 @@ OpenLayers.Layer.Grid = OpenLayers.Class(OpenLayers.Layer.HTTPRequest, {
*/
clearGrid:function() {
if (this.grid) {
for(var iRow=0; iRow < this.grid.length; iRow++) {
for(var iRow=0, len=this.grid.length; iRow<len; iRow++) {
var row = this.grid[iRow];
for(var iCol=0; iCol < row.length; iCol++) {
for(var iCol=0, clen=row.length; iCol<clen; iCol++) {
var tile = row[iCol];
this.removeTileMonitoringHooks(tile);
tile.destroy();
@@ -494,7 +494,7 @@ OpenLayers.Layer.Grid = OpenLayers.Class(OpenLayers.Layer.HTTPRequest, {
}
// now we go through and draw the tiles in forward order
for(var i=0; i < tileQueue.length; i++) {
for(var i=0, len=tileQueue.length; i<len; i++) {
var tile = tileQueue[i];
tile.draw();
//mark tile as unqueued for the next time (since tiles are reused)
@@ -613,7 +613,7 @@ OpenLayers.Layer.Grid = OpenLayers.Class(OpenLayers.Layer.HTTPRequest, {
var row = (prepend) ? grid.pop() : grid.shift();
for (var i=0; i < modelRow.length; i++) {
for (var i=0, len=modelRow.length; i<len; i++) {
var modelTile = modelRow[i];
var bounds = modelTile.bounds.clone();
var position = modelTile.position.clone();
@@ -643,7 +643,7 @@ OpenLayers.Layer.Grid = OpenLayers.Class(OpenLayers.Layer.HTTPRequest, {
var resolution = this.map.getResolution();
var deltaLon = resolution * deltaX;
for (var i=0; i<this.grid.length; i++) {
for (var i=0, len=this.grid.length; i<len; i++) {
var row = this.grid[i];
var modelTileIndex = (prepend) ? 0 : (row.length - 1);
var modelTile = row[modelTileIndex];
lib/OpenLayers/Layer/HTTPRequest.js
+1 -1
View File
@@ -160,7 +160,7 @@ OpenLayers.Layer.HTTPRequest = OpenLayers.Class(OpenLayers.Layer, {
*/
selectUrl: function(paramString, urls) {
var product = 1;
for (var i = 0; i < paramString.length; i++) {
for (var i=0, len=paramString.length; i<len; i++) {
product *= paramString.charCodeAt(i) * this.URL_HASH_FACTOR;
product -= Math.floor(product);
}
lib/OpenLayers/Layer/Markers.js
+3 -3
View File
@@ -69,7 +69,7 @@ OpenLayers.Layer.Markers = OpenLayers.Class(OpenLayers.Layer, {
setOpacity: function(opacity) {
if (opacity != this.opacity) {
this.opacity = opacity;
for (var i = 0; i < this.markers.length; i++) {
for (var i=0, len=this.markers.length; i<len; i++) {
this.markers[i].setOpacity(this.opacity);
}
}
@@ -87,7 +87,7 @@ OpenLayers.Layer.Markers = OpenLayers.Class(OpenLayers.Layer, {
OpenLayers.Layer.prototype.moveTo.apply(this, arguments);
if (zoomChanged || !this.drawn) {
for(var i=0; i < this.markers.length; i++) {
for(var i=0, len=this.markers.length; i<len; i++) {
this.drawMarker(this.markers[i]);
}
this.drawn = true;
@@ -176,7 +176,7 @@ OpenLayers.Layer.Markers = OpenLayers.Class(OpenLayers.Layer, {
if ( this.markers && (this.markers.length > 0)) {
var maxExtent = new OpenLayers.Bounds();
for(var i=0; i < this.markers.length; i++) {
for(var i=0, len=this.markers.length; i<len; i++) {
var marker = this.markers[i];
maxExtent.extend(marker.lonlat);
}
lib/OpenLayers/Layer/PointTrack.js
+1 -1
View File
@@ -58,7 +58,7 @@ OpenLayers.Layer.PointTrack = OpenLayers.Class(OpenLayers.Layer.Vector, {
var lines = new Array(pointFeatures.length-1);
var pointFeature, startPoint, endPoint;
for(var i = 0; i < pointFeatures.length; i++) {
for(var i=0, len=pointFeatures.length; i<len; i++) {
pointFeature = pointFeatures[i];
endPoint = pointFeature.geometry;
lib/OpenLayers/Layer/Text.js
+2 -2
View File
@@ -157,7 +157,7 @@ OpenLayers.Layer.Text = OpenLayers.Class(OpenLayers.Layer.Markers, {
var parser = new OpenLayers.Format.Text(options);
features = parser.read(text);
for (var i = 0; i < features.length; i++) {
for (var i=0, len=features.length; i<len; i++) {
var data = {};
var feature = features[i];
var location;
@@ -237,7 +237,7 @@ OpenLayers.Layer.Text = OpenLayers.Class(OpenLayers.Layer.Markers, {
markerClick: function(evt) {
var sameMarkerClicked = (this == this.layer.selectedFeature);
this.layer.selectedFeature = (!sameMarkerClicked) ? this : null;
for(var i=0; i < this.layer.map.popups.length; i++) {
for(var i=0, len=this.layer.map.popups.length; i<len; i++) {
this.layer.map.removePopup(this.layer.map.popups[i]);
}
if (!sameMarkerClicked) {
lib/OpenLayers/Layer/Vector.js
+6 -7
View File
@@ -219,7 +219,7 @@ OpenLayers.Layer.Vector = OpenLayers.Class(OpenLayers.Layer, {
* and assigns the first one whose "supported()" function returns true.
*/
assignRenderer: function() {
for (var i = 0; i < this.renderers.length; i++) {
for (var i=0, len=this.renderers.length; i<this.renderers.length; i++) {
var rendererClass = OpenLayers.Renderer[this.renderers[i]];
if (rendererClass && rendererClass.prototype.supported()) {
this.renderer = new rendererClass(this.div);
@@ -308,9 +308,8 @@ OpenLayers.Layer.Vector = OpenLayers.Class(OpenLayers.Layer, {
if (!this.drawn || zoomChanged) {
this.drawn = true;
for(var i = 0; i < this.features.length; i++) {
var feature = this.features[i];
this.drawFeature(feature);
for(var i=0, len=this.features.length; i<len; i++) {
this.drawFeature(this.features[i]);
}
}
},
@@ -330,7 +329,7 @@ OpenLayers.Layer.Vector = OpenLayers.Class(OpenLayers.Layer, {
var notify = !options || !options.silent;
for (var i = 0; i < features.length; i++) {
for (var i=0, len=features.length; i<len; i++) {
var feature = features[i];
if (this.geometryType &&
@@ -517,7 +516,7 @@ OpenLayers.Layer.Vector = OpenLayers.Class(OpenLayers.Layer, {
getFeatureById: function(featureId) {
//TBD - would it be more efficient to use a hash for this.features?
var feature = null;
for(var i=0; i<this.features.length; ++i) {
for(var i=0, len=this.features.length; i<len; ++i) {
if(this.features[i].id == featureId) {
feature = this.features[i];
break;
@@ -578,7 +577,7 @@ OpenLayers.Layer.Vector = OpenLayers.Class(OpenLayers.Layer, {
var maxExtent = null;
if( this.features && (this.features.length > 0)){
var maxExtent = this.features[0].geometry.getBounds();
for(var i=0; i < this.features.length; i++){
for(var i=0, len=this.features.length; i<len; i++){
maxExtent.extend(this.features[i].geometry.getBounds());
}
}