ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Caching array length instead of accessing it with each iteration. r=crschmidt (closes #1636)

Browse Source 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7627 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
This commit is contained in:
Tim Schaub
2008-07-31 04:44:25 +00:00
parent 89b10da8db
commit 66a4c6fb0e
50 changed files with 196 additions and 196 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/OpenLayers/Geometry/Polygon.js
+6 -6
View File
@@ -52,7 +52,7 @@ OpenLayers.Geometry.Polygon = OpenLayers.Class(
var area = 0.0;
if ( this.components && (this.components.length > 0)) {
area += Math.abs(this.components[0].getArea());
for (var i = 1; i < this.components.length; i++) {
for (var i=1, len=this.components.length; i<len; i++) {
area -= Math.abs(this.components[i].getArea());
}
}
@@ -112,13 +112,13 @@ OpenLayers.Geometry.Polygon = OpenLayers.Class(
*/
intersects: function(geometry) {
var intersect = false;
var i;
var i, len;
if(geometry.CLASS_NAME == "OpenLayers.Geometry.Point") {
intersect = this.containsPoint(geometry);
} else if(geometry.CLASS_NAME == "OpenLayers.Geometry.LineString" ||
geometry.CLASS_NAME == "OpenLayers.Geometry.LinearRing") {
// check if rings/linestrings intersect
for(i=0; i<this.components.length; ++i) {
for(i=0, len=this.components.length; i<len; ++i) {
intersect = geometry.intersects(this.components[i]);
if(intersect) {
break;
@@ -126,7 +126,7 @@ OpenLayers.Geometry.Polygon = OpenLayers.Class(
}
if(!intersect) {
// check if this poly contains points of the ring/linestring
for(i=0; i<geometry.components.length; ++i) {
for(i=0, len=geometry.components.length; i<len; ++i) {
intersect = this.containsPoint(geometry.components[i]);
if(intersect) {
break;
@@ -134,7 +134,7 @@ OpenLayers.Geometry.Polygon = OpenLayers.Class(
}
}
} else {
for(i=0; i<geometry.components.length; ++ i) {
for(i=0, len=geometry.components.length; i<len; ++ i) {
intersect = this.intersects(geometry.components[i]);
if(intersect) {
break;
@@ -145,7 +145,7 @@ OpenLayers.Geometry.Polygon = OpenLayers.Class(
if(!intersect && geometry.CLASS_NAME == "OpenLayers.Geometry.Polygon") {
// exterior ring points will be contained in the other geometry
var ring = this.components[0];
for(i=0; i<ring.components.length; ++i) {
for(i=0, len=ring.components.length; i<len; ++i) {
intersect = geometry.containsPoint(ring.components[i]);
if(intersect) {
break;