ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Caching array length instead of accessing it with each iteration. r=crschmidt (closes #1636)

Browse Source 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7627 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
This commit is contained in:
Tim Schaub
2008-07-31 04:44:25 +00:00
parent 89b10da8db
commit 66a4c6fb0e
50 changed files with 196 additions and 196 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
lib/OpenLayers/Format/SLD/v1.js
View File

@@ -115,7 +115,7 @@ OpenLayers.Format.SLD.v1 = OpenLayers.Class(OpenLayers.Format.XML, {
};
this.readChildNodes(node, layer);
// give each of the user styles this layer name
for(var i=0; i<layer.userStyles.length; ++i) {
for(var i=0, len=layer.userStyles.length; i<len; ++i) {
layer.userStyles[i].layerName = layer.name;
}
sld.namedLayers[layer.name] = layer;
@@ -210,7 +210,7 @@ OpenLayers.Format.SLD.v1 = OpenLayers.Class(OpenLayers.Format.XML, {
"graphicName", "rotation", "graphicFormat"
];
var prop, value;
for(var i=0; i<properties.length; ++i) {
for(var i=0, len=properties.length; i<len; ++i) {
prop = properties[i];
value = graphic[prop];
if(value != undefined) {
@@ -562,7 +562,7 @@ OpenLayers.Format.SLD.v1 = OpenLayers.Class(OpenLayers.Format.XML, {
// add in named styles
if(layer.namedStyles) {
for(var i=0; i<layer.namedStyles.length; ++i) {
for(var i=0, len=layer.namedStyles.length; i<len; ++i) {
this.writeNode(
node, "NamedStyle", layer.namedStyles[i]
);
@@ -571,7 +571,7 @@ OpenLayers.Format.SLD.v1 = OpenLayers.Class(OpenLayers.Format.XML, {
// add in user styles
if(layer.userStyles) {
for(var i=0; i<layer.userStyles.length; ++i) {
for(var i=0, len=layer.userStyles.length; i<len; ++i) {
this.writeNode(
node, "UserStyle", layer.userStyles[i]
);
@@ -624,7 +624,7 @@ OpenLayers.Format.SLD.v1 = OpenLayers.Class(OpenLayers.Format.XML, {
// related to FeatureTypeStyle
// add in rules
for(var i=0; i<style.rules.length; ++i) {
for(var i=0, len=style.rules.length; i<len; ++i) {
this.writeNode(node, "Rule", style.rules[i]);
}
@@ -670,7 +670,7 @@ OpenLayers.Format.SLD.v1 = OpenLayers.Class(OpenLayers.Format.XML, {
// add in symbolizers (relies on geometry type keys)
var types = OpenLayers.Style.SYMBOLIZER_PREFIXES;
var type, symbolizer;
for(var i=0; i<types.length; ++i) {
for(var i=0, len=types.length; i<len; ++i) {
type = types[i];
symbolizer = rule.symbolizer[type];
if(symbolizer) {
@@ -776,7 +776,7 @@ OpenLayers.Format.SLD.v1 = OpenLayers.Class(OpenLayers.Format.XML, {
var tokens = label.split("${");
node.appendChild(this.createTextNode(tokens[0]));
var item, last;
for(var i=1; i<tokens.length; i++) {
for(var i=1, len=tokens.length; i<len; i++) {
item = tokens[i];
last = item.indexOf("}");
if(last > 0) {
@@ -902,7 +902,7 @@ OpenLayers.Format.SLD.v1 = OpenLayers.Class(OpenLayers.Format.XML, {
var node = this.createElementNSPlus("ogc:Filter");
var sub = filter.CLASS_NAME.split(".").pop();
if(sub == "FeatureId") {
for(var i=0; i<filter.fids.length; ++i) {
for(var i=0, len=filter.fids.length; i<len; ++i) {
this.writeNode(node, "FeatureId", filter.fids[i]);
}
} else {
@@ -918,7 +918,7 @@ OpenLayers.Format.SLD.v1 = OpenLayers.Class(OpenLayers.Format.XML, {
"And": function(filter) {
var node = this.createElementNSPlus("ogc:And");
var childFilter;
for(var i=0; i<filter.filters.length; ++i) {
for(var i=0, len=filter.filters.length; i<len; ++i) {
childFilter = filter.filters[i];
this.writeNode(
node, this.getFilterType(childFilter), childFilter
@@ -929,7 +929,7 @@ OpenLayers.Format.SLD.v1 = OpenLayers.Class(OpenLayers.Format.XML, {
"Or": function(filter) {
var node = this.createElementNSPlus("ogc:Or");
var childFilter;
for(var i=0; i<filter.filters.length; ++i) {
for(var i=0, len=filter.filters.length; i<len; ++i) {
childFilter = filter.filters[i];
this.writeNode(
node, this.getFilterType(childFilter), childFilter
@@ -1103,7 +1103,7 @@ OpenLayers.Format.SLD.v1 = OpenLayers.Class(OpenLayers.Format.XML, {
readChildNodes: function(node, obj) {
var children = node.childNodes;
var child, group, reader, prefix, local;
for(var i=0; i<children.length; ++i) {
for(var i=0, len=children.length; i<len; ++i) {
child = children[i];
if(child.nodeType == 1) {
prefix = this.getNamespacePrefix(child.namespaceURI);