ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Caching array length instead of accessing it with each iteration. r=crschmidt (closes #1636)

Browse Source 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@7627 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
This commit is contained in:
Tim Schaub
2008-07-31 04:44:25 +00:00
parent 89b10da8db
commit 66a4c6fb0e
50 changed files with 196 additions and 196 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
lib/OpenLayers/Format/KML.js
View File

@@ -167,7 +167,7 @@ OpenLayers.Format.KML = OpenLayers.Class(OpenLayers.Format.XML, {
// Loop throught the following node types in this order and
// process the nodes found
var types = ["Link", "NetworkLink", "Style", "StyleMap", "Placemark"];
for(var i=0; i<types.length; ++i) {
for(var i=0, len=types.length; i<len; ++i) {
var type = types[i];
var nodes = this.getElementsByTagNameNS(data, "*", type);
@@ -228,7 +228,7 @@ OpenLayers.Format.KML = OpenLayers.Class(OpenLayers.Format.XML, {
var newOptions = OpenLayers.Util.extend({}, options);
newOptions.depth++;
for(var i=0; i < nodes.length; i++) {
for(var i=0, len=nodes.length; i<len; i++) {
var href = this.parseProperty(nodes[i], "*", "href");
if(href && !this.fetched[href]) {
this.fetched[href] = true; // prevent reloading the same urls
@@ -267,7 +267,7 @@ OpenLayers.Format.KML = OpenLayers.Class(OpenLayers.Format.XML, {
*
*/
parseStyles: function(nodes, options) {
for(var i=0; i < nodes.length; i++) {
for(var i=0, len=nodes.length; i<len; i++) {
var style = this.parseStyle(nodes[i]);
if(style) {
styleName = (options.styleBaseUrl || "") + "#" + style.id;
@@ -291,7 +291,7 @@ OpenLayers.Format.KML = OpenLayers.Class(OpenLayers.Format.XML, {
var types = ["LineStyle", "PolyStyle", "IconStyle", "BalloonStyle"];
var type, nodeList, geometry, parser;
for(var i=0; i<types.length; ++i) {
for(var i=0, len=types.length; i<len; ++i) {
type = types[i];
styleTypeNode = this.getElementsByTagNameNS(node,
"*", type)[0];
@@ -489,13 +489,13 @@ OpenLayers.Format.KML = OpenLayers.Class(OpenLayers.Format.XML, {
// Only the default or "normal" part of the StyleMap is processed now
// To do the select or "highlight" bit, we'd need to change lots more
for(var i=0; i < nodes.length; i++) {
for(var i=0, len=nodes.length; i<len; i++) {
var node = nodes[i];
var pairs = this.getElementsByTagNameNS(node, "*",
"Pair");
var id = node.getAttribute("id");
for (var j=0; j<pairs.length; j++) {
for (var j=0, jlen=pairs.length; j<jlen; j++) {
var pair = pairs[j];
// Use the shortcut in the SLD format to quickly retrieve the
// value of a node. Maybe it's good to have a method in
@@ -530,7 +530,7 @@ OpenLayers.Format.KML = OpenLayers.Class(OpenLayers.Format.XML, {
*/
parseFeatures: function(nodes, options) {
var features = new Array(nodes.length);
for(var i=0; i < nodes.length; i++) {
for(var i=0, len=nodes.length; i<len; i++) {
var featureNode = nodes[i];
var feature = this.parseFeature.apply(this,[featureNode]) ;
if(feature) {
@@ -584,7 +584,7 @@ OpenLayers.Format.KML = OpenLayers.Class(OpenLayers.Format.XML, {
// only accept one geometry per feature - look for highest "order"
var order = ["MultiGeometry", "Polygon", "LineString", "Point"];
var type, nodeList, geometry, parser;
for(var i=0; i<order.length; ++i) {
for(var i=0, len=order.length; i<len; ++i) {
type = order[i];
this.internalns = node.namespaceURI ?
node.namespaceURI : this.kmlns;
@@ -778,7 +778,7 @@ OpenLayers.Format.KML = OpenLayers.Class(OpenLayers.Format.XML, {
if(numRings > 0) {
// this assumes exterior ring first, inner rings after
var ring;
for(var i=0; i<nodeList.length; ++i) {
for(var i=0, len=nodeList.length; i<len; ++i) {
ring = this.parseGeometry.linestring.apply(this,
[nodeList[i], true]);
if(ring) {
@@ -806,7 +806,7 @@ OpenLayers.Format.KML = OpenLayers.Class(OpenLayers.Format.XML, {
var child, parser;
var parts = [];
var children = node.childNodes;
for(var i=0; i<children.length; ++i ) {
for(var i=0, len=children.length; i<len; ++i ) {
child = children[i];
if(child.nodeType == 1) {
var type = (child.prefix) ?
@@ -837,7 +837,7 @@ OpenLayers.Format.KML = OpenLayers.Class(OpenLayers.Format.XML, {
// assume attribute nodes are type 1 children with a type 3 or 4 child
var child, grandchildren, grandchild;
var children = node.childNodes;
for(var i=0; i<children.length; ++i) {
for(var i=0, len=children.length; i<len; ++i) {
child = children[i];
if(child.nodeType == 1) {
grandchildren = child.childNodes;
@@ -909,7 +909,7 @@ OpenLayers.Format.KML = OpenLayers.Class(OpenLayers.Format.XML, {
}
var kml = this.createElementNS(this.kmlns, "kml");
var folder = this.createFolderXML();
for(var i=0; i<features.length; ++i) {
for(var i=0, len=features.length; i<len; ++i) {
folder.appendChild(this.createPlacemarkXML(features[i]));
}
kml.appendChild(folder);
@@ -1108,7 +1108,7 @@ OpenLayers.Format.KML = OpenLayers.Class(OpenLayers.Format.XML, {
var kml = this.createElementNS(this.kmlns, "Polygon");
var rings = geometry.components;
var ringMember, ringGeom, type;
for(var i=0; i<rings.length; ++i) {
for(var i=0, len=rings.length; i<len; ++i) {
type = (i==0) ? "outerBoundaryIs" : "innerBoundaryIs";
ringMember = this.createElementNS(this.kmlns, type);
ringGeom = this.buildGeometry.linearring.apply(this,
@@ -1147,7 +1147,7 @@ OpenLayers.Format.KML = OpenLayers.Class(OpenLayers.Format.XML, {
collection: function(geometry) {
var kml = this.createElementNS(this.kmlns, "MultiGeometry");
var child;
for(var i=0; i<geometry.components.length; ++i) {
for(var i=0, len=geometry.components.length; i<len; ++i) {
child = this.buildGeometryNode.apply(this,
[geometry.components[i]]);
if(child) {