Shader compilation errors are now logged even when the compilation succeeded

This commit is contained in:
jahow
2018-12-01 00:03:05 +01:00
parent 78028893e2
commit 55c36b5aab

View File

@@ -619,11 +619,11 @@ class WebGLHelper extends Disposable {
const vertexShader = this.compileShader(vertexShaderSource, gl.VERTEX_SHADER);
this.shaderCompileErrors_ = null;
if (!gl.getShaderParameter(fragmentShader, gl.COMPILE_STATUS)) {
if (gl.getShaderInfoLog(fragmentShader)) {
this.shaderCompileErrors_ =
`Fragment shader compilation failed:\n${gl.getShaderInfoLog(fragmentShader)}`;
}
if (!gl.getShaderParameter(vertexShader, gl.COMPILE_STATUS)) {
if (gl.getShaderInfoLog(vertexShader)) {
this.shaderCompileErrors_ = (this.shaderCompileErrors_ || '') +
`Vertex shader compilation failed:\n${gl.getShaderInfoLog(vertexShader)}`;
}