From 55c36b5aabae62c3191b3f16898051c158347d43 Mon Sep 17 00:00:00 2001 From: jahow Date: Sat, 1 Dec 2018 00:03:05 +0100 Subject: [PATCH] Shader compilation errors are now logged even when the compilation succeeded --- src/ol/webgl/Helper.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ol/webgl/Helper.js b/src/ol/webgl/Helper.js index 05acb07e57..b0c8039e87 100644 --- a/src/ol/webgl/Helper.js +++ b/src/ol/webgl/Helper.js @@ -619,11 +619,11 @@ class WebGLHelper extends Disposable { const vertexShader = this.compileShader(vertexShaderSource, gl.VERTEX_SHADER); this.shaderCompileErrors_ = null; - if (!gl.getShaderParameter(fragmentShader, gl.COMPILE_STATUS)) { + if (gl.getShaderInfoLog(fragmentShader)) { this.shaderCompileErrors_ = `Fragment shader compilation failed:\n${gl.getShaderInfoLog(fragmentShader)}`; } - if (!gl.getShaderParameter(vertexShader, gl.COMPILE_STATUS)) { + if (gl.getShaderInfoLog(vertexShader)) { this.shaderCompileErrors_ = (this.shaderCompileErrors_ || '') + `Vertex shader compilation failed:\n${gl.getShaderInfoLog(vertexShader)}`; }