ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Don't put the box under the cursor until the mouse moved, prevent errors with the GetFeature and click events. I also removed the no longer valid (and failing) tests. r=elemoine, (Closes #2993)

Browse Source 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@11923 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
This commit is contained in:
pgiraud
2011-04-28 07:09:01 +00:00
parent 7ed03671df
commit 55be96a9dc
2 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/OpenLayers/Handler/Box.js
View File

@@ -99,11 +99,6 @@ OpenLayers.Handler.Box = OpenLayers.Class(OpenLayers.Handler, {
this.map.eventsDiv.appendChild(this.zoomBox);
var offset = this.getBoxOffsets();
var pos = this.dragHandler.start;
this.zoomBox.style.left = (pos.x - offset.left) + "px";
this.zoomBox.style.top = (pos.y - offset.top) + "px";
OpenLayers.Element.addClass(
this.map.eventsDiv, "olDrawBox"
);

8
tests/Handler/Box.html
View File

@@ -39,7 +39,7 @@
map.div.removeChild(testdiv);
var testAll = !isNaN(left);
t.plan(testAll ? 12 : 2);
t.plan(testAll ? 10 : 2);
// we change NaN values to 0 values in the handler's
// boxOffsets object, this is to prevent "invalid
@@ -58,14 +58,10 @@
handler.dragHandler.start = {x: 5, y: 5};
handler.startBox();
offset = handler.getBoxOffsets();
handler.moveBox({x: 10, y: 10});
if (testAll) {
t.eq(parseInt(handler.zoomBox.style.left), 5 - offset.left, "x position of box correct");
t.eq(parseInt(handler.zoomBox.style.top), 5 - offset.top, "y position of box correct");
}
handler.moveBox({x: 10, y: 10});
if (testAll) {
t.eq(parseInt(handler.zoomBox.style.left), 5 - offset.left, "x position of box still correct");
t.eq(parseInt(handler.zoomBox.style.top), 5 - offset.top, "y position of box still correct");
t.eq(parseInt(handler.zoomBox.style.width), 5 + offset.width + 1, "x dimension of box correct");
t.eq(parseInt(handler.zoomBox.style.height), 5 + offset.height + 1, "y dimension of box correct");
}