ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

The createElementNSPlus method should append non-null values to the newly created node. Thanks for the quick review. r=crschmidt (closes #1883)

Browse Source 
git-svn-id: http://svn.openlayers.org/trunk/openlayers@8545 dc9f47b5-9b13-0410-9fdd-eb0c1a62fdaf
This commit is contained in:
Tim Schaub
2008-12-23 20:58:28 +00:00
parent 4a4e7b7e07
commit 40fb641a52
2 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/OpenLayers/Format/XML.js
View File

@@ -493,7 +493,7 @@ OpenLayers.Format.XML = OpenLayers.Class(OpenLayers.Format, {
if(options.attributes) {
this.setAttributes(node, options.attributes);
}
if(options.value) {
if(options.value != null) {
node.appendChild(this.createTextNode(options.value));
}
return node;

16
tests/Format/XML.html
View File

@@ -591,6 +591,22 @@
value: "text value"
}),
expect: "<foo:FooNode xmlns:foo='http://example.com/foo' id='123'>text value<" + "/foo:FooNode>"
}, {
description: "value of 0 gets appended as a text node",
node: format.createElementNSPlus("foo:bar", {value: 0}),
expect: "<foo:bar xmlns:foo='http://example.com/foo'>0</foo:bar>"
}, {
description: "value of false gets appended as a text node",
node: format.createElementNSPlus("foo:bar", {value: false}),
expect: "<foo:bar xmlns:foo='http://example.com/foo'>false</foo:bar>"
}, {
description: "null value does not get appended as a text node",
node: format.createElementNSPlus("foo:bar", {value: null}),
expect: "<foo:bar xmlns:foo='http://example.com/foo'/>"
}, {
description: "undefined value does not get appended as a text node",
node: format.createElementNSPlus("foo:bar"),
expect: "<foo:bar xmlns:foo='http://example.com/foo'/>"
}
];