Revert "Move the popup close box sizing to CSS"

Moving the box size to CSS broke `Popup.setSize()`; the function
expects a width for the padding computation. Because this function is
called before the div is added to the DOM, the size can't be
computed.

This reverts commit 134f24480a.

lib/OpenLayers/Popup.js

@@ -872,11 +872,13 @@ OpenLayers.Popup = OpenLayers.Class({
      */
     addCloseBox: function(callback) {
 
-        this.closeDiv = OpenLayers.Util.createDiv(this.id + "_close");
+        this.closeDiv = OpenLayers.Util.createDiv(
+            this.id + "_close", null, {w: 17, h: 17}
+        );
         this.closeDiv.className = "olPopupCloseBox"; 
         
         // use the content div's css padding to determine if we should
-        //  pad the close div
+        //  padd the close div
         var contentDivPadding = this.getContentDivPadding();
          
         this.closeDiv.style.right = contentDivPadding.right + "px";

notes/2.12.md

@@ -145,6 +145,3 @@ In addition, OpenLayers no longer modifies any native prototypes or objects by d
  * Function.prototype.bindAsEventListener
  * Event.stop
 
-## Popup close box size
-
-The size of the close box is now configurable in CSS instead of the fixed 17x17px (`.olPopupCloseBox`)

theme/default/style.css

@@ -259,8 +259,6 @@ div.olControlSaveFeaturesItemInactive {
 
 .olPopupCloseBox {
   background: url("img/close.gif") no-repeat;
-  width: 17px;
-  height: 17px;
   cursor: pointer;
 }