ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #10935 from ejn/fix-panIntoView-no-options

Browse Source 
Fix calling Overlay.panIntoView with no options
This commit is contained in:
Andreas Hocevar
2020-04-17 11:13:22 +02:00
committed by GitHub
parent f58bfa4438 b543e4dedd
commit 2b0cd742d6
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/ol/Overlay.js
View File

@@ -408,10 +408,10 @@ class Overlay extends BaseObject {
/**
* Pan the map so that the overlay is entirely visible in the current viewport
* (if necessary).
* @param {PanIntoViewOptions|undefined} panIntoViewOptions Options for the pan action
* @param {PanIntoViewOptions=} opt_panIntoViewOptions Options for the pan action
* @api
*/
panIntoView(panIntoViewOptions) {
panIntoView(opt_panIntoViewOptions) {
const map = this.getMap();
if (!map || !map.getTargetElement() || !this.get(Property.POSITION)) {
@@ -425,6 +425,8 @@ class Overlay extends BaseObject {
outerHeight(element),
]);
const panIntoViewOptions = opt_panIntoViewOptions || {};
const myMargin =
panIntoViewOptions.margin === undefined ? 20 : panIntoViewOptions.margin;
if (!containsExtent(mapRect, overlayRect)) {