ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Accept feature without geometry in ol.interaction.Modify

Browse Source
This commit is contained in:
Frederic Junod
2016-08-23 13:48:12 +02:00
parent 9eadf1505a
commit 243f1061df
2 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/ol/interaction/modify.js
View File

@@ -248,7 +248,7 @@ ol.inherits(ol.interaction.Modify, ol.interaction.Pointer);
*/
ol.interaction.Modify.prototype.addFeature_ = function(feature) {
var geometry = feature.getGeometry();
if (geometry.getType() in this.SEGMENT_WRITERS_) {
if (geometry && geometry.getType() in this.SEGMENT_WRITERS_) {
this.SEGMENT_WRITERS_[geometry.getType()].call(this, feature, geometry);
}
var map = this.getMap();

16
test/spec/ol/interaction/modify.test.js
View File

@@ -162,6 +162,22 @@ describe('ol.interaction.Modify', function() {
expect(rbushEntries.length).to.be(1);
expect(rbushEntries[0].feature).to.be(feature);
});
it('accepts feature without geometry', function() {
var feature = new ol.Feature();
var features = new ol.Collection([feature]);
var modify = new ol.interaction.Modify({
features: features
});
var rbushEntries = modify.rBush_.getAll();
expect(rbushEntries.length).to.be(0);
feature.setGeometry(new ol.geom.Point([0, 10]));
rbushEntries = modify.rBush_.getAll();
expect(rbushEntries.length).to.be(1);
expect(rbushEntries[0].feature).to.be(feature);
});
});
describe('vertex deletion', function() {