ashatora/openlayers
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Make GPX format no fail on unsupported geometries

Browse Source
This commit is contained in:
Éric Lemoine
2015-11-02 16:22:15 +01:00
parent cbd1aee0cc
commit 14a1add08d
2 changed files with 25 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/ol/format/gpxformat.js
View File

@@ -839,11 +839,13 @@ ol.format.GPX.GPX_NODE_FACTORY_ = function(value, objectStack, opt_nodeName) {
'value should be an ol.Feature');
var geometry = value.getGeometry();
if (geometry) {
var parentNode = objectStack[objectStack.length - 1].node;
goog.asserts.assert(ol.xml.isNode(parentNode),
'parentNode should be an XML node');
return ol.xml.createElementNS(parentNode.namespaceURI,
ol.format.GPX.GEOMETRY_TYPE_TO_NODENAME_[geometry.getType()]);
var nodeName = ol.format.GPX.GEOMETRY_TYPE_TO_NODENAME_[geometry.getType()];
if (nodeName) {
var parentNode = objectStack[objectStack.length - 1].node;
goog.asserts.assert(ol.xml.isNode(parentNode),
'parentNode should be an XML node');
return ol.xml.createElementNS(parentNode.namespaceURI, nodeName);
}
}
};

18
test/spec/ol/format/gpxformat.test.js
View File

@@ -557,6 +557,23 @@ describe('ol.format.GPX', function() {
});
describe('write unsupported geometries', function() {
beforeEach(function() {
format = new ol.format.GPX();
});
it('does not fail', function() {
var polygon = new ol.geom.Polygon(
[[[0, 0], [2, 2], [4, 0], [0, 0]]]);
var feature = new ol.Feature(polygon);
var features = [feature];
var gpx = format.writeFeatures(features);
var expected =
'<gpx xmlns="http://www.topografix.com/GPX/1/1"/>';
expect(gpx).to.be(expected);
});
});
});
@@ -566,5 +583,6 @@ goog.require('ol.geom.GeometryLayout');
goog.require('ol.geom.LineString');
goog.require('ol.geom.MultiLineString');
goog.require('ol.geom.Point');
goog.require('ol.geom.Polygon');
goog.require('ol.proj');
goog.require('ol.xml');